From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB42C2D0F3 for ; Wed, 1 Apr 2020 22:01:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A01A20772 for ; Wed, 1 Apr 2020 22:01:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="LCq51/ux" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A01A20772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJlPb-0002Dc-41; Wed, 01 Apr 2020 22:00:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJlPZ-0002DW-DB for xen-devel@lists.xenproject.org; Wed, 01 Apr 2020 22:00:37 +0000 X-Inumbo-ID: 37710e8e-7464-11ea-bb47-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 37710e8e-7464-11ea-bb47-12813bfff9fa; Wed, 01 Apr 2020 22:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6nyrWK1yF9oHz/OXopTejPK3X0T3tRoyoqYe5Go48FU=; b=LCq51/uxgQbCFIpqU/DwI4gikX 6EZU5KP3VixUGE3BoqL/gHnFGM0HR0UpIsH55TSegetCjkGXCOZt5yzNcbY+JSqLiOyYGduaQu+aS 8CLD9a9MVyPfoTSyS9hV9GuQqkfjovW5WU79pV2o8Dy25ev9xyi805I1GUI2eCREojWw=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJlPP-0005Mw-S8; Wed, 01 Apr 2020 22:00:27 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jJlPP-00005J-L6; Wed, 01 Apr 2020 22:00:27 +0000 Subject: Re: [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string To: Ian Jackson References: <20200330192157.1335-1-julien@xen.org> <24195.9951.944818.756019@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Wed, 1 Apr 2020 23:00:24 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <24195.9951.944818.756019@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , George Dunlap , "dfaggioli@suse.com" , Christian Lindig , Jan Beulich , David Scott , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Ian, On 31/03/2020 12:17, Ian Jackson wrote: > Julien Grall writes ("[PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string"): >> This series is meant to solve the build issue reported by Dario when >> using recent version of OCaml and -safe-string. > > Thanks. I have reviewed the C tools parts here. I think the ocaml > parts ought to have a review from someone familiar with the ocaml FFI. > >> I took the opportunity to harden a bit more the code by using const more >> often. > > I approve. > > Perhaps we should start building our C code with -Wwrite-strings, > which makes "" have type const char* ? Result would be a giant > constification patch, probably. So I thought I would give a try and see how far I can go: * hypervisor (xen): It is fairly easy to convert, although this is touching code that was imported from other projects (such as acpica). I need to have a look at whether other projects fixed there code and we can backport. * libxc: This is pretty trivial, I will send a patch for it * libxl: This is where it is getting tricky, the main issue is the flexarray framework as we would use it with string (now const char *). I thought we could make the interface const, but it looks like there are a couple of places where we need to modify the content (such as in libxl_json.c). I am not sure yet how to deal with it. In any case, even if we can't use -Wwrite-strings, I can still send patches to use const in more places. Cheers, -- Julien Grall