From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:54339 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966862AbdEXHur (ORCPT ); Wed, 24 May 2017 03:50:47 -0400 Subject: Re: [PATCH 07/31] scsi: Use blk_mq_rq_to_pdu() to convert a request to a SCSI command pointer To: Bart Van Assche , "Martin K . Petersen" , James Bottomley Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Hannes Reinecke References: <20170524003420.5381-1-bart.vanassche@sandisk.com> <20170524003420.5381-8-bart.vanassche@sandisk.com> From: Johannes Thumshirn Message-ID: Date: Wed, 24 May 2017 09:50:44 +0200 MIME-Version: 1.0 In-Reply-To: <20170524003420.5381-8-bart.vanassche@sandisk.com> Content-Type: text/plain; charset=utf-8 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 05/24/2017 02:33 AM, Bart Van Assche wrote: > Since commit e9c787e65c0c ("scsi: allocate scsi_cmnd structures as > part of struct request") struct request and struct scsi_cmnd are > adjacent. This means that there is now an alternative to reading > req->special to convert a pointer to a prepared request into a > SCSI command pointer, namely by using blk_mq_rq_to_pdu(). Make > this change where appropriate. Although this patch does not > change any functionality, it slightly improves performance and > slightly improves readability. > > Signed-off-by: Bart Van Assche > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850