From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F232BC43381 for ; Wed, 13 Feb 2019 22:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBE25222C9 for ; Wed, 13 Feb 2019 22:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395118AbfBMWhk (ORCPT ); Wed, 13 Feb 2019 17:37:40 -0500 Received: from shell.v3.sk ([90.176.6.54]:58129 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727471AbfBMWhj (ORCPT ); Wed, 13 Feb 2019 17:37:39 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 57456100BD3; Wed, 13 Feb 2019 23:37:36 +0100 (CET) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MYl-W-5R0QJO; Wed, 13 Feb 2019 23:37:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 92748100E85; Wed, 13 Feb 2019 23:37:33 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kykTtcoSSWPQ; Wed, 13 Feb 2019 23:37:32 +0100 (CET) Received: from nedofet.lan (ip-89-102-31-34.net.upcbroadband.cz [89.102.31.34]) by zimbra.v3.sk (Postfix) with ESMTPSA id 5AEBF100BD3; Wed, 13 Feb 2019 23:37:32 +0100 (CET) Message-ID: Subject: Re: [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding From: Lubomir Rintel To: Rob Herring Cc: Mark Rutland , Russell King , dri-devel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Date: Wed, 13 Feb 2019 23:37:30 +0100 In-Reply-To: References: <20190120172534.24617-1-lkundrak@v3.sk> <20190120172534.24617-5-lkundrak@v3.sk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-01-21 at 09:35 -0600, Rob Herring wrote: > On Sun, Jan 20, 2019 at 11:26 AM Lubomir Rintel wrote: > > The Marvell Armada DRM master device is a virtual device needed to list all > > nodes that comprise the graphics subsystem. > > > > Signed-off-by: Lubomir Rintel > > --- > > .../display/armada/marvell-armada-drm.txt | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt b/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt > > index de4cca9432c8..3dbfa8047f0b 100644 > > --- a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt > > +++ b/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt > > @@ -1,3 +1,27 @@ > > +Marvell Armada DRM master device > > +================================ > > + > > +The Marvell Armada DRM master device is a virtual device needed to list all > > +nodes that comprise the graphics subsystem. > > + > > +Required properties: > > + > > + - compatible: value should be "marvell,dove-display-subsystem", > > + "marvell,armada-display-subsystem" > > + - ports: a list of phandles pointing to display interface ports of CRTC > > + devices > > + - memory-region: phandle to a node describing memory to be used for the > > + framebuffer > > + > > +Example: > > + > > + display-subsystem { > > + compatible = "marvell,dove-display-subsystem", > > + "marvell,armada-display-subsystem"; > > + memory-region = <&display_reserved>; > > + ports = <&lcd0_port>; > > If there is only one device, you don't need this virtual node. Before I follow up on this and submit a version without the virtual node, I'm wondering: is it okay that the bindings for the LCDC and the framebuffer are in the same file, or would it be preferrable if they were separate? Both styles seem to be used for the display bindings. > > > > + }; > > + > > Marvell Armada LCD controller > > ============================= > > > > -- > > 2.20.1 Lubo