From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0btT-0002BB-UG for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:51:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0btM-0008Ru-1c for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:51:47 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:56157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0btL-0008Rm-RH for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:51:40 -0500 Date: Thu, 23 Feb 2012 11:51:37 -0500 (EST) From: Federico Simoncelli Message-ID: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org ----- Original Message ----- > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mtosatti@redhat.com > Sent: Thursday, February 23, 2012 5:28:23 PM > Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > > On Thu, Feb 23, 2012 at 4:20 PM, Federico Simoncelli > wrote: > > ----- Original Message ----- > >> From: "Stefan Hajnoczi" > >> To: "Federico Simoncelli" > >> Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mtosatti@redhat.com > >> Sent: Thursday, February 23, 2012 5:18:41 PM > >> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > >> > >> On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi > >> > >> wrote: > >> > By the way, this code does not build against qemu.git/master. > >> > =C2=A0It > >> > uses > >> > interfaces which have been dropped. > >> > >> Ah, I see you changed that in Patch 2/3. =C2=A0Please don't do that, > >> it's > >> hard to review and breaks git-bisect. > > > > Squashing is easy (anyone could do it at the commit phase), > > reviewing > > is hard (if you hide your changes in someone else's code). > > I don't care if you or Marcelo wrote it, I want to see a coherent > piece of code. > > The way to do it is to merge the g_malloc() and BlockDriver interface > changes into this path. Then you have not snuck any significant > changes into Marcelo's code. Well for example I'd have snuck the qemu_vmalloc/qemu_vfree mistake. > Keep the BDRV_O_NO_BACKING separate. Ok, thanks. -- Federico