From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED952C5DF60 for ; Tue, 5 Nov 2019 18:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8FDC222C1 for ; Tue, 5 Nov 2019 18:56:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="WENQh5YT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390866AbfKES4n (ORCPT ); Tue, 5 Nov 2019 13:56:43 -0500 Received: from mout.web.de ([212.227.15.14]:47805 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390651AbfKES4n (ORCPT ); Tue, 5 Nov 2019 13:56:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1572980184; bh=O04SOfhyjtAX9VIh+fecSSaU9Sn317YdJ9++PLMXLq8=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=WENQh5YTQ3eKy17V6PKei1zGcVUtIB+1GFe8G8J6qo0pvNK3ls/9o4zSzwSNHbMHm s9ehralIBNbyxbfpP4/WN2TkbOkUmiD76EKLZU/wrn4KCNj0x/KVQJOOo3bBqNqMzB ziwPgznkNNrpld77QE9n37bdExHBXHX3yT58lC6A= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.48.164.204]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MPGym-1iWTqS1pke-004U1W; Tue, 05 Nov 2019 19:56:24 +0100 Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() From: Markus Elfring To: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Derek Kiernan , Dragan Cvetic , Greg Kroah-Hartman , Michal Simek Cc: LKML , kernel-janitors@vger.kernel.org References: Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Tue, 5 Nov 2019 19:56:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:0HBPd4tfVS9jcMccgm/pU//DnE0stIF68JhMEcrKFVL2ZEm+m+Q r4aFR7q/eNehC5MB9ecdxTvyVuwcnL9VGXK4cFLq7ora6uJ9fQwYPXSCSR89LgLBd7vEVX+ YnktlkrpiwthwSIYDnlybrKXu6Ql/h0IoMF2V9enWIKYr4CFYqcVqIif59xfSZwDfxKhzX+ HbBtXjzHUNcqxAU/nwMYA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vkgiOJf5RfI=:sDx8/XBVfqV9PXjQNVQ/rx iM5y8XXdWb2jFSbCYOZ2KOX0Wh2w383EtzLhuAfs6beam2m/LNDJNH+Hd4g2NwRpkIt0/cR8q lGNRZGGOvh3S1CBo/peyBt/NVgRnHDY5jnI32CSV1LKpHFG4DoaQY9Xdzq4EiUU4Hvw6E5oBJ O2gGe80uF+NYDSp+Wh9Z3GZFzWFDeEkVOzSzF2RIf15+U7Z9iHdU6lP1lxrFx6yYOocXMJnun 3LwPtZX2WdvJEPcLAKdlaiRH4u9Rc5CBsGF/uf8MFWZk2QAH0hM/k+0+diNd0X1hemuRpwpzt T/whcA+8LWooa5Feb582LgFCQnvrU/E64m1levnFOcD0CkiL7KII9192qsJsauupXEdIo5gWM wlR307vhMBky+6qsDbkfJBDr24yNnyaHr5EdlCwqxsv8TXlqyGAx3sQq8oF8r1CLGvXP6pTo7 lOlWfNqyH4HQ6dVU7dHTXp9EJrYgy4EdiV+y2sMkaDAUNa7vJulSaMYR24BwBSLnx4Cwqh0f9 nnE4Paf3dmmEKbvImAZ1QZwRyNFL9Ud7lWB8Wy7kP2TdAJqp9rhYIO894ZQ1k8o5pxkuBUG/a st2hFcZBClIlyMF8Aoy4bmKeTT9nqZttuF6er8hWVTLympWz4wxj+hvMuEUSZkk5/n1Rxg6Ei NACLoaQIc7wvvI5y9OEJ+zQ/LhKXDqJ0lfVPj4Vajy8TBkwvoNAfvh9XiVHJW/mon2ihg1LvX T8fccNgJj8nJjHzKbKE8raB6jqzH+5zMOk58YJMYmQ+0O2iEXzJexY8N0obl9hbEL4Xd72EMN by+Krlj35ffAbwbTHFgj8QLbZHptDlK5/nw64Mnhd4jGjp6SnFdg4DQpHL7SvcOKw26s8J0Un OInrTZpvaLx7LHiVgr0qMam6Z+X5XOP3Y41zgQsJPkJn3lhCTuAAQPhEK15rWEUXyhWgT+RDl KFy+7JbR1UCg7AOk1re5Ec+1f6jy3SgfzJgK6gpWas8wS2ywcbIr4wrh5KKtORCKgio0oBQkd mcYLofjBtb51vV/JTadXNoSGUcnYAvt3sWJKBWbKle054NKGKjOnrVV90fj231rnBFjV90F40 h9TofE5LTFb+H563LgSX6BudOHJg1K/5CGJ/lvNE/MezUv2AaZW1BFZyt4ZECpN2Arv+Irx4S WbdQWWI8GkNQV6Ix/nBeNKKuj/Hfzh0dMBW6ZN0BDlPjkCu7C2wJ1rgBf4KeUdYVc6f2nJHiY PhMkhOqRkpH5wCTUw4dqcIAfLzWqiG6U+7pYiyz0dTuio92eVRNfeTITeB7U= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 5 Nov 2019 19:32:25 +0100 The same return code was set after three condition checks. Thus use a single statement instead. Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add = ability to configure LDPC") Signed-off-by: Markus Elfring =2D-- drivers/misc/xilinx_sdfec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index a622fcf4954a..322d5c6e6d12 100644 =2D-- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec= , void __user *arg) if (IS_ERR(ldpc)) return PTR_ERR(ldpc); - if (xsdfec->config.code =3D=3D XSDFEC_TURBO_CODE) { - ret =3D -EIO; - goto err_out; - } - - /* Verify Device has not started */ - if (xsdfec->state =3D=3D XSDFEC_STARTED) { - ret =3D -EIO; - goto err_out; - } - - if (xsdfec->config.code_wr_protect) { + if (xsdfec->config.code =3D=3D XSDFEC_TURBO_CODE || + /* Verify device has not started */ + xsdfec->state =3D=3D XSDFEC_STARTED || + xsdfec->config.code_wr_protect) { ret =3D -EIO; goto err_out; } =2D- 2.24.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Tue, 05 Nov 2019 18:56:23 +0000 Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Derek Kiernan , Dragan Cvetic , Greg Kroah-Hartman , Michal Simek Cc: kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Tue, 5 Nov 2019 19:32:25 +0100 The same return code was set after three condition checks. Thus use a single statement instead. Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring --- drivers/misc/xilinx_sdfec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index a622fcf4954a..322d5c6e6d12 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) if (IS_ERR(ldpc)) return PTR_ERR(ldpc); - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { - ret = -EIO; - goto err_out; - } - - /* Verify Device has not started */ - if (xsdfec->state == XSDFEC_STARTED) { - ret = -EIO; - goto err_out; - } - - if (xsdfec->config.code_wr_protect) { + if (xsdfec->config.code == XSDFEC_TURBO_CODE || + /* Verify device has not started */ + xsdfec->state == XSDFEC_STARTED || + xsdfec->config.code_wr_protect) { ret = -EIO; goto err_out; } -- 2.24.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DF2C5DF60 for ; Tue, 5 Nov 2019 18:56:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCF8A204EC for ; Tue, 5 Nov 2019 18:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GcqmzXjN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="WENQh5YT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCF8A204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fQfjWtHYjHbi6gVJzV6L04CkPlo/nyw9wQLuAN5gORY=; b=GcqmzXjNN4sAwG C8aiqf6T2tXDu5e8ZmK6Sd5s+XBlmxla6RX3KySAqnpvXl4H2P5MXCOdOCRiYmYYheYrKf0Tfe4bi QmVyvCDXVA2PrB5INHR/4CjI6wwFLYgfq47MJlAelWbgptCbMNq9X6vSvCyrcHy/5uVLJ5Mwx8KuP 0coS55mnsaGhuJ+yYbq84ptLbgRvtcb9SQPg2+IcwzaHSm2Pa9eroUeQCiOIxl8P2IUnOFF4/9NoT K4YIyqJTFPk5KKG/qBy2Xw6u32Q4gh8EtjbX0Jg71sujrc2XtI7Gj3+1tGM6k72QNfTUSJe9geFij 5lY7bJu/+9NMeLaeverQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS40Q-0000BC-GH; Tue, 05 Nov 2019 18:56:42 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS40N-0000AM-QC for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 18:56:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1572980184; bh=O04SOfhyjtAX9VIh+fecSSaU9Sn317YdJ9++PLMXLq8=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=WENQh5YTQ3eKy17V6PKei1zGcVUtIB+1GFe8G8J6qo0pvNK3ls/9o4zSzwSNHbMHm s9ehralIBNbyxbfpP4/WN2TkbOkUmiD76EKLZU/wrn4KCNj0x/KVQJOOo3bBqNqMzB ziwPgznkNNrpld77QE9n37bdExHBXHX3yT58lC6A= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.48.164.204]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MPGym-1iWTqS1pke-004U1W; Tue, 05 Nov 2019 19:56:24 +0100 Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() From: Markus Elfring To: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Derek Kiernan , Dragan Cvetic , Greg Kroah-Hartman , Michal Simek References: Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Tue, 5 Nov 2019 19:56:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:0HBPd4tfVS9jcMccgm/pU//DnE0stIF68JhMEcrKFVL2ZEm+m+Q r4aFR7q/eNehC5MB9ecdxTvyVuwcnL9VGXK4cFLq7ora6uJ9fQwYPXSCSR89LgLBd7vEVX+ YnktlkrpiwthwSIYDnlybrKXu6Ql/h0IoMF2V9enWIKYr4CFYqcVqIif59xfSZwDfxKhzX+ HbBtXjzHUNcqxAU/nwMYA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vkgiOJf5RfI=:sDx8/XBVfqV9PXjQNVQ/rx iM5y8XXdWb2jFSbCYOZ2KOX0Wh2w383EtzLhuAfs6beam2m/LNDJNH+Hd4g2NwRpkIt0/cR8q lGNRZGGOvh3S1CBo/peyBt/NVgRnHDY5jnI32CSV1LKpHFG4DoaQY9Xdzq4EiUU4Hvw6E5oBJ O2gGe80uF+NYDSp+Wh9Z3GZFzWFDeEkVOzSzF2RIf15+U7Z9iHdU6lP1lxrFx6yYOocXMJnun 3LwPtZX2WdvJEPcLAKdlaiRH4u9Rc5CBsGF/uf8MFWZk2QAH0hM/k+0+diNd0X1hemuRpwpzt T/whcA+8LWooa5Feb582LgFCQnvrU/E64m1levnFOcD0CkiL7KII9192qsJsauupXEdIo5gWM wlR307vhMBky+6qsDbkfJBDr24yNnyaHr5EdlCwqxsv8TXlqyGAx3sQq8oF8r1CLGvXP6pTo7 lOlWfNqyH4HQ6dVU7dHTXp9EJrYgy4EdiV+y2sMkaDAUNa7vJulSaMYR24BwBSLnx4Cwqh0f9 nnE4Paf3dmmEKbvImAZ1QZwRyNFL9Ud7lWB8Wy7kP2TdAJqp9rhYIO894ZQ1k8o5pxkuBUG/a st2hFcZBClIlyMF8Aoy4bmKeTT9nqZttuF6er8hWVTLympWz4wxj+hvMuEUSZkk5/n1Rxg6Ei NACLoaQIc7wvvI5y9OEJ+zQ/LhKXDqJ0lfVPj4Vajy8TBkwvoNAfvh9XiVHJW/mon2ihg1LvX T8fccNgJj8nJjHzKbKE8raB6jqzH+5zMOk58YJMYmQ+0O2iEXzJexY8N0obl9hbEL4Xd72EMN by+Krlj35ffAbwbTHFgj8QLbZHptDlK5/nw64Mnhd4jGjp6SnFdg4DQpHL7SvcOKw26s8J0Un OInrTZpvaLx7LHiVgr0qMam6Z+X5XOP3Y41zgQsJPkJn3lhCTuAAQPhEK15rWEUXyhWgT+RDl KFy+7JbR1UCg7AOk1re5Ec+1f6jy3SgfzJgK6gpWas8wS2ywcbIr4wrh5KKtORCKgio0oBQkd mcYLofjBtb51vV/JTadXNoSGUcnYAvt3sWJKBWbKle054NKGKjOnrVV90fj231rnBFjV90F40 h9TofE5LTFb+H563LgSX6BudOHJg1K/5CGJ/lvNE/MezUv2AaZW1BFZyt4ZECpN2Arv+Irx4S WbdQWWI8GkNQV6Ix/nBeNKKuj/Hfzh0dMBW6ZN0BDlPjkCu7C2wJ1rgBf4KeUdYVc6f2nJHiY PhMkhOqRkpH5wCTUw4dqcIAfLzWqiG6U+7pYiyz0dTuio92eVRNfeTITeB7U= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_105640_146134_882F3571 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Markus Elfring Date: Tue, 5 Nov 2019 19:32:25 +0100 The same return code was set after three condition checks. Thus use a single statement instead. Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring --- drivers/misc/xilinx_sdfec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index a622fcf4954a..322d5c6e6d12 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) if (IS_ERR(ldpc)) return PTR_ERR(ldpc); - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { - ret = -EIO; - goto err_out; - } - - /* Verify Device has not started */ - if (xsdfec->state == XSDFEC_STARTED) { - ret = -EIO; - goto err_out; - } - - if (xsdfec->config.code_wr_protect) { + if (xsdfec->config.code == XSDFEC_TURBO_CODE || + /* Verify device has not started */ + xsdfec->state == XSDFEC_STARTED || + xsdfec->config.code_wr_protect) { ret = -EIO; goto err_out; } -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel