From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 12/16] xen/mm: Switch common/memory.c to use typesafe MFN Date: Thu, 15 Mar 2018 15:03:28 +0000 Message-ID: References: <20180314182009.14274-1-julien.grall@arm.com> <20180314182009.14274-13-julien.grall@arm.com> <5AAA379002000078001B1ED3@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5AAA379002000078001B1ED3@prv-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Tim Deegan , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGkgSmFuLAoKT24gMTUvMDMvMTggMDg6MDYsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDE0 LjAzLjE4IGF0IDE5OjIwLCA8anVsaWVuLmdyYWxsQGFybS5jb20+IHdyb3RlOgo+PiBAQCAtOTUs MTEgKzEwMSwxNyBAQCBzdGF0aWMgdW5zaWduZWQgaW50IG1heF9vcmRlcihjb25zdCBzdHJ1Y3Qg ZG9tYWluICpkKQo+PiAgICAgICByZXR1cm4gbWluKG9yZGVyLCBNQVhfT1JERVIgKyAwVSk7Cj4+ ICAgfQo+PiAgIAo+PiArLyogSGVscGVyIHRvIGNvcHkgYSB0eXBlc2FmZSBNRk4gdG8gZ3Vlc3Qg Ki8KPj4gKyNkZWZpbmUgY29weV9tZm5fdG9fZ3Vlc3QoaG5kLCBvZmYsIG1mbikgICAgICAgICAg ICBcCj4+ICsgICAgKHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXAo+PiArICAgICAgICB4ZW5fcGZuX3QgbWZuXyA9IG1mbl94KG1mbik7ICAgICAgICAgICAg ICAgIFwKPj4gKyAgICAgICAgX19jb3B5X3RvX2d1ZXN0X29mZnNldChobmQsIG9mZiwgJm1mbl8s IDEpOyBcCj4+ICsgICAgfSkKPiAKPiBIb3dldmVyIG11Y2ggSSBkaXNsaWtlIGludHJvZHVjdGlv biBvZiBuZXcgbmFtZSBzcGFjZSB2aW9sYXRpb25zLAo+IEkgdGhpbmsgZm9sbG93aW5nIHRoZSBn bG9iYWwgbmFtaW5nIHByaW5jaXBsZSBoZXJlIGlzIG1vcmUgaW1wb3J0YW50Ogo+IEFzIGEgZnVu Y3Rpb24gbm90IHZhbGlkYXRpbmcgdGhlIGFkZHJlc3MgcmFuZ2UsIHRoaXMgc2hvdWxkIGhhdmUK PiB0d28gbGVhZGluZyB1bmRlcnNjb3Jlcy4gQWxzbyAtIHdhcyB0aGVyZSBhIHJlYXNvbiBmb3Ig dGhpcyBub3QgdG8KPiBiZSBhbiBpbmxpbmUgZnVuY3Rpb24/CgpJIHRob3VnaHQgdGhlIGhhbmRs ZSB3YXMgZGlmZmVyZW50IHR5cGUgYXQgZWFjaCBjYWxsIHNpdGUuIEkgd2FzIHdyb25nLCAKc28g dHVybmVkIGl0IHRvIHN0YXRpYyBpbmxpbmUuCgo+IAo+IFRoZSBvdGhlciB0aGluZyBJIG5vdGlj ZSBvbmx5IG5vdyBpcyBwZXJoYXBzIGEgbGl0dGxlIG11Y2ggdG9vIGFzawo+IGZvciBhIG1vc3Rs eSBtZWNoYW5pY2FsIGNoYW5nZSBsaWtlIHRoaXMgb25lOiBBbGwgdXNlcyBvZiB0aGlzIHNpdAo+ IGluc2lkZSAhcGFnaW5nX21vZGVfdHJhbnNsYXRlKCkgY2hlY2tzLCBoZW5jZSB0aGVzZSBjb3Vs ZCBkbwo+IG5vdGhpbmcgb24gQVJNIGFuZCByZXNvbHZlIHRvIF9fY29weV90b191c2VyKCkgb24g eDg2ICh3aXRoCj4gdGhlIHR5cGUgY2hlY2tpbmcgc3VpdGFibHkgbGlmdGVkIHRvIGhlcmUpLgoK SSBhbSBxdWl0ZSByZWx1Y3RhbnQgdG8gdHVybiB0aGlzIGZ1bmN0aW9uIGFzIG5vcCBmb3IgQXJt LiBUaGlzIGlzIApjb21tb24gY29kZSBhbmQgc2hvdWxkIG5vdCBhc3N1bWUgdGhlIGltcGxlbWVu dGF0aW9uIG9mIApwYWdpbmdfbW9kZV90cmFuc2xhdGUuIEZ1cnRoZXJtb3JlLCBJIGNhbid0IHNl ZSB0aGUgcmVhbCBiZW5lZml0cyBhcyB0aGUgCmNvbXBpbGVyIHdpbGwgb3B0aW1pemUgb3V0IGl0 LgoKPiAKPj4gQEAgLTEzMiw4ICsxNDQsOSBAQCBzdGF0aWMgdm9pZCBpbmNyZWFzZV9yZXNlcnZh dGlvbihzdHJ1Y3QgbWVtb3BfYXJncyAqYSkKPj4gICAgICAgICAgIGlmICggIXBhZ2luZ19tb2Rl X3RyYW5zbGF0ZShkKSAmJgo+PiAgICAgICAgICAgICAgICAhZ3Vlc3RfaGFuZGxlX2lzX251bGwo YS0+ZXh0ZW50X2xpc3QpICkKPj4gICAgICAgICAgIHsKPj4gLSAgICAgICAgICAgIG1mbiA9IHBh Z2VfdG9fbWZuKHBhZ2UpOwo+PiAtICAgICAgICAgICAgaWYgKCB1bmxpa2VseShfX2NvcHlfdG9f Z3Vlc3Rfb2Zmc2V0KGEtPmV4dGVudF9saXN0LCBpLCAmbWZuLCAxKSkgKQo+PiArICAgICAgICAg ICAgbWZuX3QgbWZuID0gcGFnZV90b19tZm4ocGFnZSk7Cj4+ICsKPj4gKyAgICAgICAgICAgIGlm ICggdW5saWtlbHkoY29weV9tZm5fdG9fZ3Vlc3QoYS0+ZXh0ZW50X2xpc3QsIGksIG1mbikpICkK PiAKPiBDYW4ndCB5b3UgYXZvaWQgdGhlIGludGVybWVkaWF0ZSB2YXJpYWJsZSBhbHRvZ2V0aGVy IG5vdz8KCkkgZGlkbid0IGRvIGl0IGJlY2F1c2UgdGhlIGxpbmUgd2FzIGdldHRpbmcgdG9vIGxv bmcgYW5kIHF1aXRlIGRpZmZpY3VsdCAKdG8gcmVhZCBpZiB5b3Ugc3BsaXQgaXQuCgpBbHNvLCB0 ZWNobmljYWxseSB0aGUgY29tcGlsZXIgd2lsbCBiZSBjbGV2ZXIgZW5vdWdoIHRvIG9wdGltaXpl IHRoZSAKY29kZS4gU28gSSBkb24ndCBzZWUgdGhlIGJlbmVmaXRzIG9mIHJlbW92aW5nIHRoZSB2 YXJpYWJsZS4KCkNoZWVycywKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFp bG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=