From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: use regular gendisk registration in device mapper v2
Date: Mon, 9 Aug 2021 11:51:02 -0600 [thread overview]
Message-ID: <b93c771f-792d-b892-c88d-e28c81315860@kernel.dk> (raw)
In-Reply-To: <20210804094147.459763-1-hch@lst.de>
On 8/4/21 3:41 AM, Christoph Hellwig wrote:
> Hi all,
>
> The device mapper code currently has a somewhat odd gendisk registration
> scheme where it calls add_disk early, but uses a special flag to skip the
> "queue registration", which is a major part of add_disk. This series
> improves the block layer holder tracking to work on an entirely
> unregistered disk and thus allows device mapper to use the normal scheme
> of calling add_disk when it is ready to accept I/O.
>
> Note that this leads to a user visible change - the sysfs attributes on
> the disk and the dm directory hanging off it are not only visible once
> the initial table is loaded. This did not make a different to my testing
> using dmsetup and the lvm2 tools.
Applied, thanks.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] use regular gendisk registration in device mapper v2
Date: Mon, 9 Aug 2021 11:51:02 -0600 [thread overview]
Message-ID: <b93c771f-792d-b892-c88d-e28c81315860@kernel.dk> (raw)
In-Reply-To: <20210804094147.459763-1-hch@lst.de>
On 8/4/21 3:41 AM, Christoph Hellwig wrote:
> Hi all,
>
> The device mapper code currently has a somewhat odd gendisk registration
> scheme where it calls add_disk early, but uses a special flag to skip the
> "queue registration", which is a major part of add_disk. This series
> improves the block layer holder tracking to work on an entirely
> unregistered disk and thus allows device mapper to use the normal scheme
> of calling add_disk when it is ready to accept I/O.
>
> Note that this leads to a user visible change - the sysfs attributes on
> the disk and the dm directory hanging off it are not only visible once
> the initial table is loaded. This did not make a different to my testing
> using dmsetup and the lvm2 tools.
Applied, thanks.
--
Jens Axboe
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-09 17:51 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 9:41 use regular gendisk registration in device mapper v2 Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-04 9:41 ` [PATCH 1/8] block: make the block holder code optional Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-04 9:41 ` [PATCH 2/8] block: remove the extra kobject reference in bd_link_disk_holder Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-04 9:41 ` [PATCH 3/8] block: look up holders by bdev Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-04 9:41 ` [PATCH 4/8] block: support delayed holder registration Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
[not found] ` <CGME20210810213058eucas1p109323e3c3ecaa76d37d8cf63b6d8ecfd@eucas1p1.samsung.com>
2021-08-10 21:30 ` Marek Szyprowski
2021-08-10 21:30 ` [dm-devel] " Marek Szyprowski
2021-08-14 21:13 ` Guenter Roeck
2021-08-14 21:13 ` Guenter Roeck
2021-08-15 7:07 ` Christoph Hellwig
2021-08-15 7:07 ` Christoph Hellwig
2021-08-15 14:27 ` Guenter Roeck
2021-08-15 14:27 ` Guenter Roeck
2021-08-16 7:21 ` Christoph Hellwig
2021-08-16 7:21 ` Christoph Hellwig
2021-08-16 14:17 ` Guenter Roeck
2021-08-16 14:17 ` Guenter Roeck
2021-08-20 15:08 ` Christoph Hellwig
2021-08-20 15:08 ` Christoph Hellwig
2021-08-21 3:17 ` Guenter Roeck
2021-08-21 3:17 ` Guenter Roeck
2021-08-18 2:51 ` Guenter Roeck
2021-08-18 2:51 ` Guenter Roeck
2021-08-04 9:41 ` [PATCH 5/8] dm: cleanup cleanup_mapped_device Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-04 9:41 ` [PATCH 6/8] dm: move setting md->type into dm_setup_md_queue Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-04 9:41 ` [PATCH 7/8] dm: delay registering the gendisk Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-09 23:31 ` Alasdair G Kergon
2021-08-09 23:31 ` Alasdair G Kergon
2021-08-10 0:17 ` Alasdair G Kergon
2021-08-10 0:17 ` Alasdair G Kergon
2021-08-10 13:12 ` Peter Rajnoha
2021-08-10 13:12 ` Peter Rajnoha
2021-08-10 15:05 ` Alasdair G Kergon
2021-08-10 15:05 ` Alasdair G Kergon
2022-07-07 3:29 ` Yu Kuai
2022-07-07 3:29 ` [dm-devel] " Yu Kuai
2022-07-07 5:24 ` Christoph Hellwig
2022-07-07 5:24 ` [dm-devel] " Christoph Hellwig
2022-07-07 7:20 ` Yu Kuai
2022-07-07 7:20 ` [dm-devel] " Yu Kuai
2022-07-15 3:24 ` Yu Kuai
2022-07-15 3:24 ` [dm-devel] " Yu Kuai
2022-08-01 1:04 ` Yu Kuai
2022-08-01 1:04 ` [dm-devel] " Yu Kuai
2021-08-04 9:41 ` [PATCH 8/8] block: remove support for delayed queue registrations Christoph Hellwig
2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig
2021-08-09 17:51 ` Jens Axboe [this message]
2021-08-09 17:51 ` [dm-devel] use regular gendisk registration in device mapper v2 Jens Axboe
2021-08-10 0:36 ` Alasdair G Kergon
2021-08-10 0:36 ` Alasdair G Kergon
2021-08-10 14:41 ` Alasdair G Kergon
2021-08-10 14:41 ` Alasdair G Kergon
2021-08-19 15:58 ` holders not working properly, regression [was: Re: use regular gendisk registration in device mapper v2] Mike Snitzer
2021-08-19 15:58 ` [dm-devel] " Mike Snitzer
2021-08-19 18:05 ` Christoph Hellwig
2021-08-19 18:05 ` [dm-devel] " Christoph Hellwig
2021-08-19 22:08 ` Mike Snitzer
2021-08-19 22:08 ` [dm-devel] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93c771f-792d-b892-c88d-e28c81315860@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.