From: Steve Longerbeam <slongerbeam@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>, kernel@pengutronix.de
Subject: Re: [PATCH v5] media: imx: add mem2mem device
Date: Wed, 5 Dec 2018 15:13:12 -0800 [thread overview]
Message-ID: <b93de9f7-0ef7-6b13-594f-c8ef750554ea@gmail.com> (raw)
In-Reply-To: <1e246083-7e97-646c-8602-c36507879b2d@xs4all.nl>
On 12/5/18 10:50 AM, Hans Verkuil wrote:
> On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
>> Hi Hans, Philipp,
>>
>> One comment on my side...
>>
>> On 12/3/18 7:21 AM, Hans Verkuil wrote:
>>> <snip>
>>>> +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
>>>> +{
>>>> + struct mem2mem_priv *priv = to_mem2mem_priv(vdev);
>>>> + struct video_device *vfd = priv->vdev.vfd;
>>>> +
>>>> + mutex_lock(&priv->mutex);
>>>> +
>>>> + if (video_is_registered(vfd)) {
>>>> + video_unregister_device(vfd);
>>>> + media_entity_cleanup(&vfd->entity);
>>> Is this needed?
>>>
>>> If this is to be part of the media controller, then I expect to see a call
>>> to v4l2_m2m_register_media_controller() somewhere.
>>>
>> Yes, I agree there should be a call to
>> v4l2_m2m_register_media_controller(). This driver does not connect with
>> any of the imx-media entities, but calling it will at least make the
>> mem2mem output/capture device entities (and processing entity) visible
>> in the media graph.
>>
>> Philipp, can you pick/squash the following from my media-tree github fork?
>>
>> 6fa05f5170 ("media: imx: mem2mem: Add missing media-device header")
>> d355bf8b15 ("media: imx: Add missing unregister and remove of mem2mem
>> device")
>> 6787a50cdc ("media: imx: mem2mem: Register with media control")
>>
>> Steve
>>
> Why is this driver part of the imx driver? Since it doesn't connect with
> any of the imx-media entities, doesn't that mean that this is really a
> stand-alone driver?
It is basically a stand-alone m2m driver, but it makes use of some
imx-media utility functions like imx_media_enum_format(). Also making it
a true stand-alone driver would require creating a second /dev/mediaN
device.
Steve
next prev parent reply other threads:[~2018-12-05 23:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 11:48 [PATCH v5] media: imx: add mem2mem device Philipp Zabel
2018-12-03 15:21 ` Hans Verkuil
2018-12-05 1:20 ` Steve Longerbeam
2018-12-05 18:50 ` Hans Verkuil
2018-12-05 23:13 ` Steve Longerbeam [this message]
2018-12-06 12:32 ` Hans Verkuil
2018-12-06 22:57 ` Steve Longerbeam
2019-01-08 16:02 ` Philipp Zabel
2019-01-08 16:00 ` Philipp Zabel
2019-01-08 15:59 ` Philipp Zabel
2019-01-07 22:36 ` Nicolas Dufresne
2019-01-08 15:30 ` Philipp Zabel
2019-01-08 17:47 ` Nicolas Dufresne
2019-01-14 21:17 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93de9f7-0ef7-6b13-594f-c8ef750554ea@gmail.com \
--to=slongerbeam@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.