From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net v2 1/4] net/sched: Change tc_action refcnt and bindcnt to atomic Date: Thu, 19 Oct 2017 10:21:18 -0400 Message-ID: References: <1508152718-28726-1-git-send-email-chrism@mellanox.com> <1508152718-28726-2-git-send-email-chrism@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Lucas Bates , Jiri Pirko , David Miller To: Cong Wang , Chris Mi Return-path: Received: from mail-io0-f195.google.com ([209.85.223.195]:47245 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720AbdJSOVY (ORCPT ); Thu, 19 Oct 2017 10:21:24 -0400 Received: by mail-io0-f195.google.com with SMTP id h70so9987076ioi.4 for ; Thu, 19 Oct 2017 07:21:24 -0700 (PDT) In-Reply-To: Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 17-10-18 12:43 PM, Cong Wang wrote: > On Tue, Oct 17, 2017 at 6:03 PM, Chris Mi wrote: >>> -----Original Message----- > > You listed 3 problems, and you think they are 3 different ones, here > I argue problem 3 (using RCU callbacks) is the cause of problem 1 > (refcnt not atomic). This is why I mentioned I have been thinking about > removing RCU callbacks, because it probably could fix all of them. > Cong, Given this is a known bug (the test case Chris presented crashes the kernel) - would it make sense to have a patch that goes to -net to fix this while your approach and discussion outcome goes into net-next? cheers, jamal