From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00EB3C433F5 for ; Thu, 3 Feb 2022 16:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352162AbiBCQOs (ORCPT ); Thu, 3 Feb 2022 11:14:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231744AbiBCQOp (ORCPT ); Thu, 3 Feb 2022 11:14:45 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90831C061714 for ; Thu, 3 Feb 2022 08:14:45 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id r59so2845267pjg.4 for ; Thu, 03 Feb 2022 08:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wwptH0NwA9F4hOq9blkkboSBFwlQPyanOSd1yGsHK+Q=; b=zRDntak0+QyTIre1pp+NGE+uPvJykLkpLCUvgZY26o4CUWqRcpXSh2BpL/R3EFeQUD XB4dVMbljPPnLR148xBQPMe/jmwKFSkzZJ5kJ92k0yHO7ufDst/Y7eT3K88eUm5zueG4 yt9mOO8DRI3h/VSE+F19s0cUG47BTKC7k1ebhirVv2kFxm+UDLccgoW1eHPN3lJkCq5k h6mIz4x4Bta9v1MdYIbeoD4R9nktlADVTVy8bHo5tVC7fDL45+7Q9lXqyMZUkM1SvHH8 tib4q0Pipaoxr3PblfJImsNYxC0LXnkeS8bN8zhmG24U6I62BNq2HU5+G0EwNEunxem8 h+4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wwptH0NwA9F4hOq9blkkboSBFwlQPyanOSd1yGsHK+Q=; b=Mb7itQNg4rrSm135qFanuZUIhNRnkzHylJX4ppcUWzd16jG+/rNNc519ujk/iqtapL l0aMNaOa2JavWbrl3MUGKiCk1EwsTjg389d6gBePeKdkvLtnETaJaqvXBry4DRZ7EATT uz1T4WtW4g55c1lnJ7ESAKuuH7yCuh3u1So5NmwvB0HosfNLRm9vdVfSSIxkuPqZZHRC QUowt/cF8hM9Poj/1rx6jKAzpS1OqAVZG66as7UKUlw/1lu/Dp5Kmqinw59cMla44apK ub3JifsCdWtmlW9VHFsJ7PY2FLppc+TWCrqWasGFbJq5uWDOJT422zHidPi/BOFmTGiV P48Q== X-Gm-Message-State: AOAM533aBU757a/gW4UVruz43RSE4WIoL6K3a+SafHiM/ETiQhi0XAVJ LGKp+r5sqNi9+bJNV9QdfBxHSA== X-Google-Smtp-Source: ABdhPJwB08J2vz0A0gbW0syrGNAlGpamxTzbQJm0c85kqCEQcEjYBCXX1xJIuDp/JFaktfVeqm8xkg== X-Received: by 2002:a17:90a:31c5:: with SMTP id j5mr14715146pjf.200.1643904883250; Thu, 03 Feb 2022 08:14:43 -0800 (PST) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id bj7sm9991089pjb.9.2022.02.03.08.14.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 08:14:42 -0800 (PST) Message-ID: Date: Thu, 3 Feb 2022 08:14:41 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4] sched/fair: Fix fault in reweight_entity Content-Language: en-US To: Dietmar Eggemann , peterz@infradead.org Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Zhang Qiao , stable@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+af7a719bc92395ee41b3@syzkaller.appspotmail.com References: <20220125193403.778497-1-tadeusz.struk@linaro.org> <20220127205623.1258029-1-tadeusz.struk@linaro.org> From: Tadeusz Struk In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/22 01:40, Dietmar Eggemann wrote: >> -static void set_load_weight(struct task_struct *p, bool update_load) >> +static void set_load_weight(struct task_struct *p) >> { >> int prio = p->static_prio - MAX_RT_PRIO; >> struct load_weight *load = &p->se.load; >> + bool update_load = !(READ_ONCE(p->__state) & TASK_NEW); > nit-pick: reverse fir tree order > > cat Documentation/process/maintainer-tip.rst | grep -A 10 "Variable > declarations" > > I was able to recreate the initial issue with the reproducer on arm64 > Juno-r0 with CONFIG_CGROUP_SCHED=y . > > Reviewed-by: Dietmar Eggemann Thanks for reviewing. I will send a v5 soon. -- Thanks, Tadeusz