Re: [PATCH 2/2] weston: upgrade to 4.0.0

From: Khem Raj <raj.khem@gmail.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
	openembedded-core@lists.openembedded.org
Cc: Denys Dmytriyenko <denys@ti.com>
Subject: Re: [PATCH 2/2] weston: upgrade to 4.0.0
Date: Fri, 13 Apr 2018 17:29:18 -0700	[thread overview]
Message-ID: <b9524332-efb4-9211-26d6-0bac84408582@gmail.com> (raw)
In-Reply-To: <2181952.fkZBnDg1uM@peggleto-mobl.ger.corp.intel.com>

On 4/11/18 3:11 PM, Paul Eggleton wrote:
> Yes, this is a bit of a known bug although I didn't actually file one until
> now:
> 
>    https://bugzilla.yoctoproject.org/show_bug.cgi?id=12674
> 
> Cheers,
> Paul
> 
> On Wednesday, 11 April 2018 11:17:51 AM NZST Burton, Ross wrote:
>> Ah presumably this is because the U-S is after the scissors.  Denys,
>> when you add it back, can you put it above the ---?
>>

Upstream-Status is a Yocto project invention that can confuse other 
communities when submitting the patches for those packages upstream and 
Sign-off-by is also in same bucket in many upstream packages. We need to 
be able to support patch headers that are git am'able upstream as well 
as to openembedded recipe created trees.

One still has to delete these tags but if you forget its still is ok 
since they will be ignored with git am.

>> Ross
>>
>> On 11 April 2018 at 00:16, Burton, Ross <ross.burton@intel.com> wrote:
>>> On 10 April 2018 at 20:06, Denys Dmytriyenko <denis@denix.org> wrote:
>>>> diff --git a/meta/recipes-graphics/wayland/weston/0001-make-error-
> portable.patch b/meta/recipes-graphics/wayland/weston/0001-make-error-
> portable.patch
>>>> index 0671a45..6799254 100644
>>>> --- a/meta/recipes-graphics/wayland/weston/0001-make-error-portable.patch
>>>> +++ b/meta/recipes-graphics/wayland/weston/0001-make-error-portable.patch
>>>> @@ -1,26 +1,25 @@
>>>> -From c22e90365d89346258394833cbcad03ff32b2e27 Mon Sep 17 00:00:00 2001
>>>> +From ad1d2161c811cff25d1684c33611f300adb753bc Mon Sep 17 00:00:00 2001
>>>>   From: Khem Raj <raj.khem@gmail.com>
>>>>   Date: Fri, 29 May 2015 20:56:00 -0700
>>>> -Subject: [PATCH weston] make error() portable
>>>> +Subject: [PATCH] make error() portable
>>>>
>>>>   error() is not posix but gnu extension so may not be available on all
>>>>   kind of systemsi e.g. musl.
>>>>
>>>>   Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ----
>>>> -Upstream-Status: Submitted
>>>
>>> Ah, I've seen this before and was wondering if it was a genuine
>>> mistake or devtool being bad.
>>>
>>> devtool refresh is doing A Bad Thing and for some reason dropping the
>>> Upstream-Status tag.  Alex, can you see why this is?  Denys, can you
>>> edit it back in?
>>>
>>> Ross
>>
> 
> 