From: Pavel Begunkov <asml.silence@gmail.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
Date: Sat, 9 Jan 2021 21:25:53 +0000 [thread overview]
Message-ID: <b9558bf8-a7e3-c2f9-ce00-3fc2b90dcc87@gmail.com> (raw)
In-Reply-To: <BYAPR04MB49653C92C7925B8C3EAEF3CE86AD0@BYAPR04MB4965.namprd04.prod.outlook.com>
On 09/01/2021 20:52, Chaitanya Kulkarni wrote:
> On 1/9/21 12:40, Pavel Begunkov wrote:
>> I expect you won't find any, but such little things can pile up
>> into a not-easy-to-spot overhead over time.
>
> That is what I suspected with the resulting assembly. The commit log
> needs to document that there is no direct impact on the performance
It's obvious that 3-4 extra mov $0 off(%reg) won't change performance
but still hasn't been formally confirmed ...
> which can be seen with this patch, but this is nice to have
... so if you don't mind, I won't be resending just for that.
--
Pavel Begunkov
next prev parent reply other threads:[~2021-01-09 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 15:53 [PATCH] target/file: don't zero iter before iov_iter_bvec Pavel Begunkov
2021-01-09 20:09 ` Chaitanya Kulkarni
2021-01-09 20:37 ` Pavel Begunkov
2021-01-09 20:52 ` Chaitanya Kulkarni
2021-01-09 21:25 ` Pavel Begunkov [this message]
2021-01-11 2:06 ` Chaitanya Kulkarni
2021-01-11 2:28 ` Pavel Begunkov
2021-01-11 5:23 ` Chaitanya Kulkarni
2021-01-11 5:31 ` Pavel Begunkov
2021-01-11 2:49 ` Bart Van Assche
2021-01-13 5:34 ` Martin K. Petersen
2021-01-15 4:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9558bf8-a7e3-c2f9-ce00-3fc2b90dcc87@gmail.com \
--to=asml.silence@gmail.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.