From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D72D0C433EF for ; Thu, 21 Apr 2022 11:21:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5B22839FD; Thu, 21 Apr 2022 13:21:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650540061; bh=TN7DA449du+SSxUPHYLKAP6N3Umtn0niJKjM5xd/Ufs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pz3VG23nd85FuA5VEVom9JnydarRH4oxAegyTtDbdR4u7YX3EI2SCqhUMxg9tl3cp 0kJXARxOjeHIWJbGQAlzhEIAkEurWzNlr8SWj2MUw/jieOwZj2ZYYY6BaG7fz7T3TG IIG6cxTrMAXDYfCP+zOl2sUKz8iz73AWooFNS8QOMDtdTJmbjYzGaQs9xfB/AxsiB0 laOqCOYEOXG3MzryXRHrCBYW95euwJDTxTam9uZ+hwLvQ9wmdI1pJzBshpMvWm1bop m2iKS6sdgH91z8JYRuL01KCLj0MdoD9T1OICKIAhmS89Rqgo+cvTzBZk4UlX/UpvCQ k0Xs+MlQG3m4g== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C676E8394D; Thu, 21 Apr 2022 13:20:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650540059; bh=TN7DA449du+SSxUPHYLKAP6N3Umtn0niJKjM5xd/Ufs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rRjGGWWgrxvap6iIorG/xzd623WiTQsNGyM2fNqA21O3N85oIeJJAU0qiwoR+/Ao1 1gVkpzu8DLH/uJcFr7VybbM7AgVlvQdIxCN28hOxbs2sNnul6JhQluIYLg3XPTENHB kwfwO+pYeCpUVCYS/LHC7EmR333JJmN60ONWu9h6l7KRYqj61esPZTwDwwlgB6hGlQ kOS2M4MNw1r2FL78z9PBnXPfux9DhOPiYgqwffxh/zFuKP+Dq9F5FYlV70SWlyOR8G ccN5dfj0Qx6PGa9jurcwEckuvBc/EqVKDRHdFHO8o2frZ+CPTMaTlyZuOp1TRVR89y 0sso4/sntsboQ== Message-ID: Date: Thu, 21 Apr 2022 13:20:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: imx8mm eLCDIF clock Content-Language: en-US To: Adam Ford , Tommaso Merciai Cc: U-Boot Mailing List , Lukasz Majewski , Sean Anderson , Fabio Estevam , Tim Harvey , Michael Trimarchi References: <20220421064805.GA2335@tom-ThinkPad-T14s-Gen-2i> <20220421102907.GC2335@tom-ThinkPad-T14s-Gen-2i> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/21/22 13:14, Adam Ford wrote: > On Thu, Apr 21, 2022 at 5:29 AM Tommaso Merciai > wrote: >> >> On Thu, Apr 21, 2022 at 08:48:05AM +0200, Tommaso Merciai wrote: >> >> + Fabio >> + Tim >> + Michael >> + Marek >> + Adam >> >>> Hi, >>> I'm working on drivers/clk/imx/clk-imx8mm.c to port and bring up eLCDIF >>> clocks. After port all necessary clocks needed by eLCDIF I found that >>> IMX8MM_VIDEO_PLL1 clock is not enabled and need the clk_enable to enable >>> it at the end of the clk-imx8mm probe: >>> >>> struct clk *clkp; >>> >>> clk_get_by_id(IMX8MM_VIDEO_PLL1, &clkp); >>> clk_set_rate(clkp, 594000000UL); >>> clk_enable(clkp); >>> >>> What do you think about this solution? >>> There is a more standard way to do this? >>> I'm missing somethings? > > I think the LCD driver should request the clock and clock rate based > on settings the device tree. However, I think the bigger issues is > that you might run into issues with the lack of a disp-blkctrl driver. > Marek enable the GPC driver fairly recently, but the blkctrl driver > will be needed to enable the LCD and DSI portions or the system may > hang. Just boot quickly and init the graphics pipeline in Linux ?