From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH 5/9] drm/i915/ehl: All EHL ports are combo phys Date: Thu, 14 Mar 2019 20:27:17 +0000 Message-ID: References: <20190313211144.4842-1-rodrigo.vivi@intel.com> <20190313211144.4842-5-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0785241228==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 192896E30E for ; Thu, 14 Mar 2019 20:27:20 +0000 (UTC) In-Reply-To: <20190313211144.4842-5-rodrigo.vivi@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============0785241228== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-IsyyZ738ixDDONbktEGS" --=-IsyyZ738ixDDONbktEGS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-03-13 at 14:11 -0700, Rodrigo Vivi wrote: > From: Bob Paauwe >=20 > Unlike ICL, all of the output ports are combo phys so just return > true in is_port_combophy for all EHL ports to indicate that. >=20 > Signed-off-by: Bob Paauwe > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 2b25098d47a9..920f647bd451 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -6170,6 +6170,9 @@ bool intel_port_is_combophy(struct > drm_i915_private *dev_priv, enum port port) > if (port =3D=3D PORT_NONE) > return false; > =20 > + if (IS_ELKHARTLAKE(dev_priv)) > + return port <=3D PORT_C; > + > if (INTEL_GEN(dev_priv) >=3D 11) > return port <=3D PORT_B; > =20 You also need to change intel_port_is_tc(), several places only checks for it and it would be broken for PORT_C in EHL. bool intel_port_is_tc(struct drm_i915_private *dev_priv, enum port port) { if (INTEL_GEN(dev_priv) >=3D 11 && !IS_ELKHARTLAKE(dev_priv)) return port >=3D PORT_C && port <=3D PORT_F; return false; } --=-IsyyZ738ixDDONbktEGS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlyKuSMACgkQVenbO/mO WkmVmAf9E4STji7bmSXZIURokNKZ0CfGwUIVpTHwFP/VY7u7gCyZreNdUKe33IHE /uMOgJ5pplrKrsBsWleC4TTS2yDahiFuOw/EhCYvcRsM+V8ep+qtY4M9WwIqDP0c chbTBUlYJ4JTCF0qwUyOaG6Vu0efGoiSi9IA9P53fu4rXkDlK1Cwy/nClehNGZNO UyDPtXMD12vmr3tP1xLbM+aFeglOD2r5YYqGJYAE88+KOXWz9Ihm4+Y9ikhsVrrc lQQgRVzSZQIz4jW26BmSjKUfZGhjjDTyE80ZbC3PfKHOm85mDH62xy70f/+B3HLz w1q+apg36x16/3H+KqJccGEuXfzXFw== =q6kB -----END PGP SIGNATURE----- --=-IsyyZ738ixDDONbktEGS-- --===============0785241228== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0785241228==--