From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH igt 2/3] igt/perf_pmu: Stop peeking at intel_mmio registers Date: Fri, 24 Nov 2017 08:55:13 +0000 Message-ID: References: <20171123082237.9733-1-chris@chris-wilson.co.uk> <20171123082237.9733-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAC016E4D5 for ; Fri, 24 Nov 2017 08:55:43 +0000 (UTC) In-Reply-To: <20171123082237.9733-3-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIzLzExLzIwMTcgMDg6MjIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBQcm9ncmFtIHRoZSBN SV9XQUlUX0ZPUl9FVkVOVCB3aXRob3V0IHJlZmVyZW5jZSB0byBERVJSTVIgYnkga25vd2luZyBp dHMKPiBzdGF0ZSBpcyB+MHUgd2hlbiBub3QgaW4gdXNlLCBhbmQgaXMgb25seSBpbiB1c2Ugd2hl biB1c2Vyc3BhY2UgcmVxdWlyZXMKPiBpdC4gQnkgbm90IHRvdWNoaW5nIGludGVsX3JlZ3NpdGVy X2FjY2VzcyB3ZSBjb21wbGV0ZWx5IGVsaW1pbmF0ZSB0aGUKPiByaXNrIHRoYXQgd2UgbGVhayB0 aGUgZm9yY2V3YWtlIHJlZiwgd2hpY2ggY2FuIGNhdXNlIGxhdGVyIHJjNiB0byBmYWlsLgo+IAo+ IEF0IHRoZSBzYW1lIHRpbWUsIG5vdGUgdGhhdCB2bHYvY2h2IHVzZSBhIGRpZmZlcmVudCBtZWNo YW5pc20gKHJlYWQKPiBub25lKSBmb3IgY291cGxpbmcgYmV0d2VlbiB0aGUgcmVuZGVyIGVuZ2lu ZSBhbmQgZGlzcGxheS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIHRlc3RzL3BlcmZfcG11LmMgfCA2MyArKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS90ZXN0cy9wZXJmX3BtdS5jIGIvdGVzdHMvcGVyZl9wbXUuYwo+IGluZGV4IDUxMThj MDIzLi43ZmQxNTA2ZSAxMDA2NDQKPiAtLS0gYS90ZXN0cy9wZXJmX3BtdS5jCj4gKysrIGIvdGVz dHMvcGVyZl9wbXUuYwo+IEBAIC00OTgsMjAgKzQ5OCwyMiBAQCBldmVudF93YWl0KGludCBnZW1f ZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZSkKPiAgIHsKPiAgIAlz dHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNfb2JqZWN0MiBvYmogPSB7IH07Cj4gICAJc3RydWN0IGRy bV9pOTE1X2dlbV9leGVjYnVmZmVyMiBlYiA9IHsgfTsKPiAtCWRhdGFfdCBkYXRhOwo+IC0JaWd0 X2Rpc3BsYXlfdCAqZGlzcGxheSA9ICZkYXRhLmRpc3BsYXk7Cj4gICAJY29uc3QgdWludDMyX3Qg REVSUk1SID0gMHg0NDA1MDsKPiArCWNvbnN0IHVpbnQzMl90IEZPUkNFV0FLRV9NVCA9IDB4YTE4 ODsKPiAgIAl1bnNpZ25lZCBpbnQgdmFsaWRfdGVzdHMgPSAwOwo+IC0JdWludDMyX3QgYmF0Y2hb OF0sICpiOwo+ICsJdWludDMyX3QgYmF0Y2hbMTZdLCAqYjsKPiArCXVpbnQxNl90IGRldmlkOwo+ ICAgCWlndF9vdXRwdXRfdCAqb3V0cHV0Owo+IC0JdWludDMyX3QgYmJfaGFuZGxlOwo+IC0JdWlu dDMyX3QgcmVnOwo+ICsJZGF0YV90IGRhdGE7Cj4gICAJZW51bSBwaXBlIHA7Cj4gICAJaW50IGZk Owo+ICAgCj4gLQlpZ3RfcmVxdWlyZShpbnRlbF9nZW4oaW50ZWxfZ2V0X2RybV9kZXZpZChnZW1f ZmQpKSA+PSA2KTsKPiAtCWlndF9yZXF1aXJlKGludGVsX3JlZ2lzdGVyX2FjY2Vzc19pbml0KGlu dGVsX2dldF9wY2lfZGV2aWNlKCksCj4gLQkJCQkJICAgICAgIGZhbHNlLCBnZW1fZmQpID09IDAp Owo+ICsJZGV2aWQgPSBpbnRlbF9nZXRfZHJtX2RldmlkKGdlbV9mZCk7Cj4gKwlpZ3RfcmVxdWly ZShpbnRlbF9nZW4oZGV2aWQpID49IDcpOwo+ICsJaWd0X3NraXBfb24oSVNfVkFMTEVZVklFVyhk ZXZpZCkgfHwgSVNfQ0hFUlJZVklFVyhkZXZpZCkpOwo+ICsKPiArCWttc3Rlc3Rfc2V0X3Z0X2dy YXBoaWNzX21vZGUoKTsKPiArCWlndF9kaXNwbGF5X2luaXQoJmRhdGEuZGlzcGxheSwgZ2VtX2Zk KTsKPiAgIAo+ICAgCS8qKgo+ICAgCSAqIFdlIHdpbGwgdXNlIHRoZSBkaXNwbGF5IHRvIHJlbmRl ciBldmVudCBmb3J3YXJpbmQgc28gbmVlZCB0bwo+IEBAIC01MjIsNTEgKzUyNCw1MiBAQCBldmVu dF93YWl0KGludCBnZW1fZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAq ZSkKPiAgIAkgKiBsaXN0ZW4gdG8gdGhlIHJlY29yZGVkIHRpbWUgc3BlbnQgaW4gZW5naW5lIHdh aXQgc3RhdGUgYXMgcmVwb3J0ZWQKPiAgIAkgKiBieSB0aGUgUE1VLgo+ICAgCSAqLwo+IC0JcmVn ID0gaW50ZWxfcmVnaXN0ZXJfcmVhZChERVJSTVIpOwo+IC0KPiAtCWttc3Rlc3Rfc2V0X3Z0X2dy YXBoaWNzX21vZGUoKTsKPiAtCWlndF9kaXNwbGF5X2luaXQoJmRhdGEuZGlzcGxheSwgZ2VtX2Zk KTsKPiAtCj4gLQliYl9oYW5kbGUgPSBnZW1fY3JlYXRlKGdlbV9mZCwgNDA5Nik7Cj4gKwlvYmou aGFuZGxlID0gZ2VtX2NyZWF0ZShnZW1fZmQsIDQwOTYpOwo+ICAgCj4gICAJYiA9IGJhdGNoOwo+ ICAgCSpiKysgPSBNSV9MT0FEX1JFR0lTVEVSX0lNTTsKPiArCSpiKysgPSBGT1JDRVdBS0VfTVQ7 Cj4gKwkqYisrID0gMiA8PCAxNiB8IDI7Cj4gKwkqYisrID0gTUlfTE9BRF9SRUdJU1RFUl9JTU07 Cj4gICAJKmIrKyA9IERFUlJNUjsKPiAtCSpiKysgPSByZWcgJiB+KCgxIDw8IDMpIHwgKDEgPDwg MTEpIHwgKDEgPDwgMjEpKTsKPiAtCSpiKysgPSBNSV9XQUlUX0ZPUl9FVkVOVCB8IE1JX1dBSVRf Rk9SX1BJUEVfQV9WQkxBTks7Cj4gKwkqYisrID0gfjB1Owo+ICsJKmIrKyA9IE1JX1dBSVRfRk9S X0VWRU5UOwo+ICAgCSpiKysgPSBNSV9MT0FEX1JFR0lTVEVSX0lNTTsKPiAgIAkqYisrID0gREVS Uk1SOwo+IC0JKmIrKyA9IHJlZzsKPiArCSpiKysgPSB+MHU7Cj4gKwkqYisrID0gTUlfTE9BRF9S RUdJU1RFUl9JTU07Cj4gKwkqYisrID0gRk9SQ0VXQUtFX01UOwo+ICsJKmIrKyA9IDIgPDwgMTY7 Cj4gICAJKmIrKyA9IE1JX0JBVENIX0JVRkZFUl9FTkQ7Cj4gICAKPiAtCW9iai5oYW5kbGUgPSBi Yl9oYW5kbGU7Cj4gLQo+ICAgCWViLmJ1ZmZlcl9jb3VudCA9IDE7Cj4gICAJZWIuYnVmZmVyc19w dHIgPSB0b191c2VyX3BvaW50ZXIoJm9iaik7Cj4gICAJZWIuZmxhZ3MgPSBlMnJpbmcoZ2VtX2Zk LCBlKSB8IEk5MTVfRVhFQ19TRUNVUkU7Cj4gICAKPiAtCWZvcl9lYWNoX3BpcGVfd2l0aF92YWxp ZF9vdXRwdXQoZGlzcGxheSwgcCwgb3V0cHV0KSB7Cj4gKwlmb3JfZWFjaF9waXBlX3dpdGhfdmFs aWRfb3V0cHV0KCZkYXRhLmRpc3BsYXksIHAsIG91dHB1dCkgewo+ICAgCQlzdHJ1Y3QgaWd0X2hl bHBlcl9wcm9jZXNzIHdhaXRlciA9IHsgfTsKPiAgIAkJY29uc3QgdW5zaWduZWQgaW50IGZyYW1l cyA9IDM7Cj4gLQkJdW5zaWduZWQgaW50IGZyYW1lOwo+ICAgCQl1aW50NjRfdCB2YWxbMl07Cj4g ICAKPiAtCQliYXRjaFszXSA9IE1JX1dBSVRfRk9SX0VWRU5UOwo+ICsJCWJhdGNoWzZdID0gTUlf V0FJVF9GT1JfRVZFTlQ7Cj4gICAJCXN3aXRjaCAocCkgewo+ICAgCQljYXNlIFBJUEVfQToKPiAt CQkJYmF0Y2hbM10gfD0gTUlfV0FJVF9GT1JfUElQRV9BX1ZCTEFOSzsKPiArCQkJYmF0Y2hbNl0g fD0gTUlfV0FJVF9GT1JfUElQRV9BX1ZCTEFOSzsKPiArCQkJYmF0Y2hbNV0gPSB+KDEgPDwgMyk7 Cj4gICAJCQlicmVhazsKPiAgIAkJY2FzZSBQSVBFX0I6Cj4gLQkJCWJhdGNoWzNdIHw9IE1JX1dB SVRfRk9SX1BJUEVfQl9WQkxBTks7Cj4gKwkJCWJhdGNoWzZdIHw9IE1JX1dBSVRfRk9SX1BJUEVf Ql9WQkxBTks7Cj4gKwkJCWJhdGNoWzVdID0gfigxIDw8IDExKTsKPiAgIAkJCWJyZWFrOwo+ICAg CQljYXNlIFBJUEVfQzoKPiAtCQkJYmF0Y2hbM10gfD0gTUlfV0FJVF9GT1JfUElQRV9DX1ZCTEFO SzsKPiArCQkJYmF0Y2hbNl0gfD0gTUlfV0FJVF9GT1JfUElQRV9DX1ZCTEFOSzsKPiArCQkJYmF0 Y2hbNV0gPSB+KDEgPDwgMjEpOwo+ICAgCQkJYnJlYWs7Cj4gICAJCWRlZmF1bHQ6Cj4gICAJCQlj b250aW51ZTsKPiAgIAkJfQo+ICAgCj4gLQkJZ2VtX3dyaXRlKGdlbV9mZCwgYmJfaGFuZGxlLCAw LCBiYXRjaCwgc2l6ZW9mKGJhdGNoKSk7Cj4gKwkJZ2VtX3dyaXRlKGdlbV9mZCwgb2JqLmhhbmRs ZSwgMCwgYmF0Y2gsIHNpemVvZihiYXRjaCkpOwo+ICAgCj4gICAJCWRhdGEucGlwZSA9IHA7Cj4g ICAJCXByZXBhcmVfY3J0YygmZGF0YSwgZ2VtX2ZkLCBvdXRwdXQpOwo+IEBAIC01ODksOSArNTky LDkgQEAgZXZlbnRfd2FpdChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9u X2VuZ2luZTIgKmUpCj4gICAJCQl9Cj4gICAJCX0KPiAgIAo+IC0JCWZvciAoZnJhbWUgPSAwOyBm cmFtZSA8IGZyYW1lczsgZnJhbWUrKykgewo+ICsJCWZvciAodW5zaWduZWQgaW50IGZyYW1lID0g MDsgZnJhbWUgPCBmcmFtZXM7IGZyYW1lKyspIHsKPiAgIAkJCWdlbV9leGVjYnVmKGdlbV9mZCwg JmViKTsKPiAtCQkJZ2VtX3N5bmMoZ2VtX2ZkLCBiYl9oYW5kbGUpOwo+ICsJCQlnZW1fc3luYyhn ZW1fZmQsIG9iai5oYW5kbGUpOwo+ICAgCQl9Cj4gICAKPiAgIAkJaWd0X3N0b3BfaGVscGVyKCZ3 YWl0ZXIpOwo+IEBAIC02MDYsOSArNjA5LDcgQEAgZXZlbnRfd2FpdChpbnQgZ2VtX2ZkLCBjb25z dCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUpCj4gICAJCWlndF9hc3NlcnQodmFs WzFdIC0gdmFsWzBdID4gMCk7Cj4gICAJfQo+ICAgCj4gLQlnZW1fY2xvc2UoZ2VtX2ZkLCBiYl9o YW5kbGUpOwo+IC0KPiAtCWludGVsX3JlZ2lzdGVyX2FjY2Vzc19maW5pKCk7Cj4gKwlnZW1fY2xv c2UoZ2VtX2ZkLCBvYmouaGFuZGxlKTsKPiAgIAo+ICAgCWlndF9yZXF1aXJlX2YodmFsaWRfdGVz dHMsCj4gICAJCSAgICAgICJubyB2YWxpZCBjcnRjL2Nvbm5lY3RvciBjb21iaW5hdGlvbnMgZm91 bmRcbiIpOwo+IAoKSXQgbG9va3MgZmluZSBhcGFydCBmcm9tIHRoZSBhc3N1bXB0aW9uIHRoYXQg REVSUk1SIGFsd2F5cyBoYXZlIHRvIApyZW1haW4gYXQgZGVmYXVsdCB+MC4gV29yc3QgSSBjYW4g aW1hZ2luZSBpcyB0aGF0IGluIHRoZSBmdXR1cmUgd2UgaGF2ZSAKdG8gbWFrZSB0aGlzIHRlc3Qg Zm9yY2UgZGlzY29ubmVjdCBhbGwgZGlzcGxheXMsIHNob3VsZCBzb21lIG9mIHRoZSAKcmVzZXJ2 ZWQgYml0cyBiZSB1c2VkIGZvciBzb21ldGhpbmcgd2hpY2ggd2Ugd2lsbCBiZSB0dXJuaW5nIG9u IGJ5IGRlZmF1bHQuCgpCdXQgaW4gdGhhdCB3b3JsZCBzYW1wbGluZyBERVJSTVIgdmFsdWUgYXQg dGVzdCBzdGFydCBpcyBhbHNvIG9ubHkgCm1hcmdpbmFsbHkgYmV0dGVyLgoKQW55d2F5LCB3ZSBj YW4gd29ycnkgYWJvdXQgdGhhdCBpZiBpdCBoYXBwZW5zLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBV cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=