From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: kamil@netbsd.org, brad@comstyle.com, Fam Zheng <fam@euphon.net>
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] tests/vm: call make check directly for netbsd/freebsd
Date: Mon, 21 Jan 2019 23:53:42 +0100 [thread overview]
Message-ID: <b98226b0-a598-e04c-0d75-67ca2cb6a34d@redhat.com> (raw)
In-Reply-To: <20190121171543.32422-2-alex.bennee@linaro.org>
On 1/21/19 6:15 PM, Alex Bennée wrote:
> The "make check" target calls check-qtest which has the appropriate
> system binaries as dependencies so we shouldn't need to do two steps
> of make invocation.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/vm/freebsd | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 19a3729172..a85c866c30 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM):
> cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
> tar -xf /dev/vtbd1;
> ./configure {configure_opts};
> - gmake --output-sync -j{jobs} {verbose};
> gmake --output-sync -j{jobs} check {verbose};
> """
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-01-21 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:15 [Qemu-devel] [RFC PATCH 0/3] vmbuild tweaks for BSD targets Alex Bennée
2019-01-21 17:15 ` [Qemu-devel] [RFC PATCH 1/3] tests/vm: call make check directly for netbsd/freebsd Alex Bennée
2019-01-21 22:53 ` Philippe Mathieu-Daudé [this message]
2019-01-24 15:35 ` Philippe Mathieu-Daudé
2019-01-21 17:15 ` [Qemu-devel] [RFC PATCH 2/3] tests/vm: add --build-target option Alex Bennée
2019-01-21 22:54 ` Philippe Mathieu-Daudé
2019-01-23 20:13 ` Philippe Mathieu-Daudé
2019-01-21 17:15 ` [Qemu-devel] [RFC PATCH 3/3] tests/vm: expose BUILD_TARGET, TARGET_LIST and EXTRA_CONFIGURE_OPTS Alex Bennée
2019-01-21 22:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98226b0-a598-e04c-0d75-67ca2cb6a34d@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=brad@comstyle.com \
--cc=fam@euphon.net \
--cc=kamil@netbsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.