From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alex G." Subject: Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc Date: Thu, 19 Apr 2018 10:46:15 -0500 Message-ID: References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180416215903.7318-3-mr.nuke.me@gmail.com> <20180418175201.GI4795@pd.tnic> <5f26275c-5896-c552-69c4-78e5aaaa6558@gmail.com> <20180419143018.GC3600@pd.tnic> <8f467611-16a1-8fe7-ea12-e2e29023e4e8@gmail.com> <20180419152933.GD3600@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180419152933.GD3600@pd.tnic> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-Id: linux-acpi@vger.kernel.org On 04/19/2018 10:29 AM, Borislav Petkov wrote: > On Thu, Apr 19, 2018 at 09:57:08AM -0500, Alex G. wrote: >> And that was the motivation behind my splitting it in this patch. > > By "split" I don't mean add a function pointer which gets selected and > then called - if the function becomes too long, you simply split the > function body properly. The bulk of the function is the if/else mapping from UUID to error handler. I don't see how that can be easily split up, hence why I originally resorted to the mapping. As you said, we'll keep it simple at first. >> You don't need the entire GHES structure -- wide context. Individual >> handlers should not be able to access the entire ghes. > > But you remove the @ghes argument in patch 1. So what are we even > talking about? You could say, by convention, handlers shouldn't access ghes directly, but that is not obvious when @ghes is in scope. The reason I bring it up is that, if [1/4] ends up being unneeded, then I will drop it from the series. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v2,2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc From: Alexandru Gagniuc Message-Id: Date: Thu, 19 Apr 2018 10:46:15 -0500 To: Borislav Petkov Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-ID: T24gMDQvMTkvMjAxOCAxMDoyOSBBTSwgQm9yaXNsYXYgUGV0a292IHdyb3RlOgo+IE9uIFRodSwg QXByIDE5LCAyMDE4IGF0IDA5OjU3OjA4QU0gLTA1MDAsIEFsZXggRy4gd3JvdGU6Cj4+IEFuZCB0 aGF0IHdhcyB0aGUgbW90aXZhdGlvbiBiZWhpbmQgbXkgc3BsaXR0aW5nIGl0IGluIHRoaXMgcGF0 Y2guCj4gCj4gQnkgInNwbGl0IiBJIGRvbid0IG1lYW4gYWRkIGEgZnVuY3Rpb24gcG9pbnRlciB3 aGljaCBnZXRzIHNlbGVjdGVkIGFuZAo+IHRoZW4gY2FsbGVkIC0gaWYgdGhlIGZ1bmN0aW9uIGJl Y29tZXMgdG9vIGxvbmcsIHlvdSBzaW1wbHkgc3BsaXQgdGhlCj4gZnVuY3Rpb24gYm9keSBwcm9w ZXJseS4KClRoZSBidWxrIG9mIHRoZSBmdW5jdGlvbiBpcyB0aGUgaWYvZWxzZSBtYXBwaW5nIGZy b20gVVVJRCB0byBlcnJvcgpoYW5kbGVyLiBJIGRvbid0IHNlZSBob3cgdGhhdCBjYW4gYmUgZWFz aWx5IHNwbGl0IHVwLCBoZW5jZSB3aHkgSQpvcmlnaW5hbGx5IHJlc29ydGVkIHRvIHRoZSBtYXBw aW5nLiBBcyB5b3Ugc2FpZCwgd2UnbGwga2VlcCBpdCBzaW1wbGUgYXQKZmlyc3QuCgo+PiBZb3Ug ZG9uJ3QgbmVlZCB0aGUgZW50aXJlIEdIRVMgc3RydWN0dXJlIC0tIHdpZGUgY29udGV4dC4gSW5k aXZpZHVhbAo+PiBoYW5kbGVycyBzaG91bGQgbm90IGJlIGFibGUgdG8gYWNjZXNzIHRoZSBlbnRp cmUgZ2hlcy4KPiAKPiBCdXQgeW91IHJlbW92ZSB0aGUgQGdoZXMgYXJndW1lbnQgaW4gcGF0Y2gg MS4gU28gd2hhdCBhcmUgd2UgZXZlbgo+IHRhbGtpbmcgYWJvdXQ/CgpZb3UgY291bGQgc2F5LCBi eSBjb252ZW50aW9uLCBoYW5kbGVycyBzaG91bGRuJ3QgYWNjZXNzIGdoZXMgZGlyZWN0bHksCmJ1 dCB0aGF0IGlzIG5vdCBvYnZpb3VzIHdoZW4gQGdoZXMgaXMgaW4gc2NvcGUuIFRoZSByZWFzb24g SSBicmluZyBpdCB1cAppcyB0aGF0LCBpZiBbMS80XSBlbmRzIHVwIGJlaW5nIHVubmVlZGVkLCB0 aGVuIEkgd2lsbCBkcm9wIGl0IGZyb20gdGhlCnNlcmllcy4KCkFsZXgKLS0tClRvIHVuc3Vic2Ny aWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1lZGFj IiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpN b3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1p bmZvLmh0bWwK