From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8833C54E67 for ; Wed, 27 Mar 2024 13:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03B746B007B; Wed, 27 Mar 2024 09:02:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F06656B0082; Wed, 27 Mar 2024 09:02:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCC4A6B0083; Wed, 27 Mar 2024 09:02:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C1F176B007B for ; Wed, 27 Mar 2024 09:02:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5EC10A0C04 for ; Wed, 27 Mar 2024 13:02:31 +0000 (UTC) X-FDA: 81942832902.16.8AE8750 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id A01471C002A for ; Wed, 27 Mar 2024 13:02:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711544548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a7rOcwLUrKs/cgJuonapv88QZPSJgNv6h3rdGB/i/84=; b=I8pjMy4XBeCEYNh25Es0SRmt8tA0dn5MioPgPmnPK+2G13I1+UDGPcweqAL8UoVC5EwH8E 0fmg2MIBMLt43Vi8aiI1QpEXfIdcjh20z3jWx9/1R/+9/M+EsOqgv771pUkBSi+6caYpTd oh9YtYItf8mtmjGfoAKO+JuJRd4WSag= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711544548; a=rsa-sha256; cv=none; b=qG6cPTgyPb/jittH5D7iY9Nu/+1pkNOnfT8qZvaqdbIuLDdx2De2QXDeVrti5imrdMUDq7 HOtjc0hEBHIvlaKrb3GTcz/5ilQ2RfvQX69IrmiWzN/lbLV2MRvaNkS0bpHj+8OTUZEFd0 fcAnahamngE48tvzk+HWhNMf8saOo+M= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C71372F4; Wed, 27 Mar 2024 06:03:00 -0700 (PDT) Received: from [10.57.72.121] (unknown [10.57.72.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 337B23F7C5; Wed, 27 Mar 2024 06:02:26 -0700 (PDT) Message-ID: Date: Wed, 27 Mar 2024 13:02:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] mm: Convert arch_clear_hugepage_flags to take a folio Content-Language: en-GB To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240326171045.410737-1-willy@infradead.org> <20240326171045.410737-8-willy@infradead.org> From: Ryan Roberts In-Reply-To: <20240326171045.410737-8-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A01471C002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gz1pj7r77gnh9rgoy8yo1fx957g1q9hq X-HE-Tag: 1711544547-429638 X-HE-Meta: U2FsdGVkX1/okltWQ2WfpOaGFHOA2aWFvxFLVJnuvyPP1WOw/vGLIctbVxXIT38AErLJchHcSu6RZOW2HRpqupYamV4fUFahP3+e2YmgmB1zAI6KuIIfyb9m75qmUE3Ts9pu/QvcJY8XX44xyQeWEopy4X0DdLeNXFd00a1+iOA/tlDCRP20bV/aTDgFwuuJtrdRA7NF5y0L41Yt3lLUFY/bogDHk56QJCrsAj0bkekrotXjOfUFxEc5XwwWsMvs+NWyT4GVJ0ZjRBchZsdJrLHh20nO1wvgNKbVYhRPlaLB+NXft33z+CtVSR0tUsHPJoz/TSG49vgqmA2eUbJz+kVKLQV3V/BsmWbiCAG4QV9JUNbFJFduPHWQGsOYmUtP3rFSWQvIsWBpuEN36sG/4prtcJC21neZVbD0hLcv7EGBrIFp60SWBIiq6DvYUgBhSQB7E14Bw1Hoa4ks+ep1JuZSA0jI1bMkKyEJTG3xATYjUAhRvAjl2YUjcSDEwj8fdSq9XlGDIJxmERaIuQVSxZBte5sUA7t3OWdrDH7ZlGVEqxz0s9Vujy8amALT3kvxCK91a8Me7TNHgz/Xlh7vxuDAjnydEHqWT6u6Th+18g9XZCtno0ZSe/QpQYR2vFpE2WMUaeVHdCpL4AjQoZjwQOptU5T2XzplE9T0j6l480zwQkcxW/obeWP++Q0cwng+k81WJ/N6NRPUilw8Gr2Nl5cLeabcN8c4kGzpjcd/VGGNdIYt3RzomYRi3WPjR1wh1wSNnMXjwxoMPRn7LeJtfCLt/1xFspR2htLQVKN+Zk5sUEgKR0mXQmpknCe+gv+QOgFmaCBWSIPspTp/L2Qf+0fm3Z64lsjuxq7xUNK07vf4qT5+QUR8yWJ5T91uwe/LLSJsce3+S6vPi0EqZyxh7s8Nscdyz0WN+X6syy29mtF1BOauO8VsJbyFenFaRtSJNDruHNGMub4VxudwEst a+tgN7sl J37R/bdslzQoAiqi+2WaYzBrPR6ihUZifmpv4gonlD+ucmt8bRz0vY+W/+ZO+dJqcZkLWhr3/xKuFScvcrNTTB7pXPDaCf6w0b3jzjIwKtqGr3lRvxTEiQl2dcQHOa3qELG27JUn4LcWUNbJ2DJMSQo5rW71XvdqeEJ3/8Kye63WtZESxYVChieL2lPc9MAaMsgp8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Matthew, On 26/03/2024 17:10, Matthew Wilcox (Oracle) wrote: > All implementations that aren't no-ops just set a bit in the flags, > and we want to use the folio flags rather than the page flags for that. > Rename it to arch_clear_hugetlb_flags() while we're touching it so nobody > thinks it's used for THP. > [...] > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index d748628efc5e..cc420c42a773 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -837,8 +837,8 @@ static inline int is_hugepage_only_range(struct mm_struct *mm, > #endif > > #ifndef arch_clear_hugepage_flags You need to update this line to the new name. Currently failing to build on arm64 since it now defines the new arch_clear_hugetlb_flags. > -static inline void arch_clear_hugepage_flags(struct page *page) { } > -#define arch_clear_hugepage_flags arch_clear_hugepage_flags > +static inline void arch_clear_hugetlb_flags(struct folio *folio) { } > +#define arch_clear_hugetlb_flags arch_clear_hugetlb_flags > #endif Thanks, Ryan