From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09493C433FE for ; Wed, 15 Dec 2021 17:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245119AbhLOREw (ORCPT ); Wed, 15 Dec 2021 12:04:52 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:57046 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243845AbhLOREv (ORCPT ); Wed, 15 Dec 2021 12:04:51 -0500 Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D7684409F7 for ; Wed, 15 Dec 2021 17:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639587889; bh=lND4OoA35DC/nm8kOM3LCMts4j9XNowECufJcxr7lKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gz9O440pHBWszIBRUkGfj+q+X3IgZRQxJSsUBwaiuintYNVAA4EvbgltXaA61Ojh0 PbJg3bZXfQYQ0ZoB68sDiReHunMGrX6bGt3yVHZwlVkyD3xI2s1cnAp4tryNOSmYH2 9HFH9tWA7UZLALF8zMyWksybb1UCczO4q2DOHggFHF6Luceb/JdIugsWoJUdP4LKF6 D16sCQB/kSTCZAI8HuCmZTOxqSoKkM34Pb6i8jZ5Wodilli6Xea2lS/yGxSQq5fznS 9ajmgE8MH+/MR3U5SyE8hZOL99F+b+LEbHTGvRg9iHG5A8dZkZa45a8H5mRHyV9p/5 0dUU3MK3DIYkA== Received: by mail-lj1-f200.google.com with SMTP id r20-20020a2eb894000000b0021a4e932846so7301170ljp.6 for ; Wed, 15 Dec 2021 09:04:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lND4OoA35DC/nm8kOM3LCMts4j9XNowECufJcxr7lKM=; b=GjjAzulHQlB1V/2s9xvPgmyrGxi8vjKDR+jil/sZcSW1CRoKXFDYLHOgx1JucSUqeq T4CPOq4hGEV9iypHGCMCfbjagRt/aRih/Y/TwP4YPXJOhoBVf5dMghUN3r2lYSckel1V 2Ssy2ZWzqHbyamyr2Y/KV3UjlbUuJOk9RJPXM21P6Pg5rYHPs3vWoof3GYZ4GbCLN+tX BZgP0qMZTE8h+Iev2hB6tKMSpev93YssjM9eORYOi6k1cdsZ7RnsP83ixV19dRebYXKj quWRFw79e8yQiwRqEnqmIA6NEhIee9heOn1/cC+66ncci8J/BMZ8zwIqlgx/cMPY6jdT mZrw== X-Gm-Message-State: AOAM533ismYtK/7i7XSOxIdT/SOSA+XtIzoXV8iR5ktENfV0TpPy3Xud aKKzl4AMm7ENCj3xsJ3F0K1GY9qjvEycRkQi1a96rz41iJB0Io5jnTwDfXBlGp2+7MSFlXCtmYH 2CX4kodhnBnuHAozH++0q47mWZZchG0P48Ot1RfYyYw== X-Received: by 2002:ac2:4c0b:: with SMTP id t11mr10861623lfq.520.1639587888841; Wed, 15 Dec 2021 09:04:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDC7Uhq9X079aLTRRyBWwLifon/fdJaMDRQkGk4uaeEYd+dFFSVGtgZL0YygKIzNYGxnNIDg== X-Received: by 2002:ac2:4c0b:: with SMTP id t11mr10861579lfq.520.1639587888551; Wed, 15 Dec 2021 09:04:48 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id u23sm407224lfo.35.2021.12.15.09.04.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 09:04:48 -0800 (PST) Message-ID: Date: Wed, 15 Dec 2021 18:04:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 7/7] arm64: dts: exynos: Add initial E850-96 board support Content-Language: en-US To: Sam Protsenko , Rob Herring , Sylwester Nawrocki Cc: Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20211215160906.17451-1-semen.protsenko@linaro.org> <20211215160906.17451-8-semen.protsenko@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20211215160906.17451-8-semen.protsenko@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/12/2021 17:09, Sam Protsenko wrote: > E850-96 is a 96boards development board manufactured by WinLink. It > incorporates Samsung Exynos850 SoC, and is compatible with 96boards > mezzanine boards [1], as it follows 96boards standards. > > This patch adds minimal support for E850-96 board. Next features are > enabled in board dts file and verified with minimal BusyBox rootfs: > > * User buttons > * LEDs > * Serial console > * Watchdog timers > * RTC > * eMMC > > [1] https://www.96boards.org/products/mezzanine/ > > Signed-off-by: Sam Protsenko > --- > arch/arm64/boot/dts/exynos/Makefile | 3 +- > .../boot/dts/exynos/exynos850-e850-96.dts | 157 ++++++++++++++++++ > 2 files changed, 159 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile > index b41e86df0a84..803548ccc537 100644 > --- a/arch/arm64/boot/dts/exynos/Makefile > +++ b/arch/arm64/boot/dts/exynos/Makefile > @@ -3,4 +3,5 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ > exynos5433-tm2.dtb \ > exynos5433-tm2e.dtb \ > exynos7-espresso.dtb \ > - exynosautov9-sadk.dtb > + exynosautov9-sadk.dtb \ > + exynos850-e850-96.dtb > diff --git a/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > new file mode 100644 > index 000000000000..fd611906d81c > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > @@ -0,0 +1,157 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * WinLink E850-96 board device tree source > + * > + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Device tree source file for WinLink's E850-96 board which is based on > + * Samsung Exynos850 SoC. > + */ > + > +/dts-v1/; > + > +#include "exynos850.dtsi" > +#include > +#include > + > +#define BOARD_ID 0x0 > +#define BOARD_REV 0x2 > + > +/ { > + model = "WinLink E850-96 board"; > + compatible = "winlink,e850-96", "samsung,exynos850"; > + board_id = ; > + board_rev = ; > + > + chosen { > + stdout-path = &serial_0; > + }; > + You did not define memory node. Do you expect bootloader to fill it? Does it change between different boards? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA844C433F5 for ; Wed, 15 Dec 2021 17:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dKIXM/4eICZD/G/4wZ98h7cfmww1DslBuK6zsob+dIc=; b=AcAhI6yCjwhflY aDwqAFUYwMIBO0HXZ1hRagQ7DHmT9t9LghACDoLh28zHsGFB7StnX+wO8gRP9LmY1PU7CUTefyWH0 wxQn7yCkH7FvzZktrvKR3fmrXxsOpwITJYZkYvmxXz1GBvWO012rm6Kwh2eC9YXQqgExqJSiWhlYY tBh0l9/2HWONJPy+By7Gcde9hwNVJuF1qeNb1jcVZOMhwV3u1PpJduemMMLP4keOWvoS6V4rd6CRd gI8Am6yDcZzrz1PZfh9FZayxEhfC1mgGZn9AEsn719QounNkuPBhM29kurLbYnNKH31KhMAzy6ymg xIqjDey9slyYgwgtrS8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxXmO-001yZE-Vs; Wed, 15 Dec 2021 17:09:26 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxXhz-001wpK-25 for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 17:04:52 +0000 Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 834D53F1B3 for ; Wed, 15 Dec 2021 17:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639587889; bh=lND4OoA35DC/nm8kOM3LCMts4j9XNowECufJcxr7lKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gz9O440pHBWszIBRUkGfj+q+X3IgZRQxJSsUBwaiuintYNVAA4EvbgltXaA61Ojh0 PbJg3bZXfQYQ0ZoB68sDiReHunMGrX6bGt3yVHZwlVkyD3xI2s1cnAp4tryNOSmYH2 9HFH9tWA7UZLALF8zMyWksybb1UCczO4q2DOHggFHF6Luceb/JdIugsWoJUdP4LKF6 D16sCQB/kSTCZAI8HuCmZTOxqSoKkM34Pb6i8jZ5Wodilli6Xea2lS/yGxSQq5fznS 9ajmgE8MH+/MR3U5SyE8hZOL99F+b+LEbHTGvRg9iHG5A8dZkZa45a8H5mRHyV9p/5 0dUU3MK3DIYkA== Received: by mail-lj1-f200.google.com with SMTP id n6-20020a2e82c6000000b00221698ffa68so7259880ljh.17 for ; Wed, 15 Dec 2021 09:04:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lND4OoA35DC/nm8kOM3LCMts4j9XNowECufJcxr7lKM=; b=wqyYMEF5ubFNvEDynRz7zR+QkOkI378zWsDx5iXMXMJ0PjnPuDXa5jDDbRNe8BK4xF We7ofzAlSFJyoOHCq2X7gi+pNWYcFeil/ffgpLSfbxOjVfxlhJ0caiGQEmLfcIoIahDd ixIsxWgx3EMePLntJAHBDAGTcAi9N66l3B59Os+u5lFi6UCJuIZM0F7q6v35ygW+rAvj 713pmHhkPiF17QnkS6ZuBgT5fZJm3NFp4ztO8GbjfekaYMJqHh/iY6wFjagETEFL84a5 TWqz+iEtzuO6sx7QDdMBQCny2E+BmKAzdBKiTqqyB749Tjvh7i0d5oX+B96bSU8h5iZi MxBw== X-Gm-Message-State: AOAM5335DMGBjoqHJisAh37bZxFV6Js/nGZWFq29RqtkBTwuJwIN7RlM ox2uOG2tEHM4UYNj0lMFj7tOYmD9+zjLL3lGzAf8A7PGN0WeVHE/NPWDaG4YKKNpUS3Ppgshi72 j4FMequFkd0Zp01RUcX93rdhNIVWhvqpocjDxjh+IMcBHmdjyMT/r X-Received: by 2002:ac2:4c0b:: with SMTP id t11mr10861599lfq.520.1639587888758; Wed, 15 Dec 2021 09:04:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDC7Uhq9X079aLTRRyBWwLifon/fdJaMDRQkGk4uaeEYd+dFFSVGtgZL0YygKIzNYGxnNIDg== X-Received: by 2002:ac2:4c0b:: with SMTP id t11mr10861579lfq.520.1639587888551; Wed, 15 Dec 2021 09:04:48 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id u23sm407224lfo.35.2021.12.15.09.04.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 09:04:48 -0800 (PST) Message-ID: Date: Wed, 15 Dec 2021 18:04:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 7/7] arm64: dts: exynos: Add initial E850-96 board support Content-Language: en-US To: Sam Protsenko , Rob Herring , Sylwester Nawrocki Cc: Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20211215160906.17451-1-semen.protsenko@linaro.org> <20211215160906.17451-8-semen.protsenko@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20211215160906.17451-8-semen.protsenko@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_090451_298375_D87374AA X-CRM114-Status: GOOD ( 24.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/12/2021 17:09, Sam Protsenko wrote: > E850-96 is a 96boards development board manufactured by WinLink. It > incorporates Samsung Exynos850 SoC, and is compatible with 96boards > mezzanine boards [1], as it follows 96boards standards. > > This patch adds minimal support for E850-96 board. Next features are > enabled in board dts file and verified with minimal BusyBox rootfs: > > * User buttons > * LEDs > * Serial console > * Watchdog timers > * RTC > * eMMC > > [1] https://www.96boards.org/products/mezzanine/ > > Signed-off-by: Sam Protsenko > --- > arch/arm64/boot/dts/exynos/Makefile | 3 +- > .../boot/dts/exynos/exynos850-e850-96.dts | 157 ++++++++++++++++++ > 2 files changed, 159 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile > index b41e86df0a84..803548ccc537 100644 > --- a/arch/arm64/boot/dts/exynos/Makefile > +++ b/arch/arm64/boot/dts/exynos/Makefile > @@ -3,4 +3,5 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ > exynos5433-tm2.dtb \ > exynos5433-tm2e.dtb \ > exynos7-espresso.dtb \ > - exynosautov9-sadk.dtb > + exynosautov9-sadk.dtb \ > + exynos850-e850-96.dtb > diff --git a/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > new file mode 100644 > index 000000000000..fd611906d81c > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > @@ -0,0 +1,157 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * WinLink E850-96 board device tree source > + * > + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Device tree source file for WinLink's E850-96 board which is based on > + * Samsung Exynos850 SoC. > + */ > + > +/dts-v1/; > + > +#include "exynos850.dtsi" > +#include > +#include > + > +#define BOARD_ID 0x0 > +#define BOARD_REV 0x2 > + > +/ { > + model = "WinLink E850-96 board"; > + compatible = "winlink,e850-96", "samsung,exynos850"; > + board_id = ; > + board_rev = ; > + > + chosen { > + stdout-path = &serial_0; > + }; > + You did not define memory node. Do you expect bootloader to fill it? Does it change between different boards? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel