From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03B9E89269 for ; Mon, 3 Jun 2019 12:42:38 +0000 (UTC) References: <20190531112200.22403-1-simon.ser@intel.com> <20190531112200.22403-3-simon.ser@intel.com> From: Martin Peres Message-ID: Date: Mon, 3 Jun 2019 15:42:34 +0300 MIME-Version: 1.0 In-Reply-To: <20190531112200.22403-3-simon.ser@intel.com> Content-Language: en-PH Subject: Re: [igt-dev] [PATCH i-g-t 2/5] lib/igt_eld: consolidate ELD parsing List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Simon Ser , igt-dev@lists.freedesktop.org Cc: martin.peres@intel.com List-ID: T24gMzEvMDUvMjAxOSAxNDoyMSwgU2ltb24gU2VyIHdyb3RlOgo+IE1ha2UgdGhlIEVMRCBlbnVt ZXJhdGlvbiBtb3JlIHJvYnVzdCwgYW5kIGltcGxlbWVudCBwcm9wZXIgcGFyc2luZyBmb3IgRUxE Cj4gZmllbGRzLiBUaGlzIHdpbGwgYmVjb21lIHVzZWZ1bCB3aGVuIG90aGVyIEVMRCBmaWVsZHMg KGZvcm1hdHMsIHNhbXBsZSByYXRlcywKPiBzYW1wbGUgc2l6ZXMpIHdpbGwgYmUgcGFyc2VkIGFu ZCBjaGVja2VkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFNpbW9uIFNlciA8c2ltb24uc2VyQGludGVs LmNvbT4KPiAtLS0KPiAgbGliL2lndF9lbGQuYyB8IDk0ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBsaWIvaWd0X2VsZC5oIHwgIDUgKysrCj4g IDIgZmlsZXMgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwgMzYgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZWxkLmMgYi9saWIvaWd0X2VsZC5jCj4gaW5kZXggOGUwZGNj MzA2ZTg1Li5hMTk4MDAxYTU2ZDcgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9lbGQuYwo+ICsrKyBi L2xpYi9pZ3RfZWxkLmMKPiBAQCAtMzAsOCArMzAsMTIgQEAKPiAgI2luY2x1ZGUgPHN0ZGlvLmg+ Cj4gICNpbmNsdWRlIDxzdHJpbmcuaD4KPiAgCj4gKyNpbmNsdWRlICJpZ3RfY29yZS5oIgo+ICAj aW5jbHVkZSAiaWd0X2VsZC5oIgo+ICAKPiArI2RlZmluZSBFTERfUFJFRklYICJlbGQjIgo+ICsj ZGVmaW5lIEVMRF9ERUxJTSAiIFx0Igo+ICsKPiAgLyoqCj4gICAqIEVESUQtTGlrZSBEYXRhIChF TEQpIGlzIG1ldGFkYXRhIHBhcnNlZCBhbmQgZXhwb3NlZCBieSBBTFNBIGZvciBIRE1JIGFuZAo+ ICAgKiBEaXNwbGF5UG9ydCBjb25uZWN0b3JzIHN1cHBvcnRpbmcgYXVkaW8uIFRoaXMgaW5jbHVk ZXMgdGhlIG1vbml0b3IgbmFtZSBhbmQKPiBAQCAtMzksMzkgKzQzLDQ5IEBACj4gICAqIG9uKS4K PiAgICovCj4gIAo+IC0vKiogZWxkX2VudHJ5X2lzX2lndDogY2hlY2tzIHdoZXRoZXIgYW4gRUxE IGVudHJ5IGlzIG1hcHBlZCB0byB0aGUgSUdUIEVESUQgKi8KClBvc3RpbmcgYW4gZXhhbXBsZSBv ZiBlbGQgaGVyZSB3b3VsZCBiZSBoZWxwZnVsOgoKJCBjYXQgL3Byb2MvYXNvdW5kL2NhcmQwL2Vs ZCMwLjIKbW9uaXRvcl9wcmVzZW50ICAgICAgICAgMQplbGRfdmFsaWQgICAgICAgICAgICAgICAx Cm1vbml0b3JfbmFtZSAgICAgICAgICAgIFUyODc5RzYKCmNvbm5lY3Rpb25fdHlwZSAgICAgICAg IERpc3BsYXlQb3J0CmVsZF92ZXJzaW9uICAgICAgICAgICAgIFsweDJdIENFQS04NjFEIG9yIGJl bG93CmVkaWRfdmVyc2lvbiAgICAgICAgICAgIFsweDNdIENFQS04NjEtQiwgQyBvciBECm1hbnVm YWN0dXJlX2lkICAgICAgICAgIDB4ZTMwNQpwcm9kdWN0X2lkICAgICAgICAgICAgICAweDI4NzkK cG9ydF9pZCAgICAgICAgICAgICAgICAgMHg4MDAKc3VwcG9ydF9oZGNwICAgICAgICAgICAgMApz dXBwb3J0X2FpICAgICAgICAgICAgICAwCmF1ZGlvX3N5bmNfZGVsYXkgICAgICAgIDAKc3BlYWtl cnMgICAgICAgICAgICAgICAgWzB4MV0gRkwvRlIKc2FkX2NvdW50ICAgICAgICAgICAgICAgMQpz YWQwX2NvZGluZ190eXBlICAgICAgICBbMHgxXSBMUENNCnNhZDBfY2hhbm5lbHMgICAgICAgICAg IDIKc2FkMF9yYXRlcyAgICAgICAgICAgICAgWzB4ZTBdIDMyMDAwIDQ0MTAwIDQ4MDAwCnNhZDBf Yml0cyAgICAgICAgICAgICAgIFsweGUwMDAwXSAxNiAyMCAyNAoKPiAtc3RhdGljIGJvb2wgZWxk X2VudHJ5X2lzX2lndChjb25zdCBjaGFyICpwYXRoKQo+ICtzdGF0aWMgYm9vbCBlbGRfcGFyc2Vf ZW50cnkoY29uc3QgY2hhciAqcGF0aCwgc3RydWN0IGVsZF9lbnRyeSAqZWxkKQo+ICB7Cj4gLQlG SUxFICppbjsKPiArCUZJTEUgKmY7Cj4gIAljaGFyIGJ1ZlsxMDI0XTsKPiAtCXVpbnQ4X3QgZWxk X3ZhbGlkID0gMDsKPiAtCXVpbnQ4X3QgbW9uX3ZhbGlkID0gMDsKPiAtCj4gLQlpbiA9IGZvcGVu KHBhdGgsICJyIik7Cj4gLQlpZiAoIWluKQo+IC0JCXJldHVybiBmYWxzZTsKPiArCWNoYXIgKmtl eSwgKnZhbHVlOwo+ICsJc2l6ZV90IGxlbjsKPiArCWJvb2wgbW9uaXRvcl9wcmVzZW50Owo+ICAK PiAtCW1lbXNldChidWYsIDAsIDEwMjQpOwo+ICsJbWVtc2V0KGVsZCwgMCwgc2l6ZW9mKCplbGQp KTsKPiAgCj4gLQl3aGlsZSAoKGZnZXRzKGJ1ZiwgMTAyNCwgaW4pKSAhPSBOVUxMKSB7Cj4gLQkJ Y2hhciAqbGluZSA9IGJ1ZjsKPiArCWYgPSBmb3BlbihwYXRoLCAiciIpOwo+ICsJaWYgKCFmKSB7 Cj4gKwkJaWd0X2RlYnVnKCJGYWlsZWQgdG8gb3BlbiBFTEQgZmlsZTogJXNcbiIsIHBhdGgpOwo+ ICsJCXJldHVybiBmYWxzZTsKPiArCX0KPiAgCj4gLQkJaWYgKCFzdHJuY2FzZWNtcChsaW5lLCAi ZWxkX3ZhbGlkIiwgOSkgJiYKPiAtCQkJCXN0cnN0cihsaW5lLCAiMSIpKSB7Cj4gLQkJCWVsZF92 YWxpZCsrOwo+IC0JCX0KCkdvb2QgcmlkZGFuY2UhIElnbm9yZSBteSBjb21tZW50IGZyb20gcGF0 Y2ggMSEKCj4gKwl3aGlsZSAoKGZnZXRzKGJ1Ziwgc2l6ZW9mKGJ1ZiksIGYpKSAhPSBOVUxMKSB7 Cj4gKwkJbGVuID0gc3RybGVuKGJ1Zik7Cj4gKwkJaWYgKGJ1ZltsZW4gLSAxXSA9PSAnXG4nKQo+ ICsJCQlidWZbbGVuIC0gMV0gPSAnXDAnOwo+ICsKPiArCQlrZXkgPSBzdHJ0b2soYnVmLCBFTERf REVMSU0pOwo+ICsJCXZhbHVlID0gc3RydG9rKE5VTEwsICIiKTsKCkhtbSwgSSBoYWQgZm9yZ290 dGVuIHRoYXQgc3Ryb2sgd2FzIHN0YXRlZnVsIHdoZW4gc3RyID09IE5VTEwhCgo+ICsJCS8qIFNr aXAgd2hpdGVzcGFjZSBhdCB0aGUgYmVnaW5uaW5nICovCj4gKwkJdmFsdWUgKz0gc3Ryc3BuKHZh bHVlLCBFTERfREVMSU0pOwoKVGhhbmtzIGZvciB0ZWFjaGluZyBtZSBhIG5ldyBmdW5jdGlvbiA6 KSBUaGlzIGlzIHF1aXRlIHByYWN0aWNhbCEKCkFmdGVyIGRvaW5nIG1vcmUgcHl0aG9uIHdvcmss IGdvaW5nIGJhY2sgdG8gcGFyc2luZyB3aXRoIEMgaXMgYSBsaXR0bGUKcm91Z2ggOkQgTm90IGFz IGJhZCBhcyBBU00gdGhvdWdoIQoKPiArCj4gKwkJaWYgKHN0cmNtcChrZXksICJtb25pdG9yX3By ZXNlbnQiKSA9PSAwKQo+ICsJCQltb25pdG9yX3ByZXNlbnQgPSBzdHJjbXAodmFsdWUsICIxIikg PT0gMDsKPiArCQllbHNlIGlmIChzdHJjbXAoa2V5LCAiZWxkX3ZhbGlkIikgPT0gMCkKPiArCQkJ ZWxkLT52YWxpZCA9IHN0cmNtcCh2YWx1ZSwgIjEiKSA9PSAwOwo+ICsJCWVsc2UgaWYgKHN0cmNt cChrZXksICJtb25pdG9yX25hbWUiKSA9PSAwKQo+ICsJCQlzbnByaW50ZihlbGQtPm1vbml0b3Jf bmFtZSwgc2l6ZW9mKGVsZC0+bW9uaXRvcl9uYW1lKSwKPiArCQkJCSAiJXMiLCB2YWx1ZSk7Cj4g Kwl9Cj4gIAo+IC0JCWlmICghc3RybmNhc2VjbXAobGluZSwgIm1vbml0b3JfbmFtZSIsIDEyKSAm Jgo+IC0JCQkJc3Ryc3RyKGxpbmUsICJJR1QiKSkgewo+IC0JCQltb25fdmFsaWQrKzsKPiAtCQl9 Cj4gKwlpZiAoZmVycm9yKGYpICE9IDApIHsKPiArCQlpZ3RfZGVidWcoIkZhaWxlZCB0byByZWFk IEVMRCBmaWxlOiAlZFxuIiwgZmVycm9yKGYpKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gIAl9Cj4g IAo+IC0JZmNsb3NlKGluKTsKPiAtCWlmIChtb25fdmFsaWQgJiYgZWxkX3ZhbGlkKQo+IC0JCXJl dHVybiB0cnVlOwo+ICsJZmNsb3NlKGYpOwo+ICAKPiAtCXJldHVybiBmYWxzZTsKPiArCXJldHVy biBtb25pdG9yX3ByZXNlbnQ7Cj4gIH0KPiAgCj4gIC8qKiBlbGRfaGFzX2lndDogY2hlY2sgd2hl dGhlciBBTFNBIGhhcyBkZXRlY3RlZCB0aGUgYXVkaW8tY2FwYWJsZSBJR1QgRURJRCBieQo+IEBA IC03OSwyNyArOTMsMzUgQEAgc3RhdGljIGJvb2wgZWxkX2VudHJ5X2lzX2lndChjb25zdCBjaGFy ICpwYXRoKQo+ICBib29sIGVsZF9oYXNfaWd0KHZvaWQpCj4gIHsKPiAgCURJUiAqZGlyOwo+IC0J c3RydWN0IGRpcmVudCAqc25kX2hkYTsKPiArCXN0cnVjdCBkaXJlbnQgKmRpcmVudDsKPiAgCWlu dCBpOwo+ICsJY2hhciBjYXJkWzY0XTsKPiArCWNoYXIgcGF0aFtQQVRIX01BWF07Cj4gKwlzdHJ1 Y3QgZWxkX2VudHJ5IGVsZDsKPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgODsgaSsrKSB7Cj4gLQkJ Y2hhciBjYXJkc1sxMjhdOwo+IC0KPiAtCQlzbnByaW50ZihjYXJkcywgc2l6ZW9mKGNhcmRzKSwg Ii9wcm9jL2Fzb3VuZC9jYXJkJWQiLCBpKTsKPiAtCQlkaXIgPSBvcGVuZGlyKGNhcmRzKTsKPiAr CQlzbnByaW50ZihjYXJkLCBzaXplb2YoY2FyZCksICIvcHJvYy9hc291bmQvY2FyZCVkIiwgaSk7 Cj4gKwkJZGlyID0gb3BlbmRpcihjYXJkKTsKPiAgCQlpZiAoIWRpcikKPiAgCQkJY29udGludWU7 Cj4gIAo+IC0JCXdoaWxlICgoc25kX2hkYSA9IHJlYWRkaXIoZGlyKSkpIHsKPiAtCQkJY2hhciBm cGF0aFtQQVRIX01BWF07Cj4gKwkJd2hpbGUgKChkaXJlbnQgPSByZWFkZGlyKGRpcikpKSB7Cj4g KwkJCWlmIChzdHJuY21wKGRpcmVudC0+ZF9uYW1lLCBFTERfUFJFRklYLAo+ICsJCQkJICAgIHN0 cmxlbihFTERfUFJFRklYKSkgIT0gMCkKPiArCQkJCWNvbnRpbnVlOwo+ICsKPiArCQkJc25wcmlu dGYocGF0aCwgc2l6ZW9mKHBhdGgpLCAiJXMvJXMiLCBjYXJkLAo+ICsJCQkJIGRpcmVudC0+ZF9u YW1lKTsKPiArCQkJaWYgKCFlbGRfcGFyc2VfZW50cnkocGF0aCwgJmVsZCkpIHsKPiArCQkJCWNv bnRpbnVlOwo+ICsJCQl9Cj4gIAo+IC0JCQlpZiAoKnNuZF9oZGEtPmRfbmFtZSA9PSAnLicgfHwK PiAtCQkJICAgIHN0cnN0cihzbmRfaGRhLT5kX25hbWUsICJlbGQiKSA9PSAwKQo+ICsJCQlpZiAo IWVsZC52YWxpZCkgewo+ICsJCQkJaWd0X2RlYnVnKCJTa2lwcGluZyBpbnZhbGlkIEVMRDogJXNc biIsIHBhdGgpOwoKVGhlIG1lc3NhZ2UgaXMgYSBsaXR0bGUgY29uZnVzaW5nLiBIb3cgYWJvdXQg IlNraXBwaW5nIG5vbi1FTEQgZmlsZToKJXNcbiIgaW5zdGVhZD8KCkFueXdheSwgSSBsaWtlIHdo ZXJlIHRoaXMgaXMgZ29pbmchCgpSZXZpZXdlZC1ieTogTWFydGluIFBlcmVzIDxtYXJ0aW4ucGVy ZXNAbGludXguaW50ZWwuY29tPgoKPiAgCQkJCWNvbnRpbnVlOwo+ICsJCQl9Cj4gIAo+IC0JCQlz bnByaW50ZihmcGF0aCwgc2l6ZW9mKGZwYXRoKSwgIiVzLyVzIiwgY2FyZHMsCj4gLQkJCQkgc25k X2hkYS0+ZF9uYW1lKTsKPiAtCQkJaWYgKGVsZF9lbnRyeV9pc19pZ3QoZnBhdGgpKSB7Cj4gKwkJ CWlmIChzdHJjbXAoZWxkLm1vbml0b3JfbmFtZSwgIklHVCIpID09IDApIHsKPiAgCQkJCWNsb3Nl ZGlyKGRpcik7Cj4gIAkJCQlyZXR1cm4gdHJ1ZTsKPiAgCQkJfQo+IGRpZmYgLS1naXQgYS9saWIv aWd0X2VsZC5oIGIvbGliL2lndF9lbGQuaAo+IGluZGV4IDI3Zjg3NmQ5ZjYzMS4uMjFmZTM1Mzdh Y2Y5IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZWxkLmgKPiArKysgYi9saWIvaWd0X2VsZC5oCj4g QEAgLTMwLDYgKzMwLDExIEBACj4gIAo+ICAjaW5jbHVkZSA8c3RkYm9vbC5oPgo+ICAKPiArc3Ry dWN0IGVsZF9lbnRyeSB7Cj4gKwlib29sIHZhbGlkOwo+ICsJY2hhciBtb25pdG9yX25hbWVbMTZd Owo+ICt9Owo+ICsKPiAgYm9vbCBlbGRfaGFzX2lndCh2b2lkKTsKPiAgCj4gICNlbmRpZgo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1h aWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=