From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1F8C433E0 for ; Sun, 27 Dec 2020 14:34:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A820217A0 for ; Sun, 27 Dec 2020 14:34:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A820217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktX7n-0001li-UA for qemu-devel@archiver.kernel.org; Sun, 27 Dec 2020 09:34:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktX71-0001DG-7K for qemu-devel@nongnu.org; Sun, 27 Dec 2020 09:33:35 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:38523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktX6z-0001Rd-Lp for qemu-devel@nongnu.org; Sun, 27 Dec 2020 09:33:34 -0500 Received: by mail-wm1-x32a.google.com with SMTP id g185so7052471wmf.3 for ; Sun, 27 Dec 2020 06:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9Sd1Dr3AHOUtCy9WhTS5faYG+mua+vHWf2SWyGVcrx8=; b=OqdlYwWQ2EQvsu7qpAxt6bD3btYV28Gqt3sS34ybhIhJPiw8Rl+z0WVW0ZsH/vKxtH 6T0/BwVU/2ak/g3yPut8Pws6Lau21baUaipRcZKibAXLICGikL2q97WrABFeYCNLHYoZ N4x+9KaRdBswm2Qb4HcDSJjt2qSnd9wESKMAecHVVv+OcyZTKs2NDFax2Q+qaf2xQz1s /mX/gc0u6qNR1sKhRZSJGKicnSmiP6heaFVHiwcNW7WCYPJN56uVYyCKkYYXD6idCj3j MQcROHrKsmunqZUoJH6mxsAgVUOzte76f4bJPGMThszE2aNi9UHGr/DMxmWhawORNCF1 7qIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9Sd1Dr3AHOUtCy9WhTS5faYG+mua+vHWf2SWyGVcrx8=; b=eYOOEQ61WMD33foJyqtshrwTcWcSrJvsGrCVdTIY9iZY60C3zgj63rUeyTg4DWrpYB RcNSwBoogiljrAO9WY+qPoppNLWRUfFDcy28BgMksujrF0wrnEHIEamoJ3wdQt65nEyp nSCy79on/hEHgDkYgABCvYgrpQl94vqiTUedlzXtv+FC53MwpyUdVfEFR9cCx71llaDW vn9mFtbYvFUkqDgwSb9JBGkHF3NNFI/58CF0MQepkC/A8U+Ixze5c9SiedamBWhUHXV0 ZLoOEiO/WwI4OeazXXaWDbsh1QYWaEVN3aYjnOvbAOrMr7n3nRsPwY+0Udoaa4MEZHYD jNjw== X-Gm-Message-State: AOAM532K7kNWhiT+ToodGcw6jhEtz6O9zXfGO1YfWWL9MRyHx+wrOAle t3d4MDRtD4iZSbuzR3BewBc= X-Google-Smtp-Source: ABdhPJzEYqzbCe2HCiMoGv9g/TpP11CjiUG2sXjbAiw3CQtumMbwu+q+lWIoXLqFo5+ScAXQJOuHkA== X-Received: by 2002:a1c:b657:: with SMTP id g84mr16673098wmf.181.1609079612070; Sun, 27 Dec 2020 06:33:32 -0800 (PST) Received: from ?IPv6:2a01:e35:2fb0:49e0:98dc:fe2:8fe8:bc3b? ([2a01:e35:2fb0:49e0:98dc:fe2:8fe8:bc3b]) by smtp.gmail.com with ESMTPSA id z6sm53240245wrw.58.2020.12.27.06.33.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 06:33:31 -0800 (PST) Subject: Re: [PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type macros To: BALATON Zoltan , qemu-devel@nongnu.org References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Sun, 27 Dec 2020 15:33:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.829, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Huacai Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/27/20 2:10 AM, BALATON Zoltan via wrote: > There's no reason to suffix everything with _DEVICE when the names are > already unique without it and shorter names are more readable. > > Signed-off-by: BALATON Zoltan > --- > hw/isa/vt82c686.c | 48 +++++++++++++++++++++++------------------------ > 1 file changed, 23 insertions(+), 25 deletions(-) > > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c > index 2a0f85dea9..1be1169f83 100644 > --- a/hw/isa/vt82c686.c > +++ b/hw/isa/vt82c686.c > @@ -49,8 +49,8 @@ struct VT82C686BState { > SuperIOConfig superio_conf; > }; > > -#define TYPE_VT82C686B_DEVICE "VT82C686B" > -OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BState, VT82C686B_DEVICE) > +#define TYPE_VT82C686B "VT82C686B" > +OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BState, VT82C686B) Can we name this one VT82C686B_ISA?