From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 9/9] nvme: add support for streams and directives From: Jens Axboe To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, adilger@dilger.ca, martin.petersen@oracle.com, linux-nvme@lists.infradead.org References: <1498004526-4543-1-git-send-email-axboe@kernel.dk> <1498004526-4543-10-git-send-email-axboe@kernel.dk> <20170626095907.GG14057@infradead.org> <20170627141115.GA2541@infradead.org> <20170627144405.GA4605@infradead.org> Message-ID: Date: Tue, 27 Jun 2017 08:56:34 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 06/27/2017 08:46 AM, Jens Axboe wrote: > On 06/27/2017 08:44 AM, Christoph Hellwig wrote: >> On Tue, Jun 27, 2017 at 08:16:49AM -0600, Jens Axboe wrote: >>> But we have to handle it, not doing so would be fragile. So our >>> options are: >>> >>> 1) Keep the stream_mappings[] array. It's simple, and it'll work >>> for any number of streams. >>> >>> 2) Kill stream_mappings[] and just do the MOD again. >> >> 3) print a message and tell streams aren't supported on this device. > > Is that your nvme preference - if less than 4 streams, just ignore it? > Would seem a shame to lose out with 2 streams, I can think of several > hot/cold scenarios that would probably work fine with that. But at the > same time, not a big deal to me, if you prefer just turning it off > for < 4 streams, that's fine with me. http://git.kernel.dk/cgit/linux-block/commit/?h=write-stream&id=98335ae1347a9a08adc831e77e8fefcf06ab8282 -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: axboe@kernel.dk (Jens Axboe) Date: Tue, 27 Jun 2017 08:56:34 -0600 Subject: [PATCH 9/9] nvme: add support for streams and directives In-Reply-To: References: <1498004526-4543-1-git-send-email-axboe@kernel.dk> <1498004526-4543-10-git-send-email-axboe@kernel.dk> <20170626095907.GG14057@infradead.org> <20170627141115.GA2541@infradead.org> <20170627144405.GA4605@infradead.org> Message-ID: On 06/27/2017 08:46 AM, Jens Axboe wrote: > On 06/27/2017 08:44 AM, Christoph Hellwig wrote: >> On Tue, Jun 27, 2017@08:16:49AM -0600, Jens Axboe wrote: >>> But we have to handle it, not doing so would be fragile. So our >>> options are: >>> >>> 1) Keep the stream_mappings[] array. It's simple, and it'll work >>> for any number of streams. >>> >>> 2) Kill stream_mappings[] and just do the MOD again. >> >> 3) print a message and tell streams aren't supported on this device. > > Is that your nvme preference - if less than 4 streams, just ignore it? > Would seem a shame to lose out with 2 streams, I can think of several > hot/cold scenarios that would probably work fine with that. But at the > same time, not a big deal to me, if you prefer just turning it off > for < 4 streams, that's fine with me. http://git.kernel.dk/cgit/linux-block/commit/?h=write-stream&id=98335ae1347a9a08adc831e77e8fefcf06ab8282 -- Jens Axboe