From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10602C433E0 for ; Fri, 15 Jan 2021 08:47:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94B6223329 for ; Fri, 15 Jan 2021 08:47:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94B6223329 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D8A288D013E; Fri, 15 Jan 2021 03:47:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D39678D0023; Fri, 15 Jan 2021 03:47:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C02068D013E; Fri, 15 Jan 2021 03:47:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id AA80D8D0023 for ; Fri, 15 Jan 2021 03:47:09 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 74A45362A for ; Fri, 15 Jan 2021 08:47:09 +0000 (UTC) X-FDA: 77707379778.24.alarm23_3106d882752e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 562D71A4A5 for ; Fri, 15 Jan 2021 08:47:09 +0000 (UTC) X-HE-Tag: alarm23_3106d882752e X-Filterd-Recvd-Size: 4199 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 08:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610700428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q8mlngqUzb4YHP1SYtAerxdd08IKO7k09BMTw1AmigY=; b=EYvoZrfL2wEqSDOpyy4GWG6JrDfj/Yt1X81/a3Jc75mXaivO0Q96mpY+BsdXJi1roHI688 Ab86IWoA1tgkXi5+mz9Z2wBuG7sP5ZOuLjGCwxBxJHoz5DY1sv1qHoVFn5sETUjmCNbgcs ZoaujwBxlKb7ePl2xqapZ1N+eDLmQgE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-CnC7oClSN-uWzM03Q9fRgQ-1; Fri, 15 Jan 2021 03:47:06 -0500 X-MC-Unique: CnC7oClSN-uWzM03Q9fRgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0A668143EA; Fri, 15 Jan 2021 08:47:03 +0000 (UTC) Received: from [10.36.112.11] (ovpn-112-11.ams2.redhat.com [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42A8A10013C0; Fri, 15 Jan 2021 08:46:59 +0000 (UTC) Subject: Re: [PATCH 1/2] mm, slub: use pGp to print page flags To: Yafang Shao , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, osalvador@suse.de, linmiaohe@huawei.com, steven.price@arm.com, guro@fb.com, alexander.h.duyck@linux.intel.com, ying.huang@intel.com Cc: linux-mm@kvack.org References: <20210115061349.67386-1-laoar.shao@gmail.com> <20210115061349.67386-2-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Fri, 15 Jan 2021 09:46:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210115061349.67386-2-laoar.shao@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.01.21 07:13, Yafang Shao wrote: > As pGp has been already introduced in printk, we'd better use it to make > the output human readable. > > Before this change, the output is, > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > While after this change, the output is, > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > Signed-off-by: Yafang Shao > --- > mm/slub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index dc5b42e..901a45a 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -641,8 +641,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_page_info(struct page *page) > { > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > - page, page->objects, page->inuse, page->freelist, page->flags); > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > + page, page->objects, page->inuse, page->freelist, > + page->flags, &page->flags); > > } > > Sounds helpful to me. "pr_err" combined with "INFO" looks a little weird - "Oh my, something serious just happened!!!! - but, hey, just for your information ... " :) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb