Re: [meta-oe][PATCH 1/3] guider: add a new runtime profiler package

[Randy MacLeod <randy.macleod@windriver.com>]

Neat tool! I'll have to play with it a bit more.

On 12/30/18 11:50 AM, Khem Raj wrote:
> From: Peace Lee <iipeace5@gmail.com>
> 
> guider [1] is a system-wide performance analyzer for platforms based

Well, it seems to be more of a meta-tool that uses standard tools.
In addition, it improves usability at the cost of defining policy
such as immediately analyzing some data collection on target.
It would be nice to succinctly summarize that if you can.
> on linux kernel. it can measure vary system resource usage and
s/it/It/
s/vary/a variety of/
> trace thread/process activities. and it reports vary meaningful
> output to analyze system status.
It reports very meaningful output to analyze system status.
> 
> [1] https://github.com/iipeace/guider
> 
> Signed-off-by: Peace Lee <iipeace5@gmail.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   .../recipes-devtools/guider/guider_3.9.3.bb   | 34 +++++++++++++++++++
>   1 file changed, 34 insertions(+)
>   create mode 100644 meta-oe/recipes-devtools/guider/guider_3.9.3.bb
> 
> diff --git a/meta-oe/recipes-devtools/guider/guider_3.9.3.bb b/meta-oe/recipes-devtools/guider/guider_3.9.3.bb
> new file mode 100644
> index 0000000000..96d6c62ae2
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/guider/guider_3.9.3.bb
> @@ -0,0 +1,34 @@
> +SUMMARY = "runtime performance analyzer"
> +HOMEPAGE = "https://github.com/iipeace/guider"
> +BUGTRACKER = "https://github.com/iipeace/guider/issues"
> +AUTHOR = "Peace Lee <ipeace5@gmail.com>"
> +
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=2c1c00f9d3ed9e24fa69b932b7e7aff2"
> +
> +SRC_URI = "git://github.com/iipeace/${BPN}"
> +SRCREV = "ac05a2ce0ab480957d642d947d8f617bd224031d"
> +
> +S = "${WORKDIR}/git"
> +R = "${RECIPE_SYSROOT_NATIVE}"
> +
> +inherit distutils
> +
> +GUIDER_OBJ = "guider.pyc"
> +GUIDER_SCRIPT = "guider"
> +
> +do_install() {
> +    python ${S}/setup.py install
> +
> +    install -d ${D}${bindir}
> +    install -v -m 0755 ${R}/${bindir}/${GUIDER_SCRIPT} ${D}${bindir}/${GUIDER_SCRIPT}
> +
> +    install -d ${D}${datadir}/${BPN}
> +    install -v -m 0755 ${R}/${datadir}/${BPN}/${GUIDER_OBJ} ${D}${datadir}/${BPN}/${GUIDER_OBJ}
> +}
> +
> +RDEPENDS_${PN} = "python-ctypes python-shell \
> +                  python-json python-subprocess"

Shouldn't the packages that guider uses be recommended at least?
I'm not familiar with the app so maybe it can do useful things without
top, perf, etc.

Should we add a kernel cfg fragment?

> +
> +FILES_SOLIBSDEV = ""
> +#FILES_${PN} = "usr"
Drop that line?

> 



-- 
# Randy MacLeod
# Wind River Linux