From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Bob Pearson <rpearsonhpe@gmail.com>, Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 2/3] RDMA/rxe: Replace write_lock_bh with write_lock_irqsave in __rxe_drop_index
Date: Fri, 11 Feb 2022 18:09:49 +0800 [thread overview]
Message-ID: <b9d5b243-2397-42bd-d833-1a1e5e4ce32c@linux.dev> (raw)
In-Reply-To: <cd90c0e1-0327-4f0b-1b38-489fd18cf9d5@gmail.com>
On 2/10/22 11:49 PM, Bob Pearson wrote:
> On 2/10/22 08:16, Zhu Yanjun wrote:
>> On Thu, Feb 10, 2022 at 3:37 PM Guoqing Jiang<guoqing.jiang@linux.dev> wrote:
>>> Same as __rxe_add_index, the lock need to be fully IRQ safe, otherwise
>>> below calltrace appears.
>>>
> I had the impression that NAPI ran on a soft IRQ and the rxe tasklets are also on soft IRQs. So at least in theory spin_lock_bh() should be sufficient. Can someone explain where the hard interrupt is coming from that we need to protect.
Since rxe is actually run on top of NIC, could it comes from NIC if NIC
driver doesn't switch to NAPI
or from other hardware? But my knowledge about the domain is limited.
> There are other race conditions in current rxe that may also be the cause of this. I am trying to get a patch series accepted to deal with those.
If possible, could you investigate why rxe after 5.15 kernel doesn't
work as reported in cover letter? Thank you!
Guoqing
next prev parent reply other threads:[~2022-02-11 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 7:36 [PATCH 0/3] patches and bug report for rxe Guoqing Jiang
2022-02-10 7:36 ` [PATCH 1/3] RDMA/rxe: Replace write_lock_bh with write_lock_irqsave in __rxe_add_index Guoqing Jiang
2022-02-10 13:29 ` Zhu Yanjun
2022-02-10 7:36 ` [PATCH 2/3] RDMA/rxe: Replace write_lock_bh with write_lock_irqsave in __rxe_drop_index Guoqing Jiang
2022-02-10 14:16 ` Zhu Yanjun
2022-02-10 15:49 ` Bob Pearson
2022-02-11 10:09 ` Guoqing Jiang [this message]
2022-02-11 17:37 ` Bob Pearson
2022-02-12 0:59 ` Guoqing Jiang
2022-02-10 7:36 ` [PATCH 3/3] RDMA/rxe: Replace spin_lock_bh with spin_lock_irqsave in post_one_send Guoqing Jiang
2022-02-10 14:18 ` Zhu Yanjun
2022-02-22 9:50 ` bug report for rxe Guoqing Jiang
2022-02-22 10:04 ` Zhu Yanjun
2022-02-22 16:58 ` Pearson, Robert B
2022-02-23 4:43 ` Guoqing Jiang
2022-02-23 5:01 ` Bob Pearson
2022-02-23 5:50 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d5b243-2397-42bd-d833-1a1e5e4ce32c@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.