From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94B0C433FE for ; Tue, 26 Apr 2022 13:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351012AbiDZNhv (ORCPT ); Tue, 26 Apr 2022 09:37:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245118AbiDZNhu (ORCPT ); Tue, 26 Apr 2022 09:37:50 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB1C93D1D5 for ; Tue, 26 Apr 2022 06:34:42 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id g23so15346525edy.13 for ; Tue, 26 Apr 2022 06:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=AfK1/zrk/APNctf5T9jianFlu/dOwBeL60VvN0e/AUy20xraPdotq4gHXNjA82CwJr ASxbJYqu/egWXvhpdKoCATOneKWXEB28QPFqU/ljIv7xIVAyep8++QsrKalLELi38q10 K0gVVa4FyK1t8583z4ZcRnHTJDFCo4aXPEOnCMQPKOVFVeYZy3rM/h2kAQSa7PPkoHke gXsnm8Yy78EAhDlPM8YcMa30cLGqmBSUZGqsijkjXNayacWiKkU1T55DciCPfdIoS15v /r8zAhYkcEExrX6vnIyglxCze6PJY288k25AKszUJPG1oADUV5q4y7/jD/hKEuA12URa AyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=CrtQHo/FsWA4xfc1qCqGmx6bRYjdVfe+r6Q0lQdnnZ2RZC1uHNGmXTmYytAFv55RJp jndOIl8TfVb9ckqy+dP0u/qDASWyjI2pA4kDowO/7h6lNx1fMmTLHfUVF/bDxDcN17W4 Bl4EZ3Aj/6fLr9gpE2ebkhDqUtNn8TvOPUXdIQBI1uOV+Hc44ZrCvLkOKjibuXK2Vqps t0pfF1JxTtvLdGcmwbIkYzOxS3TWtnSFmOtBq/09UqTiN5paovMXs5Oq0Afn62a+uLYZ dG7o/WhW0yT/19bPZe2h8ZkQt+rX7toKQHMOW9/y5fbK9KpcC7EZqWnCOqSB9byFw4gt iiJw== X-Gm-Message-State: AOAM531sJAh4ieXy1i8/k0ftUwjkZLujRmcgcXDRTq9dwy3FRoFTnzo6 /9XJCtJkQE3ftKPy17Wb0Sp/bQ== X-Google-Smtp-Source: ABdhPJxrkUCfsREmZu2hMfXwSgf00eMictV7sH2Jynsq9vkfWIIiY5pr9thcID2PxdIUiCu86TY+jQ== X-Received: by 2002:a05:6402:27cb:b0:423:d386:42be with SMTP id c11-20020a05640227cb00b00423d38642bemr24839191ede.227.1650980081504; Tue, 26 Apr 2022 06:34:41 -0700 (PDT) Received: from [192.168.0.251] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id lf5-20020a170907174500b006f3806fc9cdsm3416854ejc.39.2022.04.26.06.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 06:34:40 -0700 (PDT) Message-ID: Date: Tue, 26 Apr 2022 15:34:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding Content-Language: en-US To: "Hawkins, Nick" , Rob Herring Cc: "Verdun, Jean-Marie" , "joel@jms.id.au" , "arnd@arndb.de" , "openbmc@lists.ozlabs.org" , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220421192132.109954-1-nick.hawkins@hpe.com> <20220421192132.109954-7-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/2022 15:21, Hawkins, Nick wrote: >> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions. > > It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node. I have impression my feedback was about mapping entire address space, not few registers of watchdog: https://lore.kernel.org/all/c6309ed8-6e74-67d3-304a-f5399d16cc37@canonical.com/ However later during talks it turned out that the address space is heavily shared. Nick, BTW, do you see my comments in the email I linked above? This v5 makes the same mistake. We talked about this already, so please make note of comments you receive and implement them. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81963C433F5 for ; Tue, 26 Apr 2022 22:49:35 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Knxs96ZwXz2yMD for ; Wed, 27 Apr 2022 08:49:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=AfK1/zrk; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::52d; helo=mail-ed1-x52d.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=AfK1/zrk; dkim-atps=neutral Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KnjY73dNmz2xBF for ; Tue, 26 Apr 2022 23:34:49 +1000 (AEST) Received: by mail-ed1-x52d.google.com with SMTP id e23so1334270eda.11 for ; Tue, 26 Apr 2022 06:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=AfK1/zrk/APNctf5T9jianFlu/dOwBeL60VvN0e/AUy20xraPdotq4gHXNjA82CwJr ASxbJYqu/egWXvhpdKoCATOneKWXEB28QPFqU/ljIv7xIVAyep8++QsrKalLELi38q10 K0gVVa4FyK1t8583z4ZcRnHTJDFCo4aXPEOnCMQPKOVFVeYZy3rM/h2kAQSa7PPkoHke gXsnm8Yy78EAhDlPM8YcMa30cLGqmBSUZGqsijkjXNayacWiKkU1T55DciCPfdIoS15v /r8zAhYkcEExrX6vnIyglxCze6PJY288k25AKszUJPG1oADUV5q4y7/jD/hKEuA12URa AyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=OVAlYrppHztga48bycB2DTkYLjUo5h5fMBRw+JDSVBwnb/i7YtI6kgKlsA223uQaMG 7vi6fYMFUAIviBQC30lo3abnJj7jcUYO8A3rpRGJcZi9ljAktPzzDtmnOP2AhH6D/1OO QZyXAdudGo3wbWiJImpWHCxm+HOk+7nO3s/ZLFRHchRnU4Yz8Eq2j3kkrxvPyBjvbA7r ZBvXyOjTwRy8JdYyHdwS2JyIZsmXDlxJmemlc2neiF/SRWx2n3Bal0qSqNos6ltxtFT1 xL8cDxv8+ixS2YxFgDT8TmVr/EJ2OdPN5iBbm1BO/KjmERhzl4dNq8VFcNho6E9Lf2BQ qKMQ== X-Gm-Message-State: AOAM531xglKvaWvLZIHfL0VuI9fIRwQaEQX5zBeqPV4sAmdNMpbtigeL hDkLa+hREicqkvqoK6h8vtJjSQ== X-Google-Smtp-Source: ABdhPJxrkUCfsREmZu2hMfXwSgf00eMictV7sH2Jynsq9vkfWIIiY5pr9thcID2PxdIUiCu86TY+jQ== X-Received: by 2002:a05:6402:27cb:b0:423:d386:42be with SMTP id c11-20020a05640227cb00b00423d38642bemr24839191ede.227.1650980081504; Tue, 26 Apr 2022 06:34:41 -0700 (PDT) Received: from [192.168.0.251] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id lf5-20020a170907174500b006f3806fc9cdsm3416854ejc.39.2022.04.26.06.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 06:34:40 -0700 (PDT) Message-ID: Date: Tue, 26 Apr 2022 15:34:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding Content-Language: en-US To: "Hawkins, Nick" , Rob Herring References: <20220421192132.109954-1-nick.hawkins@hpe.com> <20220421192132.109954-7-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 27 Apr 2022 08:48:57 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "arnd@arndb.de" , "Verdun, Jean-Marie" , "linux-kernel@vger.kernel.org" , "joel@jms.id.au" , Krzysztof Kozlowski , Wim Van Sebroeck , "openbmc@lists.ozlabs.org" , Guenter Roeck Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 26/04/2022 15:21, Hawkins, Nick wrote: >> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions. > > It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node. I have impression my feedback was about mapping entire address space, not few registers of watchdog: https://lore.kernel.org/all/c6309ed8-6e74-67d3-304a-f5399d16cc37@canonical.com/ However later during talks it turned out that the address space is heavily shared. Nick, BTW, do you see my comments in the email I linked above? This v5 makes the same mistake. We talked about this already, so please make note of comments you receive and implement them. Best regards, Krzysztof