From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D361C433E0 for ; Fri, 25 Dec 2020 06:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E93B423129 for ; Fri, 25 Dec 2020 06:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbgLYGTo (ORCPT ); Fri, 25 Dec 2020 01:19:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50731 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbgLYGTn (ORCPT ); Fri, 25 Dec 2020 01:19:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608877097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpqVkUDXq+c4toXVZRgWMvwCiy7iTphoDiBdMjsrs6k=; b=LOkm3u6PsKWTZtzPJMDG7eM8uxPJ04ZcCJFkwjBHKw+0iqUFtnnnrHsUG+1gAdMEysINNJ 29Dta6bZ+oTHGa6pWsehX+MKzZhDuERCY+DRaMevFxEeE3tnUKtoR7GgXhv5+g804y/fJH FBo3NIHC4qMJTPkHkOdU3fNzKOysvwc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-xPtuXUzFMiK4Elmmw801lQ-1; Fri, 25 Dec 2020 01:18:13 -0500 X-MC-Unique: xPtuXUzFMiK4Elmmw801lQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B22B107ACF5; Fri, 25 Dec 2020 06:18:11 +0000 (UTC) Received: from [10.72.12.166] (ovpn-12-166.pek2.redhat.com [10.72.12.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id B987B10023B9; Fri, 25 Dec 2020 06:18:04 +0000 (UTC) Subject: Re: [PATCH net v2] tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS To: wangyunjian , netdev@vger.kernel.org, mst@redhat.com, willemdebruijn.kernel@gmail.com Cc: virtualization@lists.linux-foundation.org, jerry.lilijun@huawei.com, chenchanghu@huawei.com, xudingke@huawei.com, brian.huangbin@huawei.com References: <1608864736-24332-1-git-send-email-wangyunjian@huawei.com> From: Jason Wang Message-ID: Date: Fri, 25 Dec 2020 14:18:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1608864736-24332-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/12/25 上午10:52, wangyunjian wrote: > From: Yunjian Wang > > Currently the tun_napi_alloc_frags() function returns -ENOMEM when the > number of iovs exceeds MAX_SKB_FRAGS + 1. However this is inappropriate, > we should use -EMSGSIZE instead of -ENOMEM. > > The following distinctions are matters: > 1. the caller need to drop the bad packet when -EMSGSIZE is returned, > which means meeting a persistent failure. > 2. the caller can try again when -ENOMEM is returned, which means > meeting a transient failure. > > Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver") > Signed-off-by: Yunjian Wang > Acked-by: Willem de Bruijn > --- > v2: > * update commit log suggested by Willem de Bruijn > --- > drivers/net/tun.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index 2dc1988a8973..15c6dd7fb04c 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -1365,7 +1365,7 @@ static struct sk_buff *tun_napi_alloc_frags(struct tun_file *tfile, > int i; > > if (it->nr_segs > MAX_SKB_FRAGS + 1) > - return ERR_PTR(-ENOMEM); > + return ERR_PTR(-EMSGSIZE); > > local_bh_disable(); > skb = napi_get_frags(&tfile->napi); Acked-by: Jason Wang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B376DC433DB for ; Fri, 25 Dec 2020 06:18:23 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23D1F23129 for ; Fri, 25 Dec 2020 06:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23D1F23129 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 44C762047E; Fri, 25 Dec 2020 06:18:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JT8D+froIF35; Fri, 25 Dec 2020 06:18:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 78E0C20410; Fri, 25 Dec 2020 06:18:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6559FC1825; Fri, 25 Dec 2020 06:18:19 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id DCAF6C0893 for ; Fri, 25 Dec 2020 06:18:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C844A873E8 for ; Fri, 25 Dec 2020 06:18:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N99w6IGQGwLI for ; Fri, 25 Dec 2020 06:18:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by hemlock.osuosl.org (Postfix) with ESMTPS id AF09A873E3 for ; Fri, 25 Dec 2020 06:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608877095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpqVkUDXq+c4toXVZRgWMvwCiy7iTphoDiBdMjsrs6k=; b=BRhGUuqP7W/a4iQHGFCW5HRuCIcmv98OEW8Aj9Eqh1BnE0vbuDl+I72imQqixLOJ1v1PuG qlV+BmM9k21w77lPhNQe+sl2YfsOPeJ0QvsQTOl+/+1hcnskgz8VHp5j2FHkH+2VBSnEDV wVnW4Aals4Dk2TFgB7DhN1olkBbLoMA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-xPtuXUzFMiK4Elmmw801lQ-1; Fri, 25 Dec 2020 01:18:13 -0500 X-MC-Unique: xPtuXUzFMiK4Elmmw801lQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B22B107ACF5; Fri, 25 Dec 2020 06:18:11 +0000 (UTC) Received: from [10.72.12.166] (ovpn-12-166.pek2.redhat.com [10.72.12.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id B987B10023B9; Fri, 25 Dec 2020 06:18:04 +0000 (UTC) Subject: Re: [PATCH net v2] tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS To: wangyunjian , netdev@vger.kernel.org, mst@redhat.com, willemdebruijn.kernel@gmail.com References: <1608864736-24332-1-git-send-email-wangyunjian@huawei.com> From: Jason Wang Message-ID: Date: Fri, 25 Dec 2020 14:18:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1608864736-24332-1-git-send-email-wangyunjian@huawei.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Cc: xudingke@huawei.com, brian.huangbin@huawei.com, jerry.lilijun@huawei.com, chenchanghu@huawei.com, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ck9uIDIwMjAvMTIvMjUg5LiK5Y2IMTA6NTIsIHdhbmd5dW5qaWFuIHdyb3RlOgo+IEZyb206IFl1 bmppYW4gV2FuZyA8d2FuZ3l1bmppYW5AaHVhd2VpLmNvbT4KPgo+IEN1cnJlbnRseSB0aGUgdHVu X25hcGlfYWxsb2NfZnJhZ3MoKSBmdW5jdGlvbiByZXR1cm5zIC1FTk9NRU0gd2hlbiB0aGUKPiBu dW1iZXIgb2YgaW92cyBleGNlZWRzIE1BWF9TS0JfRlJBR1MgKyAxLiBIb3dldmVyIHRoaXMgaXMg aW5hcHByb3ByaWF0ZSwKPiB3ZSBzaG91bGQgdXNlIC1FTVNHU0laRSBpbnN0ZWFkIG9mIC1FTk9N RU0uCj4KPiBUaGUgZm9sbG93aW5nIGRpc3RpbmN0aW9ucyBhcmUgbWF0dGVyczoKPiAxLiB0aGUg Y2FsbGVyIG5lZWQgdG8gZHJvcCB0aGUgYmFkIHBhY2tldCB3aGVuIC1FTVNHU0laRSBpcyByZXR1 cm5lZCwKPiAgICAgd2hpY2ggbWVhbnMgbWVldGluZyBhIHBlcnNpc3RlbnQgZmFpbHVyZS4KPiAy LiB0aGUgY2FsbGVyIGNhbiB0cnkgYWdhaW4gd2hlbiAtRU5PTUVNIGlzIHJldHVybmVkLCB3aGlj aCBtZWFucwo+ICAgICBtZWV0aW5nIGEgdHJhbnNpZW50IGZhaWx1cmUuCj4KPiBGaXhlczogOTBl MzNkNDU5NDA3ICgidHVuOiBlbmFibGUgbmFwaV9ncm9fZnJhZ3MoKSBmb3IgVFVOL1RBUCBkcml2 ZXIiKQo+IFNpZ25lZC1vZmYtYnk6IFl1bmppYW4gV2FuZyA8d2FuZ3l1bmppYW5AaHVhd2VpLmNv bT4KPiBBY2tlZC1ieTogV2lsbGVtIGRlIEJydWlqbiA8d2lsbGVtYkBnb29nbGUuY29tPgo+IC0t LQo+IHYyOgo+ICAgICogdXBkYXRlIGNvbW1pdCBsb2cgc3VnZ2VzdGVkIGJ5IFdpbGxlbSBkZSBC cnVpam4KPiAtLS0KPiAgIGRyaXZlcnMvbmV0L3R1bi5jIHwgMiArLQo+ICAgMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9uZXQvdHVuLmMgYi9kcml2ZXJzL25ldC90dW4uYwo+IGluZGV4IDJkYzE5ODhhODk3My4uMTVj NmRkN2ZiMDRjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L3R1bi5jCj4gKysrIGIvZHJpdmVy cy9uZXQvdHVuLmMKPiBAQCAtMTM2NSw3ICsxMzY1LDcgQEAgc3RhdGljIHN0cnVjdCBza19idWZm ICp0dW5fbmFwaV9hbGxvY19mcmFncyhzdHJ1Y3QgdHVuX2ZpbGUgKnRmaWxlLAo+ICAgCWludCBp Owo+ICAgCj4gICAJaWYgKGl0LT5ucl9zZWdzID4gTUFYX1NLQl9GUkFHUyArIDEpCj4gLQkJcmV0 dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4gKwkJcmV0dXJuIEVSUl9QVFIoLUVNU0dTSVpFKTsKPiAg IAo+ICAgCWxvY2FsX2JoX2Rpc2FibGUoKTsKPiAgIAlza2IgPSBuYXBpX2dldF9mcmFncygmdGZp bGUtPm5hcGkpOwoKCkFja2VkLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxp emF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9u Lm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92 aXJ0dWFsaXphdGlvbg==