Re: [PATCH for-next v4 07/12] RDMA/erdma: Add verbs header file

From: Cheng Xu <chengyou@linux.alibaba.com>
To: Wenpeng Liang <liangwenpeng@huawei.com>,
	jgg@ziepe.ca, dledford@redhat.com
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
	KaiShen@linux.alibaba.com, tonylu@linux.alibaba.com,
	BMT@zurich.ibm.com
Subject: Re: [PATCH for-next v4 07/12] RDMA/erdma: Add verbs header file
Date: Sat, 19 Mar 2022 16:55:36 +0800	[thread overview]
Message-ID: <b9ea8456-c032-1d43-b238-2bd130af2a07@linux.alibaba.com> (raw)
In-Reply-To: <ed3059aa-0c30-84ff-97f4-ac3224f5a64b@huawei.com>

On 3/18/22 7:46 PM, Wenpeng Liang wrote:
> On 2022/3/14 14:47, Cheng Xu wrote:
>> This header file defines the main structrues and functions used for RDMA
>> Verbs, including qp, cq, mr ucontext, etc,.
> 
> structrues -> structures?
> 

Will fix.

> <...>
>> +struct erdma_uqp {
>> +	struct erdma_mem sq_mtt;
>> +	struct erdma_mem rq_mtt;
>> +
>> +	dma_addr_t sq_db_info_dma_addr;
>> +	dma_addr_t rq_db_info_dma_addr;
>> +
>> +	struct erdma_user_dbrecords_page *user_dbr_page;
>> +
>> +	u32 rq_offset;
>> +};
> 
> A blank line is missing here.
> 

Will fix.

Thanks,
Cheng Xu

> Thanks,
> Wenpeng
> 
>> +struct erdma_kqp {
>> +	u16 sq_pi;
>> +	u16 sq_ci;
>> +
>> +	u16 rq_pi;
>> +	u16 rq_ci;