From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D699FC282CE for ; Tue, 12 Feb 2019 08:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEF3D2082F for ; Tue, 12 Feb 2019 08:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728519AbfBLIb5 (ORCPT ); Tue, 12 Feb 2019 03:31:57 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:52277 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728209AbfBLIb5 (ORCPT ); Tue, 12 Feb 2019 03:31:57 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1C8VOwd016393; Tue, 12 Feb 2019 09:31:40 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2qjfy63dwg-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 12 Feb 2019 09:31:40 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CAFFE38; Tue, 12 Feb 2019 08:31:38 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node3.st.com [10.75.127.15]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8468A2449; Tue, 12 Feb 2019 08:31:38 +0000 (GMT) Received: from [10.48.0.167] (10.75.127.47) by SFHDAG5NODE3.st.com (10.75.127.15) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 12 Feb 2019 09:31:37 +0100 Subject: Re: [PATCH v2 3/3] pwm: core: add consumer device link To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: , , , , , , , , , , References: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> <1549901522-15071-4-git-send-email-fabrice.gasnier@st.com> <20190211190628.eisyi6wjus4ltrrn@pengutronix.de> From: Fabrice Gasnier Message-ID: Date: Tue, 12 Feb 2019 09:31:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190211190628.eisyi6wjus4ltrrn@pengutronix.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG7NODE1.st.com (10.75.127.19) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-12_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/19 8:06 PM, Uwe Kleine-König wrote: > Hello Fabrice, > > On Mon, Feb 11, 2019 at 05:12:02PM +0100, Fabrice Gasnier wrote: >> Add a device link between the PWM consumer and the PWM provider. This >> enforces the PWM user to get suspended before the PWM provider. It >> allows proper synchronization of suspend/resume sequences: the PWM user >> is responsible for properly stopping PWM, before the provider gets >> suspended: see [1]. Add the device link in: >> - pwm_get() >> - devm_pwm_get() >> - devm_of_pwm_get() >> as it requires a reference to the device for the PWM consumer. >> >> [1] https://lkml.org/lkml/2019/2/5/770 >> >> Suggested-by: Thierry Reding >> Signed-off-by: Fabrice Gasnier >> --- >> drivers/pwm/core.c | 13 +++++++++++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c >> index 1581f6a..2835e27 100644 >> --- a/drivers/pwm/core.c >> +++ b/drivers/pwm/core.c >> @@ -770,8 +770,13 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) >> int err; >> >> /* look up via DT first */ >> - if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) >> - return of_pwm_get(dev->of_node, con_id); >> + if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) { >> + pwm = of_pwm_get(dev->of_node, con_id); >> + if (!IS_ERR(pwm)) >> + device_link_add(dev, pwm->chip->dev, >> + DL_FLAG_AUTOREMOVE_CONSUMER); >> + return pwm; >> + } >> >> /* >> * We look up the provider in the static table typically provided by >> @@ -851,6 +856,8 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) >> pwm->args.period = chosen->period; >> pwm->args.polarity = chosen->polarity; >> >> + device_link_add(dev, pwm->chip->dev, DL_FLAG_AUTOREMOVE_CONSUMER); >> + >> return pwm; >> } >> EXPORT_SYMBOL_GPL(pwm_get); >> @@ -943,6 +950,8 @@ struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np, >> if (!IS_ERR(pwm)) { >> *ptr = pwm; >> devres_add(dev, ptr); >> + device_link_add(dev, pwm->chip->dev, >> + DL_FLAG_AUTOREMOVE_CONSUMER); > > IMHO it's surprising that devm_of_pwm_get() does more than of_pwm_get() > + devres stuff. I'd put device_link_add() into of_pwm_get(). Hi Uwe, I also agree with this. But I think this implies modifying the API for of_pwm_get(): /** * of_pwm_get() - request a PWM via the PWM framework + * @dev: device for PWM consumer * @np: device node to get the PWM from * @con_id: consumer name It seems there aren't much of_pwm_get() users currently. Does this look sensible ? Best regards, Fabrice > > Best regards > Uwe > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabrice Gasnier Subject: Re: [PATCH v2 3/3] pwm: core: add consumer device link Date: Tue, 12 Feb 2019 09:31:37 +0100 Message-ID: References: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> <1549901522-15071-4-git-send-email-fabrice.gasnier@st.com> <20190211190628.eisyi6wjus4ltrrn@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190211190628.eisyi6wjus4ltrrn@pengutronix.de> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.torgue@st.com, tduszyns@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, thierry.reding@gmail.com, linux-pwm@vger.kernel.org, mcoquelin.stm32@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gMi8xMS8xOSA4OjA2IFBNLCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiBIZWxsbyBGYWJy aWNlLAo+IAo+IE9uIE1vbiwgRmViIDExLCAyMDE5IGF0IDA1OjEyOjAyUE0gKzAxMDAsIEZhYnJp Y2UgR2FzbmllciB3cm90ZToKPj4gQWRkIGEgZGV2aWNlIGxpbmsgYmV0d2VlbiB0aGUgUFdNIGNv bnN1bWVyIGFuZCB0aGUgUFdNIHByb3ZpZGVyLiBUaGlzCj4+IGVuZm9yY2VzIHRoZSBQV00gdXNl ciB0byBnZXQgc3VzcGVuZGVkIGJlZm9yZSB0aGUgUFdNIHByb3ZpZGVyLiBJdAo+PiBhbGxvd3Mg cHJvcGVyIHN5bmNocm9uaXphdGlvbiBvZiBzdXNwZW5kL3Jlc3VtZSBzZXF1ZW5jZXM6IHRoZSBQ V00gdXNlcgo+PiBpcyByZXNwb25zaWJsZSBmb3IgcHJvcGVybHkgc3RvcHBpbmcgUFdNLCBiZWZv cmUgdGhlIHByb3ZpZGVyIGdldHMKPj4gc3VzcGVuZGVkOiBzZWUgWzFdLiBBZGQgdGhlIGRldmlj ZSBsaW5rIGluOgo+PiAtIHB3bV9nZXQoKQo+PiAtIGRldm1fcHdtX2dldCgpCj4+IC0gZGV2bV9v Zl9wd21fZ2V0KCkKPj4gYXMgaXQgcmVxdWlyZXMgYSByZWZlcmVuY2UgdG8gdGhlIGRldmljZSBm b3IgdGhlIFBXTSBjb25zdW1lci4KPj4KPj4gWzFdIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE5 LzIvNS83NzAKPj4KPj4gU3VnZ2VzdGVkLWJ5OiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRp bmdAZ21haWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBGYWJyaWNlIEdhc25pZXIgPGZhYnJpY2Uu Z2FzbmllckBzdC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9wd20vY29yZS5jIHwgMTMgKysrKysr KysrKystLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3B3bS9jb3JlLmMgYi9kcml2ZXJzL3B3bS9j b3JlLmMKPj4gaW5kZXggMTU4MWY2YS4uMjgzNWUyNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9w d20vY29yZS5jCj4+ICsrKyBiL2RyaXZlcnMvcHdtL2NvcmUuYwo+PiBAQCAtNzcwLDggKzc3MCwx MyBAQCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdtX2dldChzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0 IGNoYXIgKmNvbl9pZCkKPj4gIAlpbnQgZXJyOwo+PiAgCj4+ICAJLyogbG9vayB1cCB2aWEgRFQg Zmlyc3QgKi8KPj4gLQlpZiAoSVNfRU5BQkxFRChDT05GSUdfT0YpICYmIGRldiAmJiBkZXYtPm9m X25vZGUpCj4+IC0JCXJldHVybiBvZl9wd21fZ2V0KGRldi0+b2Zfbm9kZSwgY29uX2lkKTsKPj4g KwlpZiAoSVNfRU5BQkxFRChDT05GSUdfT0YpICYmIGRldiAmJiBkZXYtPm9mX25vZGUpIHsKPj4g KwkJcHdtID0gb2ZfcHdtX2dldChkZXYtPm9mX25vZGUsIGNvbl9pZCk7Cj4+ICsJCWlmICghSVNf RVJSKHB3bSkpCj4+ICsJCQlkZXZpY2VfbGlua19hZGQoZGV2LCBwd20tPmNoaXAtPmRldiwKPj4g KwkJCQkJRExfRkxBR19BVVRPUkVNT1ZFX0NPTlNVTUVSKTsKPj4gKwkJcmV0dXJuIHB3bTsKPj4g Kwl9Cj4+ICAKPj4gIAkvKgo+PiAgCSAqIFdlIGxvb2sgdXAgdGhlIHByb3ZpZGVyIGluIHRoZSBz dGF0aWMgdGFibGUgdHlwaWNhbGx5IHByb3ZpZGVkIGJ5Cj4+IEBAIC04NTEsNiArODU2LDggQEAg c3RydWN0IHB3bV9kZXZpY2UgKnB3bV9nZXQoc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCBjaGFy ICpjb25faWQpCj4+ICAJcHdtLT5hcmdzLnBlcmlvZCA9IGNob3Nlbi0+cGVyaW9kOwo+PiAgCXB3 bS0+YXJncy5wb2xhcml0eSA9IGNob3Nlbi0+cG9sYXJpdHk7Cj4+ICAKPj4gKwlkZXZpY2VfbGlu a19hZGQoZGV2LCBwd20tPmNoaXAtPmRldiwgRExfRkxBR19BVVRPUkVNT1ZFX0NPTlNVTUVSKTsK Pj4gKwo+PiAgCXJldHVybiBwd207Cj4+ICB9Cj4+ICBFWFBPUlRfU1lNQk9MX0dQTChwd21fZ2V0 KTsKPj4gQEAgLTk0Myw2ICs5NTAsOCBAQCBzdHJ1Y3QgcHdtX2RldmljZSAqZGV2bV9vZl9wd21f Z2V0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpucCwKPj4gIAlpZiAo IUlTX0VSUihwd20pKSB7Cj4+ICAJCSpwdHIgPSBwd207Cj4+ICAJCWRldnJlc19hZGQoZGV2LCBw dHIpOwo+PiArCQlkZXZpY2VfbGlua19hZGQoZGV2LCBwd20tPmNoaXAtPmRldiwKPj4gKwkJCQlE TF9GTEFHX0FVVE9SRU1PVkVfQ09OU1VNRVIpOwo+IAo+IElNSE8gaXQncyBzdXJwcmlzaW5nIHRo YXQgZGV2bV9vZl9wd21fZ2V0KCkgZG9lcyBtb3JlIHRoYW4gb2ZfcHdtX2dldCgpCj4gKyBkZXZy ZXMgc3R1ZmYuIEknZCBwdXQgZGV2aWNlX2xpbmtfYWRkKCkgaW50byBvZl9wd21fZ2V0KCkuCgpI aSBVd2UsCgpJIGFsc28gYWdyZWUgd2l0aCB0aGlzLiBCdXQgSSB0aGluayB0aGlzIGltcGxpZXMg bW9kaWZ5aW5nIHRoZSBBUEkgZm9yCm9mX3B3bV9nZXQoKToKIC8qKgogICogb2ZfcHdtX2dldCgp IC0gcmVxdWVzdCBhIFBXTSB2aWEgdGhlIFBXTSBmcmFtZXdvcmsKKyAqIEBkZXY6IGRldmljZSBm b3IgUFdNIGNvbnN1bWVyCiAgKiBAbnA6IGRldmljZSBub2RlIHRvIGdldCB0aGUgUFdNIGZyb20K ICAqIEBjb25faWQ6IGNvbnN1bWVyIG5hbWUKCkl0IHNlZW1zIHRoZXJlIGFyZW4ndCBtdWNoIG9m X3B3bV9nZXQoKSB1c2VycyBjdXJyZW50bHkuCkRvZXMgdGhpcyBsb29rIHNlbnNpYmxlID8KCkJl c3QgcmVnYXJkcywKRmFicmljZQoKPiAKPiBCZXN0IHJlZ2FyZHMKPiBVd2UKPiAKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK