From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2] drm/scheduler: fix timeout worker setup for out of order job completions Date: Fri, 3 Aug 2018 16:55:50 +0000 (UTC) Message-ID: References: <20180803142947.30724-1-l.stach@pengutronix.de> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Date: Mon, 6 Aug 2018 14:57:49 +0200 In-Reply-To: <20180803142947.30724-1-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Lucas Stach , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, patchwork-lst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Eric Anholt , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Nayan Deshmukh List-Id: dri-devel@lists.freedesktop.org QW0gMDMuMDguMjAxOCB1bSAxNjoyOSBzY2hyaWViIEx1Y2FzIFN0YWNoOgo+IGRybV9zY2hlZF9q b2JfZmluaXNoKCkgaXMgYSB3b3JrIGl0ZW0gc2NoZWR1bGVkIGZvciBlYWNoIGZpbmlzaGVkIGpv YiBvbgo+IGEgdW5ib3VuZCBzeXN0ZW0gd29ya3F1ZXVlLiBUaGlzIG1lYW5zIHRoZSB3b3JrZXJz IGNhbiBleGVjdXRlIG91dCBvZiBvcmRlcgo+IHdpdGggcmVnYXJkIHRvIHRoZSByZWFsIGhhcmR3 YXJlIGpvYiBjb21wbGV0aW9ucy4KPgo+IElmIHRoaXMgaGFwcGVucyBxdWV1ZWluZyBhIHRpbWVv dXQgd29ya2VyIGZvciB0aGUgZmlyc3Qgam9iIG9uIHRoZSByaW5nCj4gbWlycm9yIGxpc3QgaXMg d3JvbmcsIGFzIHRoaXMgbWF5IGJlIGEgam9iIHdoaWNoIGhhcyBhbHJlYWR5IGZpbmlzaGVkCj4g ZXhlY3V0aW5nLiBGaXggdGhpcyBieSByZW9yZ2FuaXppbmcgdGhlIGNvZGUgdG8gYWx3YXlzIHF1 ZXVlIHRoZSB3b3JrZXIKPiBmb3IgdGhlIG5leHQgam9iIG9uIHRoZSBsaXN0LCBpZiB0aGlzIGpv YiBoYXNuJ3QgZmluaXNoZWQgeWV0LiBUaGlzIGlzCj4gcm9idXN0IGFnYWluc3QgYSBwb3RlbnRp YWwgcmVvcmRlcmluZyBvZiB0aGUgZmluaXNoIHdvcmtlcnMuCj4KPiBBbHNvIG1vdmUgb3V0IHRo ZSB0aW1lb3V0IHdvcmtlciBjYW5jZWxsaW5nLCBzbyB0aGF0IHdlIGRvbid0IG5lZWQgdG8KPiB0 YWtlIHRoZSBqb2IgbGlzdCBsb2NrIHR3aWNlLiBBcyBhIHNtYWxsIG9wdGltaXphdGlvbiBsaXN0 X2RlbCBpcyB1c2VkCj4gdG8gcmVtb3ZlIHRoZSBqb2IgZnJvbSB0aGUgcmluZyBtaXJyb3IgbGlz dCwgYXMgdGhlcmUgaXMgbm8gbmVlZCB0bwo+IHJlaW5pdCB0aGUgbGlzdCBoZWFkIGluIHRoZSBq b2Igd2UgYXJlIGFib3V0IHRvIGZyZWUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBTdGFjaCA8 bC5zdGFjaEBwZW5ndXRyb25peC5kZT4KPiAtLS0KPiB2MjogLSBwcm9wZXJseSBoYW5kbGUgbGFz dCBqb2IgaW4gdGhlIHJpbmcKPiAgICAgIC0gY2hlY2sgY29ycmVjdCBmZW5jZSBmb3IgY29tcGVs ZXRpb24KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5j IHwgMjIgKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jIGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9n cHVfc2NoZWR1bGVyLmMKPiBpbmRleCA0NGQ0ODA3NjhkZmUuLjU3NDg3NWUyYzIwNiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jCj4gQEAgLTQ1MiwyNCAr NDUyLDIyIEBAIHN0YXRpYyB2b2lkIGRybV9zY2hlZF9qb2JfZmluaXNoKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykKPiAgIAkJCQkJCSAgIGZpbmlzaF93b3JrKTsKPiAgIAlzdHJ1Y3QgZHJtX2dw dV9zY2hlZHVsZXIgKnNjaGVkID0gc19qb2ItPnNjaGVkOwo+ICAgCj4gLQkvKiByZW1vdmUgam9i IGZyb20gcmluZ19taXJyb3JfbGlzdCAqLwo+IC0Jc3Bpbl9sb2NrKCZzY2hlZC0+am9iX2xpc3Rf bG9jayk7Cj4gLQlsaXN0X2RlbF9pbml0KCZzX2pvYi0+bm9kZSk7Cj4gLQlpZiAoc2NoZWQtPnRp bWVvdXQgIT0gTUFYX1NDSEVEVUxFX1RJTUVPVVQpIHsKPiAtCQlzdHJ1Y3QgZHJtX3NjaGVkX2pv YiAqbmV4dDsKPiAtCj4gLQkJc3Bpbl91bmxvY2soJnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsKPiAr CWlmIChzY2hlZC0+dGltZW91dCAhPSBNQVhfU0NIRURVTEVfVElNRU9VVCkKPiAgIAkJY2FuY2Vs X2RlbGF5ZWRfd29ya19zeW5jKCZzX2pvYi0+d29ya190ZHIpOwoKVGhhdCBpcyB1bmZvcnR1bmF0 ZWx5IHN0aWxsIHJhY3kgaGVyZS4KCkJldHdlZW4gY2FuY2VsaW5nIHRoZSBqb2IgYW5kIHJlbW92 aW5nIGl0IGZyb20gdGhlIGxpc3Qgc29tZW9uZSBjb3VsZCAKYWN0dWFsbHkgc3RhcnQgdGhlIHRp bWUgKGluIHRoZW9yeSkgOikKCkNhbmNlbCBpdCwgcmVtb3ZlIGl0IGZyb20gdGhlIGxpc3QgYW5k IGNhbmNlbCBpdCBhZ2Fpbi4KCkJUVzogWW91IGNvdWxkIGNvbXBsZXRlbHkgZHJvcCB0aGUgImlm IChzY2hlZC0+dGltZW91dCAhPSAKTUFYX1NDSEVEVUxFX1RJTUVPVVQpIiBoZXJlIGNhdXNlIGNh bmNlbGluZyBpcyBoYXJtbGVzcyBhcyBsb25nIGFzIHRoZSAKc3RydWN0dXJlIGlzIGluaXRpYWxp emVkLgoKQ2hyaXN0aWFuLgoKPiAtCQlzcGluX2xvY2soJnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsK PiAgIAo+IC0JCS8qIHF1ZXVlIFREUiBmb3IgbmV4dCBqb2IgKi8KPiAtCQluZXh0ID0gbGlzdF9m aXJzdF9lbnRyeV9vcl9udWxsKCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCwKPiAtCQkJCQkJc3Ry dWN0IGRybV9zY2hlZF9qb2IsIG5vZGUpOwo+ICsJc3Bpbl9sb2NrKCZzY2hlZC0+am9iX2xpc3Rf bG9jayk7Cj4gKwkvKiBxdWV1ZSBURFIgZm9yIG5leHQgam9iICovCj4gKwlpZiAoc2NoZWQtPnRp bWVvdXQgIT0gTUFYX1NDSEVEVUxFX1RJTUVPVVQgJiYKPiArCSAgICAhbGlzdF9pc19sYXN0KCZz X2pvYi0+bm9kZSwgJnNjaGVkLT5yaW5nX21pcnJvcl9saXN0KSkgewo+ICsJCXN0cnVjdCBkcm1f c2NoZWRfam9iICpuZXh0ID0gbGlzdF9uZXh0X2VudHJ5KHNfam9iLCBub2RlKTsKPiAgIAo+IC0J CWlmIChuZXh0KQo+ICsJCWlmICghZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKCZuZXh0LT5zX2ZlbmNl LT5maW5pc2hlZCkpCj4gICAJCQlzY2hlZHVsZV9kZWxheWVkX3dvcmsoJm5leHQtPndvcmtfdGRy LCBzY2hlZC0+dGltZW91dCk7Cj4gICAJfQo+ICsJLyogcmVtb3ZlIGpvYiBmcm9tIHJpbmdfbWly cm9yX2xpc3QgKi8KPiArCWxpc3RfZGVsKCZzX2pvYi0+bm9kZSk7Cj4gICAJc3Bpbl91bmxvY2so JnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsKPiArCj4gICAJZG1hX2ZlbmNlX3B1dCgmc19qb2ItPnNf ZmVuY2UtPmZpbmlzaGVkKTsKPiAgIAlzY2hlZC0+b3BzLT5mcmVlX2pvYihzX2pvYik7Cj4gICB9 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4 IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK