All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory
Date: Fri, 18 Aug 2023 12:22:25 +0100	[thread overview]
Message-ID: <b9fc2c2e-7914-4484-92bf-403fbc0d9fee@xen.org> (raw)
In-Reply-To: <20230814074707.27696-20-jgross@suse.com>

Hi Juergen,

On 14/08/2023 08:47, Juergen Gross wrote:
> In tools/xenstore there are living xenstored and xenstore clients.
> They are no longer sharing anything apart from the "xenstore" in their
> names.
> 
> Move the xenstored sources into a new directory tools/xenstored while
> dropping the "xenstored_" prefix from their names. This will make it
> clearer that xenstore clients and xenstored are independent from each
> other.

In term of naming, I would prefer if we follow what was done for the 
console. I.e:

xenstore/client: All the clients
xenstore/daemon: C Xenstored

This would avoid the one character difference between the two directories.

What do the other thinks?

> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> After the large overhaul of xenstored I think such a reorg would make
> sense to go into the same Xen version. Delaying it until the next
> version would make potential backports for 4.18 harder.

+1.

Cheers,

-- 
Julien Grall


  reply	other threads:[~2023-08-18 11:22 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14  7:46 [PATCH v4 00/19] tools/xenstore: drop TDB Juergen Gross
2023-08-14  7:46 ` [PATCH v4 01/19] tools/xenstore: make hashtable key parameter const Juergen Gross
2023-08-14 17:51   ` Julien Grall
2023-08-14  7:46 ` [PATCH v4 02/19] tools/xenstore: let hashtable_add() fail in case of existing entry Juergen Gross
2023-08-14  7:46 ` [PATCH v4 03/19] tools/xenstore: add hashtable_replace() function Juergen Gross
2023-08-14  7:46 ` [PATCH v4 04/19] tools/xenstore: drop use of tdb Juergen Gross
2023-08-14  7:46 ` [PATCH v4 05/19] tools/xenstore: remove tdb code Juergen Gross
2023-08-14  7:46 ` [PATCH v4 06/19] tools/xenstore: let db_delete() return void Juergen Gross
2023-08-14  7:46 ` [PATCH v4 07/19] tools/xenstore: change talloc_free() to take a const pointer Juergen Gross
2023-08-14 17:53   ` Julien Grall
2023-08-14  7:46 ` [PATCH v4 08/19] tools/xenstore: move copying of node data out of db_fetch() Juergen Gross
2023-08-14 17:55   ` Julien Grall
2023-08-14  7:46 ` [PATCH v4 09/19] tools/xenstore: rework struct xs_tdb_record_hdr Juergen Gross
2023-08-14 18:04   ` Julien Grall
2023-08-14  7:46 ` [PATCH v4 10/19] tools/xenstore: don't use struct node_perms in struct node Juergen Gross
2023-08-14 18:09   ` Julien Grall
2023-08-14  7:46 ` [PATCH v4 11/19] tools/xenstore: use struct node_hdr " Juergen Gross
2023-08-18 10:57   ` Julien Grall
2023-08-14  7:47 ` [PATCH v4 12/19] tools/xenstore: alloc new memory in domain_adjust_node_perms() Juergen Gross
2023-08-18 10:59   ` [PATCH v4 12/19]tools/xenstore: " Julien Grall
2023-08-14  7:47 ` [PATCH v4 13/19] tools/xenstore: introduce read_node_const() Juergen Gross
2023-08-18 11:06   ` Julien Grall
2023-08-14  7:47 ` [PATCH v4 14/19] tools/xenstore: merge get_spec_node() into get_node_canonicalized() Juergen Gross
2023-08-18 11:07   ` Julien Grall
2023-08-14  7:47 ` [PATCH v4 15/19] tools/xenstore: merge is_valid_nodename() into canonicalize() Juergen Gross
2023-08-18 11:12   ` Julien Grall
2023-08-14  7:47 ` [PATCH v4 16/19] tools/xenstore: rework get_node() Juergen Gross
2023-08-18 11:14   ` Julien Grall
2023-08-14  7:47 ` [PATCH v4 17/19] tools/xenstore: introduce get_node_const() Juergen Gross
2023-08-18 11:16   ` Julien Grall
2023-08-14  7:47 ` [PATCH v4 18/19] tools/config: add XEN_RUN_STORED to config.h Juergen Gross
2023-08-14 10:34   ` Anthony PERARD
2023-08-14 11:07     ` Juergen Gross
2023-08-14 11:30   ` [PATCH v4.1 " Juergen Gross
2023-08-14  7:47 ` [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory Juergen Gross
2023-08-18 11:22   ` Julien Grall [this message]
2023-08-18 12:14     ` Juergen Gross
2023-08-18 12:42       ` Julien Grall
2023-08-18 12:46         ` Juergen Gross
2023-08-18 12:54 ` [PATCH v4 00/19] tools/xenstore: drop TDB Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9fc2c2e-7914-4484-92bf-403fbc0d9fee@xen.org \
    --to=julien@xen.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.