From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: G S Niteesh Babu <niteesh.gs@gmail.com>, qemu-devel@nongnu.org
Cc: S.E.Harris@kent.ac.uk, mrolnik@gmail.com
Subject: Re: [PATCH 3/3] avr/arduino: Add D13 LED
Date: Sat, 13 Mar 2021 16:10:52 +0100 [thread overview]
Message-ID: <ba00a853-8d3b-9f67-61e8-6f6e04fa64cd@amsat.org> (raw)
In-Reply-To: <20210311135539.10206-4-niteesh.gs@gmail.com>
On 3/11/21 2:55 PM, G S Niteesh Babu wrote:
> Signed-off-by: G S Niteesh Babu <niteesh.gs@gmail.com>
> ---
> hw/avr/Kconfig | 1 +
> hw/avr/arduino.c | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
> index 16a57ced11..e0d4fc5537 100644
> --- a/hw/avr/Kconfig
> +++ b/hw/avr/Kconfig
> @@ -8,3 +8,4 @@ config AVR_ATMEGA_MCU
> config ARDUINO
> select AVR_ATMEGA_MCU
> select UNIMP
> + select LED
> diff --git a/hw/avr/arduino.c b/hw/avr/arduino.c
> index 3c8388490d..5cdba3201c 100644
> --- a/hw/avr/arduino.c
> +++ b/hw/avr/arduino.c
> @@ -13,6 +13,7 @@
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "hw/boards.h"
> +#include "hw/misc/led.h"
> #include "atmega.h"
> #include "boot.h"
> #include "qom/object.h"
> @@ -22,6 +23,8 @@ struct ArduinoMachineState {
> MachineState parent_obj;
> /*< public >*/
> AtmegaMcuState mcu;
> +
> + LEDState *onboard_led;
> };
> typedef struct ArduinoMachineState ArduinoMachineState;
>
> @@ -49,6 +52,18 @@ static void arduino_machine_init(MachineState *machine)
> amc->xtal_hz, &error_abort);
> sysbus_realize(SYS_BUS_DEVICE(&ams->mcu), &error_abort);
>
> + ams->onboard_led = led_create_simple(OBJECT(ams),
> + GPIO_POLARITY_ACTIVE_HIGH,
> + LED_COLOR_BLUE,
> + "D13 LED");
> +
> + /* TODO: Add macro or function to map pins to ports */
> + /* The onboard led is connected to PIN 13 in all boards currently supported
Yes,
> + * in QEMU. And PIN 13 is mapped to PORT B BIT 5.
No. Only on the Duemilanove / UNO. On both Mega it is bit 7.
> + */
> + qdev_connect_gpio_out(DEVICE(&ams->mcu.gpio[1]), 5,
> + qdev_get_gpio_in(DEVICE(ams->onboard_led), 0));
> +
> if (machine->firmware) {
> if (!avr_load_firmware(&ams->mcu.cpu, machine,
> &ams->mcu.flash, machine->firmware)) {
>
next prev parent reply other threads:[~2021-03-13 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:55 [PATCH 0/3] AVR GPIO Emulation and Arduino D13 LED G S Niteesh Babu
2021-03-11 13:55 ` [PATCH 1/3] hw/avr: Add limited support for avr gpio registers G S Niteesh Babu
2021-03-11 13:55 ` [PATCH 2/3] hw/gpio/avr_gpio.c: add tracing for read and writes G S Niteesh Babu
2021-03-13 15:41 ` Philippe Mathieu-Daudé
2021-03-11 13:55 ` [PATCH 3/3] avr/arduino: Add D13 LED G S Niteesh Babu
2021-03-13 15:10 ` Philippe Mathieu-Daudé [this message]
2021-03-11 18:57 ` [PATCH 0/3] AVR GPIO Emulation and Arduino " Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba00a853-8d3b-9f67-61e8-6f6e04fa64cd@amsat.org \
--to=f4bug@amsat.org \
--cc=S.E.Harris@kent.ac.uk \
--cc=mrolnik@gmail.com \
--cc=niteesh.gs@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.