From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Taylor Simpson <tsimpson@quicinc.com>
Cc: "ale@rev.ng" <ale@rev.ng>, Brian Cain <bcain@quicinc.com>,
Richard Henderson <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"laurent@vivier.eu" <laurent@vivier.eu>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>
Subject: Re: [PATCH v8 00/35] Hexagon patch series
Date: Wed, 17 Feb 2021 15:23:03 +0100 [thread overview]
Message-ID: <ba13b1e6-6689-fc3a-dd0d-2f2ff835c813@amsat.org> (raw)
In-Reply-To: <CAFEAcA-5XGrmJ2DrJZtH0Tq8ic=V6Te7o-KJZ_K26Yzk4X79vQ@mail.gmail.com>
On 2/16/21 10:17 PM, Peter Maydell wrote:
> On Tue, 16 Feb 2021 at 20:59, Taylor Simpson <tsimpson@quicinc.com> wrote:
>>> -----Original Message-----
>>> From: Richard Henderson <richard.henderson@linaro.org>
>>> I've completed review of this round, and there are some nits. But they're
>>> minor enough that I wouldn't even mind them being addressed via the
>>> normal
>>> development process. I.e. I'd be keen to not look through that diffstat again.
>>> ;-)
>
>>> Any objections from anyone else on that?
I'm very pleased with how this series evolved over the time,
and Taylor interaction with the community during the long
review process.
Patches 1-34 are OK but I don't think patch 35 (Dockerfile hexagon)
should enter mainstream that way. It probably makes sense to add
it along with the CI testing job (missing so far).
Patch 30 (Linux user emulation) could have an Acked-by from Laurent.
Also, while having TCG unit tests is great, it doesn't replace
integration tests using real world binaries. So personally I'd
like to be able to test an Hexagon BusyBox, ideally one coming
from the official Hexagon distribution (extracted from the SDK).
We talked about this and Brian will probably share it.
Whole series tested it on x86, so:
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
(I still plan to test it on big-endian host)
>>> I don't suppose you and Peter Maydell signed gpg keys when we all met in
>>> Lyon?
>>
>> Nope. Peter, please advise
>
> We effectively are operating a TOFU policy for gpg keys,
> ie put them on a public keyserver, to the extent that you can arrange
> to get them signed by other people who also have gpg keys please do,
> and at some point we may be able to meet up and get a shorter
> trust path.
>
> For this patchset, I would prefer it if Richard collected the patches
> and sent me a pullrequest. First pullrequests from new submaintainers
> are higher-effort for me, because I need to look them through carefully
> to be sure that they're the right format and so on; so I'd rather
> not do that with an enormous patchset. It's easier for me if that
> work is postponed and done with something smaller later.
Ahah I just suggested to Taylor to look at your previous explanation
before reading the same explanation here :)
https://www.mail-archive.com/qemu-devel@nongnu.org/msg765788.html
Regards,
Phil.
next prev parent reply other threads:[~2021-02-17 14:24 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 5:45 [PATCH v8 00/35] Hexagon patch series Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 01/35] Hexagon Update MAINTAINERS file Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 02/35] Hexagon (target/hexagon) README Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 03/35] Hexagon (include/elf.h) ELF machine definition Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 04/35] Hexagon (target/hexagon) scalar core definition Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 05/35] Hexagon (disas) disassembler Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 06/35] Hexagon (target/hexagon) register names Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 07/35] Hexagon (target/hexagon) scalar core helpers Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 08/35] Hexagon (target/hexagon) GDB Stub Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 09/35] Hexagon (target/hexagon) architecture types Taylor Simpson
2021-02-12 0:32 ` Philippe Mathieu-Daudé
2021-02-14 17:16 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 10/35] Hexagon (target/hexagon) instruction and packet types Taylor Simpson
2021-02-14 17:21 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 11/35] Hexagon (target/hexagon) register fields Taylor Simpson
2021-02-14 17:25 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 12/35] Hexagon (target/hexagon) instruction attributes Taylor Simpson
2021-02-14 18:00 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet decode Taylor Simpson
2021-02-14 18:31 ` Richard Henderson
2021-03-14 17:23 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 14/35] Hexagon (target/hexagon) instruction printing Taylor Simpson
2021-02-14 18:36 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions Taylor Simpson
2021-02-14 20:13 ` Richard Henderson
2021-03-18 3:57 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 16/35] Hexagon (target/hexagon/conv_emu.[ch]) " Taylor Simpson
2021-02-14 20:57 ` Richard Henderson
2021-03-18 3:57 ` Taylor Simpson
2021-03-18 13:30 ` Richard Henderson
2021-03-18 14:11 ` Taylor Simpson
2021-03-18 15:35 ` Richard Henderson
2021-03-18 18:03 ` Taylor Simpson
2021-03-18 18:32 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) " Taylor Simpson
2021-02-12 0:31 ` Philippe Mathieu-Daudé
2021-02-14 23:14 ` Richard Henderson
2021-03-18 3:57 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 18/35] Hexagon (target/hexagon/imported) arch import Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 19/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics Taylor Simpson
2021-02-14 23:18 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 20/35] Hexagon (target/hexagon) generator phase 2 - generate header files Taylor Simpson
2021-02-14 23:20 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree Taylor Simpson
2021-02-14 23:24 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 22/35] Hexagon (target/hexagon) generater phase 4 - " Taylor Simpson
2021-02-14 23:26 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 23/35] Hexagon (target/hexagon) opcode data structures Taylor Simpson
2021-02-12 0:26 ` Philippe Mathieu-Daudé
2021-02-14 23:27 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 24/35] Hexagon (target/hexagon) macros Taylor Simpson
2021-02-14 23:36 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes Taylor Simpson
2021-02-14 23:41 ` Richard Henderson
2021-03-14 0:39 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 26/35] Hexagon (target/hexagon) TCG generation Taylor Simpson
2021-02-12 0:22 ` Philippe Mathieu-Daudé
2021-04-05 23:03 ` Taylor Simpson
2021-04-06 9:20 ` Alex Bennée
2021-04-06 15:44 ` Taylor Simpson
2021-02-15 0:06 ` Richard Henderson
2021-03-14 0:39 ` Taylor Simpson
2021-03-14 1:39 ` Richard Henderson
2021-03-15 3:09 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 27/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions Taylor Simpson
2021-02-15 0:33 ` Richard Henderson
2021-03-14 0:41 ` Taylor Simpson
2021-03-14 18:02 ` Richard Henderson
2021-03-15 2:59 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 28/35] Hexagon (target/hexagon) TCG for floating point instructions Taylor Simpson
2021-02-15 0:34 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 29/35] Hexagon (target/hexagon) translation Taylor Simpson
2021-02-15 1:03 ` Richard Henderson
2021-03-14 0:40 ` Taylor Simpson
2021-03-14 1:44 ` Richard Henderson
2021-03-15 3:06 ` Taylor Simpson
2021-03-15 13:31 ` Richard Henderson
2021-03-15 22:19 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 30/35] Hexagon (linux-user/hexagon) Linux user emulation Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 31/35] Hexagon (tests/tcg/hexagon) TCG tests - multiarch Taylor Simpson
2021-02-14 18:14 ` Philippe Mathieu-Daudé
2021-02-15 1:05 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 32/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc Taylor Simpson
2021-02-15 1:09 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 33/35] Hexagon (tests/tcg/hexagon) TCG tests - floating point Taylor Simpson
2021-02-15 1:10 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 34/35] Hexagon build infrastructure Taylor Simpson
2021-02-15 1:11 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 35/35] Add Dockerfile for hexagon Taylor Simpson
2021-02-14 18:50 ` Philippe Mathieu-Daudé
2021-02-17 17:23 ` Alessandro Di Federico via
2021-02-17 17:33 ` Philippe Mathieu-Daudé
2021-02-27 14:10 ` Philippe Mathieu-Daudé
2021-02-27 14:32 ` Brian Cain
2021-02-08 6:25 ` [PATCH v8 00/35] Hexagon patch series no-reply
2021-02-15 1:23 ` Richard Henderson
2021-02-16 20:59 ` Taylor Simpson
2021-02-16 21:17 ` Peter Maydell
2021-02-17 14:23 ` Philippe Mathieu-Daudé [this message]
2021-02-17 17:05 ` Richard Henderson
2021-02-17 16:58 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba13b1e6-6689-fc3a-dd0d-2f2ff835c813@amsat.org \
--to=f4bug@amsat.org \
--cc=ale@rev.ng \
--cc=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.