From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Simek <michal.simek@xilinx.com>
Date: Thu, 29 Jan 2015 15:20:08 +0100
Subject: [U-Boot] [PATCH 12/14] microblaze: Move architecture to use
 generic board init
In-Reply-To: <CAPnjgZ2z-dyVbmASWVB_KQ2oEp2fRiXfFA1mKG9JD0fN+GjBQQ@mail.gmail.com>
References: <5f555553957f5f8b8939e6e3aaed1afa380403b8.1422372021.git.michal.simek@xilinx.com>
 <66b6cc3a89795e764cbfe0a96abcc614f8a248d1.1422372021.git.michal.simek@xilinx.com>
 <CAPnjgZ2z-dyVbmASWVB_KQ2oEp2fRiXfFA1mKG9JD0fN+GjBQQ@mail.gmail.com>
Message-ID: <ba1cf9794fe44024ac1b3fb3cc9c5e9d@BY2FFO11FD050.protection.gbl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On 01/29/2015 03:15 AM, Simon Glass wrote:
> Hi Michal,
> 
> On 27 January 2015 at 08:20, Michal Simek <michal.simek@xilinx.com> wrote:
>> Compile code with -fPIC to get GOT. Do not build SPL
>> with fPIC because it increasing SPL size for nothing.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>

...

>> -#if defined(CONFIG_MIPS) || defined(CONFIG_PPC)
>> +#if defined(CONFIG_MIPS) || defined(CONFIG_PPC) || defined(CONFIG_MICROBLAZE)
>>  static int init_func_ram(void)
>>  {
> 
> Can you use dram_init() instead?

No problem will do it in v2.

Where dram_init(void) should be declared?
I see that others have it in arch header. Maybe better to have
it in any shared location.

>> --- a/common/board_r.c
>> +++ b/common/board_r.c
>> @@ -829,7 +829,7 @@ init_fnc_t init_sequence_r[] = {
>>  #if defined(CONFIG_ARM)
>>         initr_enable_interrupts,
>>  #endif
>> -#ifdef CONFIG_X86
>> +#if defined(CONFIG_X86) || defined(CONFIG_MICROBLAZE)
>>         timer_init,             /* initialize timer */
>>  #endif
> 
> Could you use interrupt_init() immediately before?

What do you mean by that?
Do you want to do timer_init in interrupt_init()?

Thanks,
Michal