All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Meneghini <jmeneghi@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller
Date: Tue, 5 Apr 2022 11:09:56 -0400	[thread overview]
Message-ID: <ba2cce05-c7d5-b51a-a796-3223ef67aadc@redhat.com> (raw)
In-Reply-To: <20220405073121.GA25524@lst.de>

On 4/5/22 03:31, Christoph Hellwig wrote:
> 2) (optionally) make the well known discovery controller go away
> 
> Just renaming the subsystem will make the well known one go away,
> but while that can be useful for some use cases, I think making it
> always go away has the potential for breakage.  So maybe we need
> to not rename but be able to create an alias and have a way to
> disable the well known discovery controller if not used.

I agree. I think making the well known discovery controller "go away" will have huge problems in a multi-vendor fabric. We 
really can't touch the well known discovery controller because there are too many legacy and non-TP-8010 compliant NVMe hosts on 
the fabric.

We have to assume that both new and old implementations will coexist. And legacy hosts will NEVER look at the new, unique 
discovery NQN because they won't even recognize the new NVME_NQN_CURR log page entries.

/John



  parent reply	other threads:[~2022-04-05 15:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 14:26 [PATCHv2 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 14:26 ` [PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys() Hannes Reinecke
2022-04-05  5:45   ` Christoph Hellwig
2022-04-05  5:53     ` Hannes Reinecke
2022-04-05  6:07       ` Christoph Hellwig
2022-04-05 13:06       ` John Meneghini
2022-03-17 14:26 ` [PATCH 2/3] nvmet: make the subsystem type configurable Hannes Reinecke
2022-04-05  5:47   ` Christoph Hellwig
2022-04-05  6:00     ` Hannes Reinecke
2022-04-05  6:09       ` Christoph Hellwig
2022-04-05  6:29         ` Hannes Reinecke
2022-04-05 10:35           ` Sagi Grimberg
2022-04-05 11:12             ` Hannes Reinecke
2022-04-05 15:02               ` John Meneghini
2022-04-05 13:15         ` John Meneghini
2022-03-17 14:26 ` [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller Hannes Reinecke
2022-04-05  5:46   ` Christoph Hellwig
2022-04-05  6:15     ` Hannes Reinecke
2022-04-05  6:19       ` Christoph Hellwig
2022-04-05  6:35         ` Hannes Reinecke
2022-04-05  7:31           ` Christoph Hellwig
2022-04-05 10:32             ` Sagi Grimberg
2022-04-05 15:09             ` John Meneghini [this message]
2022-04-06 11:39               ` Hannes Reinecke
2022-04-05 10:41           ` Sagi Grimberg
2022-04-05 11:01             ` Hannes Reinecke
2022-04-05 14:22               ` Sagi Grimberg
  -- strict thread matches above, loose matches on Subject: below --
2022-03-17 13:18 [PATCH 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 13:18 ` [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba2cce05-c7d5-b51a-a796-3223ef67aadc@redhat.com \
    --to=jmeneghi@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.