From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers Date: Mon, 10 Apr 2017 10:04:21 +0000 Message-ID: References: <1491593753-1181-1-git-send-email-andrew.cooper3@citrix.com> <1491593753-1181-3-git-send-email-andrew.cooper3@citrix.com> <74130a5f06984e2291a43ab80c665c08@AMSPEX02CL03.citrite.net> <5751ace7-6fc1-0cb6-512c-4cc62e1ed3df@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5751ace7-6fc1-0cb6-512c-4cc62e1ed3df@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Julien Grall , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEFuZHJldyBDb29wZXIKPiBTZW50 OiAxMCBBcHJpbCAyMDE3IDEwOjU3Cj4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNp dHJpeC5jb20+OyBYZW4tZGV2ZWwgPHhlbi0KPiBkZXZlbEBsaXN0cy54ZW4ub3JnPgo+IENjOiBK YW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFs bEBhcm0uY29tPgo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjUgZm9yLTQuOSAzLzRdIGh2bS9kbW9w OiBJbXBsZW1lbnQKPiBjb3B5X3t0byxmcm9tfV9ndWVzdF9idWZfb2Zmc2V0KCkgaGVscGVycwo+ IAo+IE9uIDEwLzA0LzE3IDEwOjUyLCBQYXVsIER1cnJhbnQgd3JvdGU6Cj4gPj4gLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0KPiA+PiBGcm9tOiBBbmRyZXcgQ29vcGVyCj4gPj4gU2VudDogMTAg QXByaWwgMjAxNyAxMDozNgo+ID4+IFRvOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRy aXguY29tPjsgWGVuLWRldmVsIDx4ZW4tCj4gPj4gZGV2ZWxAbGlzdHMueGVuLm9yZz4KPiA+PiBD YzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW4u Z3JhbGxAYXJtLmNvbT4KPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIHY1IGZvci00LjkgMy80XSBo dm0vZG1vcDogSW1wbGVtZW50Cj4gPj4gY29weV97dG8sZnJvbX1fZ3Vlc3RfYnVmX29mZnNldCgp IGhlbHBlcnMKPiA+Pgo+ID4+IE9uIDEwLzA0LzE3IDEwOjExLCBQYXVsIER1cnJhbnQgd3JvdGU6 Cj4gPj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4+Pj4gRnJvbTogQW5kcmV3IENv b3BlciBbbWFpbHRvOmFuZHJldy5jb29wZXIzQGNpdHJpeC5jb21dCj4gPj4+PiBTZW50OiAwNyBB cHJpbCAyMDE3IDIwOjM2Cj4gPj4+PiBUbzogWGVuLWRldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVu Lm9yZz4KPiA+Pj4+IENjOiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29t PjsgSmFuIEJldWxpY2gKPiA+Pj4+IDxKQmV1bGljaEBzdXNlLmNvbT47IFBhdWwgRHVycmFudCA8 UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyBKdWxpZW4KPiA+PiBHcmFsbAo+ID4+Pj4gPGp1bGll bi5ncmFsbEBhcm0uY29tPgo+ID4+Pj4gU3ViamVjdDogW1BBVENIIHY1IGZvci00LjkgMy80XSBo dm0vZG1vcDogSW1wbGVtZW50Cj4gPj4+PiBjb3B5X3t0byxmcm9tfV9ndWVzdF9idWZfb2Zmc2V0 KCkgaGVscGVycwo+ID4+Pj4KPiA+Pj4+IGNvcHlfe3RvLGZyb219X2d1ZXN0X2J1ZigpIGFyZSBu b3cgaW1wbGVtZW50ZWQgdXNpbmcgYW4gb2Zmc2V0IG9mCj4gMC4KPiA+Pj4+Cj4gPj4+PiBTaWdu ZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+ID4+ Pj4gLS0tCj4gPj4+PiBDQzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+ID4+Pj4g Q0M6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cj4gPj4+PiBDQzogSnVs aWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4gIHhlbi9h cmNoL3g4Ni9odm0vZG0uYyB8IDM0ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0K PiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p Cj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vZG0uYyBiL3hlbi9h cmNoL3g4Ni9odm0vZG0uYwo+ID4+Pj4gaW5kZXggM2Q4YWU4OS4uZDU4NGFiYSAxMDA2NDQKPiA+ Pj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vZG0uYwo+ID4+Pj4gKysrIGIveGVuL2FyY2gveDg2 L2h2bS9kbS5jCj4gPj4+PiBAQCAtMzcsOSArMzcsOSBAQCBzdHJ1Y3QgZG1vcF9idWZzIHsKPiA+ Pj4+ICAjdW5kZWYgTUFYX05SX0JVRlMKPiA+Pj4+ICB9Owo+ID4+Pj4KPiA+Pj4+IC1zdGF0aWMg Ym9vbCBfcmF3X2NvcHlfZnJvbV9ndWVzdF9idWYoCj4gPj4+PiArc3RhdGljIGJvb2wgX3Jhd19j b3B5X2Zyb21fZ3Vlc3RfYnVmX29mZnNldCgKPiA+Pj4+ICAgICAgY29uc3Qgc3RydWN0IGRtb3Bf YnVmcyAqYnVmcywgdW5zaWduZWQgaW50IGlkeCwKPiA+Pj4+IC0gICAgdm9pZCAqZHN0LCBzaXpl X3QgZHN0X2J5dGVzKQo+ID4+Pj4gKyAgICBzaXplX3Qgb2Zmc2V0X2J5dGVzLCB2b2lkICpkc3Qs IHNpemVfdCBkc3RfYnl0ZXMpCj4gPj4+PiAgewo+ID4+Pj4gICAgICBzaXplX3QgYnVmX2J5dGVz Owo+ID4+Pj4KPiA+Pj4+IEBAIC00OCwxNyArNDgsMjAgQEAgc3RhdGljIGJvb2wgX3Jhd19jb3B5 X2Zyb21fZ3Vlc3RfYnVmKAo+ID4+Pj4KPiA+Pj4+ICAgICAgYnVmX2J5dGVzID0gYnVmcy0+YnVm W2lkeF0uc2l6ZTsKPiA+Pj4+Cj4gPj4+PiAtICAgIGlmICggZHN0X2J5dGVzID4gYnVmX2J5dGVz ICkKPiA+Pj4+ICsgICAgaWYgKCBvZmZzZXRfYnl0ZXMgPj0gZHN0X2J5dGVzIHx8Cj4gPj4+PiAr ICAgICAgICAgKG9mZnNldF9ieXRlcyArIGRzdF9ieXRlcykgPCBvZmZzZXRfYnl0ZXMgfHwKPiA+ Pj4+ICsgICAgICAgICAob2Zmc2V0X2J5dGVzICsgZHN0X2J5dGVzKSA+IGRzdF9ieXRlcyApCj4g Pj4+PiAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPj4+Pgo+ID4+Pj4gICAgICBtZW1zZXQoZHN0 LCAwLCBkc3RfYnl0ZXMpOwo+ID4+Pj4KPiA+Pj4+IC0gICAgcmV0dXJuICFjb3B5X2Zyb21fZ3Vl c3QoZHN0LCBidWZzLT5idWZbaWR4XS5oLCBkc3RfYnl0ZXMpOwo+ID4+Pj4gKyAgICByZXR1cm4g IWNvcHlfZnJvbV9ndWVzdF9vZmZzZXQoZHN0LCBidWZzLT5idWZbaWR4XS5oLAo+ID4+Pj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb2Zmc2V0X2J5dGVzLCBkc3RfYnl0ZXMp Owo+ID4+PiBOb3Qgc3VyZSB3aGF0J3MgZ29pbmcgb24gaGVyZS4gJ2J1Zl9ieXRlcycgaXMgYmVp bmcgYXNzaWduZWQgYnV0IG5vCj4gbG9uZ2VyCj4gPj4gc2VlbXMgdG8gYmUgdXNlZCAoc2luY2Ug aXQncyBkcm9wcGVkIGZyb20gdGhlIGlmIHN0YXRlbWVudCkuIEFsc28sIEknbSBub3QKPiA+PiBl bnRpcmVseSBzdXJlIHdoYXQgcmFuZ2UgY2hlY2sgdGhhdCBpZiBzdGF0ZW1lbnQgaXMgdHJ5aW5n IHRvIHBlcmZvcm0uIENhbgo+IHdlCj4gPj4gYXQgbGVhc3QgaGF2ZSBhIGNvbW1lbnQgaXQgaXQn cyBhY3R1YWxseSBjb3JyZWN0ICh3aGljaCBJJ20gbm90IGF0IGFsbAo+IGNvbnZpbmNlZAo+ID4+ IG9mKS4KPiA+Pgo+ID4+IFRoYXQgaXMgYWN0dWFsbHkgYmVjYXVzZSB0aGUgaWYgc3RhdGVtZW50 IGlzbid0IGNvcnJlY3QuICBUaGUgZmluYWwKPiA+PiBjb21wYXJpc29uIHNob3VsZCBiZSBhZ2Fp bnN0IGJ1Zl9ieXRlcywgbm90IGRzdF9ieXRlcy4KPiA+IE9rLCB0aGF0IG1ha2VzIG1vcmUgc2Vu c2UuLi4gc28gdGhlIGZpcnN0IGNsYXVzZSBpcyBjaGVja2luZyBmb3Igc2l6ZV90Cj4gb3ZlcmZs b3csIHJpZ2h0Pwo+IAo+IFRoZSBmaXJzdCBpcyBhIHN0cmFpZ2h0ICJpcyB0aGUgb2Zmc2V0IG9m ZiB0aGUgZW5kIG9mIHRoZSBidWZmZXIiLCB0aGUKPiBtaWRkbGUgaXMgYSBzaXplX3Qgb3ZlcmZs b3cgY2hlY2sgKHRoaXMgaXMgZGVmaW5lZCBiZWhhdmlvdXIgYXMgc2l6ZV90Cj4gaXMgdW5zaWdu ZWQuICBJdCB3b3VsZCBiZSBVQiBpZiBzaXplX3Qgd2FzIHNpZ25lZCksIGFuZCB0aGUgZmluYWwg d2FzCj4gc3VwcG9zZWQgdG8gYmUgIihvZmZzZXRfYnl0ZXMgKyBkc3RfYnl0ZXMpID4gYnVmX2J5 dGVzIiB0byBjaGVjayB3aGV0aGVyCj4gdGhlIGVudGlyZSByZWdpb24gd2FudGluZyBjb3B5aW5n IHJlc2lkZXMgaW5zaWRlIHRoZSBidWZmZXIuCj4gCgpTb3JyeSwgSSBtZWFudCB0aGUgbWlkZGxl IGNsYXVzZSwgc28gd2l0aCB0aGUgZml4IHRoYXQgYWxsIG1ha2VzIHNlbnNlIG5vdy4KCj4gPgo+ ID4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgY29weV9mcm9tX2d1ZXN0X29mZnNldCgpIHRha2VzIG9m ZnNldCBpbiB1bml0cyBvZgo+ID4+IHNpemVvZih0eXBlb2YoKmJ1ZnMtPmJ1ZltpZHhdLmgpKSAo d2hpY2ggaW4gdGhpcyBjYXNlIGlzIGJ5dGVzLCB1bnRpbAo+ID4+IHRoZSB0eXBlIG9mIGJ1Zi5o IGNoYW5nZXMpLCB3aGlsZSBuciBpcyBzdHJpY3RseSBpbiBieXRlcy4gIE15Cj4gPj4gY29uY2x1 c2lvbiBhZnRlciBGcmlkYXkncyBoYWNraW5nIGlzIHRoYXQgdGhpcyBpcyBhbHNvIGEgcmVjaXBl Cj4gPj4gc2VjdXJpdHktcmVsZXZhbnQgbWlzdGFrZXMsIGFuZCBpcyBmaWVuZGlzaGx5IGNvbXBs aWNhdGVkIHRvIHJlYXNvbiBhYm91dC4KPiA+IEFueXRoaW5nIHVzaW5nIHR5cGVvZigpIGlzIGEg UElUQSB0byByZWFzb24gYWJvdXQgSU1PLCBzbyB1c2luZyB0aGUgb2Zmc2V0Cj4gdmFyaWFudCBp cyBkZWZpbml0ZWx5IGdvaW5nIHRvIGJlIGFuIGltcHJvdmVtZW50Lgo+IAo+IEknbSBtdWxsaW5n IG92ZXIgcmV3cml0aW5nIGl0IGFsbCwgYmVjYXVzZSBpdCBpcyBzdGFydGluZyB0byBnZXQKPiBl bWJhcnJhc3NpbmcgaG93IG1hbnkgc2VjdXJpdHkgaXNzdWVzIHdlIGhhdmUgaW4gdGhlIGV4aXN0 aW5nCj4gaW5mcmFzdHJ1Y3R1cmUuCj4gCgpDZXJ0YWlubHkgcmVtb3Zpbmcgc29tZSBvZiB0aGUg bWFjcm90aXphdGlvbiB3b3VsZCBtYWtlIGl0IGVhc2llciB0byBmb2xsb3cgYW5kLCBpZiBjb3B5 X2Zyb21fZ3Vlc3QoKSBpcyBnb2luZyB0byB1c2UgdHlwZW9mIChmb3IgY29udmVuaWVuY2Ugb2Yg Y29weWluZyBhbiBvcCBzdHJ1Y3QgaW4gdGhlIGNvbW1vbiBjYXNlIEkgZ3Vlc3MpIHRoZW4gaXQg cmVhbGx5IHNob3VsZCBiZSBzaW5nbGUgaW5zdGFuY2UgZm9yIHNhZmV0eSwgb3IgcHJlZmVyYWJs eSB0YWtlIGFuIGV4cGxpY2l0IHR5cGUuCgogIFBhdWwKCj4gfkFuZHJldwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs Cg==