From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390D7C433B4 for ; Fri, 30 Apr 2021 09:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 163D2613D8 for ; Fri, 30 Apr 2021 09:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbhD3JH1 (ORCPT ); Fri, 30 Apr 2021 05:07:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54011 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbhD3JH0 (ORCPT ); Fri, 30 Apr 2021 05:07:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619773598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RHj3aPSNlnR+e/0iWYEPIjVJ3UrGKFYzhAQvYOuwStw=; b=bV1hHm1nu2U2p7UhK1mr8X9e7FEb4pdF8Rui6749Zxy3wK4jsgG4NR1F0zpAFRfnsYEjmA BzFTKpg8xonZ92YeiU/NDGfO2mHjb+oaN0n6X0PEZeL2D3dHYQhEzZmtsX0nIj5+07qVZ9 x3RZAfVrkHYy9ZGGmkVyudfDQd9cGoc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-6fv3LmgdNHaSPMBrjWqpdw-1; Fri, 30 Apr 2021 05:06:35 -0400 X-MC-Unique: 6fv3LmgdNHaSPMBrjWqpdw-1 Received: by mail-ed1-f70.google.com with SMTP id v5-20020a0564023485b029037ff13253bcso29977679edc.3 for ; Fri, 30 Apr 2021 02:06:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RHj3aPSNlnR+e/0iWYEPIjVJ3UrGKFYzhAQvYOuwStw=; b=JaKFkVW9XYN5zr7jaKDd2gusgacrRcD1Xbh5W4F5oYb+CictX7+ZOnY64uJR+mQDCj zq8tj+UW/4RHc3SjSL5EBBLBuwHqiV48S4UJZ3hPLGZoXn103VKv2gSmeYFpFsyN26QV D0s68tp6U35GZNavKhcIOFMPIDmL7smpDDorbvOBo5fxB7rbAE0J/EHwvRo2C6EOTHaS UyK19nav6rSSzWfIM1zrWlBiq0mKWmvkprbYGK6/2XWdalO0Ft7t2Saj/isUQraYxyTH t/+AYxZmTqI9PX3GyaIY7ffAtaeIviIeoLxaGR7h1R4oh558iO6WyK6iufTzXbMNkOvj gwPw== X-Gm-Message-State: AOAM532WT5hfzZbI/vAz+3CNLRQM/JFLIXMDVGdUE1FCrYIB1mvU3l92 yeXUwYzNRgO0X19F5EpJItizR8vDns5nr1GRdeTPTMd7KPdRfIaC1+HDFRYn7S3VNrkXTmIa/6Z GAl9p9HD5WU4IW48Dj4SAaQtr X-Received: by 2002:a17:906:d7a6:: with SMTP id pk6mr3163127ejb.118.1619773594716; Fri, 30 Apr 2021 02:06:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtG83XWilui4ZuscSx08I+jXgXF0/RCmbV8LwAJ1PdCF0RybYjpi+E/Tvo0xdY5zHVXHdDFw== X-Received: by 2002:a17:906:d7a6:: with SMTP id pk6mr3163103ejb.118.1619773594523; Fri, 30 Apr 2021 02:06:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id z12sm786035edr.17.2021.04.30.02.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 02:06:33 -0700 (PDT) Subject: Re: [PATCH 4/4] KVM/VMX: Fold handle_interrupt_nmi_irqoff() into its solo caller To: Thomas Gleixner , Lai Jiangshan , linux-kernel@vger.kernel.org Cc: Lai Jiangshan , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org References: <20210426230949.3561-1-jiangshanlai@gmail.com> <20210426230949.3561-5-jiangshanlai@gmail.com> <87y2d0du02.ffs@nanos.tec.linutronix.de> From: Paolo Bonzini Message-ID: Date: Fri, 30 Apr 2021 11:06:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <87y2d0du02.ffs@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/21 11:03, Thomas Gleixner wrote: > Lai, > > On Tue, Apr 27 2021 at 07:09, Lai Jiangshan wrote: >> u32 intr_info = vmx_get_intr_info(&vmx->vcpu); >> @@ -6427,12 +6417,19 @@ static void handle_exception_nmi_irqoff(struct vcpu_vmx *vmx) >> static void handle_external_interrupt_irqoff(struct kvm_vcpu *vcpu) >> { >> u32 intr_info = vmx_get_intr_info(vcpu); >> + unsigned int vector; >> + gate_desc *desc; >> >> if (WARN_ONCE(!is_external_intr(intr_info), >> "KVM: unexpected VM-Exit interrupt info: 0x%x", intr_info)) >> return; >> >> - handle_interrupt_nmi_irqoff(vcpu, intr_info); >> + vector = intr_info & INTR_INFO_VECTOR_MASK; >> + desc = (gate_desc *)host_idt_base + vector; >> + >> + kvm_before_interrupt(vcpu); >> + vmx_do_interrupt_nmi_irqoff(gate_offset(desc)); >> + kvm_after_interrupt(vcpu); > > So the previous patch does: > > + kvm_before_interrupt(&vmx->vcpu); > + vmx_do_interrupt_nmi_irqoff((unsigned long)asm_noist_exc_nmi); > + kvm_after_interrupt(&vmx->vcpu); > > What is this idt gate descriptor dance for in this code? NMIs are sent through a different vmexit code (the same one as exceptions). This one is for interrupts. Paolo