From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33155C433E2 for ; Wed, 31 Mar 2021 07:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12AFB619CD for ; Wed, 31 Mar 2021 07:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234295AbhCaHw4 (ORCPT ); Wed, 31 Mar 2021 03:52:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52919 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234238AbhCaHwi (ORCPT ); Wed, 31 Mar 2021 03:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617177158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQ5Qm7wzrETleGdIZygb6hZggBdQLM72Jyc7tGd4rCA=; b=Pb3MkZ12nIe29/GyrQ+y0lVTcOrMgo2tE3vlLkV3c/ihfKSnePv8774ZAXxRdPr+7GnsGf XXadNkkv7SvdOV27vfK5ejdf/j7kaA8JH+L3uvlDRhCIbMxUVrsifa3/b/U8i6x4G0WdGe YbljWw7v2BsVSyCfU5+LH/r2sHrkPs8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-pyD-jcyzM3qtVY0zYI8iwA-1; Wed, 31 Mar 2021 03:52:36 -0400 X-MC-Unique: pyD-jcyzM3qtVY0zYI8iwA-1 Received: by mail-wr1-f72.google.com with SMTP id n16so570522wro.1 for ; Wed, 31 Mar 2021 00:52:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pQ5Qm7wzrETleGdIZygb6hZggBdQLM72Jyc7tGd4rCA=; b=E8ur/uXIbhQrGlhZ1EOLHHKSvylU8ZqdhAZ9cVFOYTXaJnZkYXkXg6n3joUWEvf26o 9WM8nqivRn12YkD0B0oSMoYQWe+2+GwFWB+uu7Z3THGC5WfM9Afp7HkPgr7QHFC4zWZF gsqKJVmuQ9j9EJQKkuCJJSgoIYtoyKCFVKVZi4HQdZ8tr8mdntOnLdj+g2leknrr7t80 D/B8MP8O684hgDri2mKBBvo5TrCR6Tu9UW0eiAzeaeRCHqJV3yoQuZLvLqiHjZ307UkA ItduBYl5RuDrJP1LD21xfWbYWYMle4UH0DDwxkle+AYTHZv79k7I2fof/vUaoFcBd/8W 6gFg== X-Gm-Message-State: AOAM533A6FtbWeBgZZ5pL5LT4evgmy/QF3ThSrmEi+/RH1GMnGjyw0UO TIwF3wGnu0PTegw/ua2SJsGM6v7VKRrhDiD/FpKSck7aVMR8eK31XED9jvNLkZW1EpDaFrZQzvW 7TafUYTq/OCkMxVeAezOl4QBv X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr1947753wmg.21.1617177155319; Wed, 31 Mar 2021 00:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrEJ16pEEpfSd4UOjbnqA+7pbiSAPPFNpTAPEwcpv0H2fU5p4zyKOS02szcKvl3Y4jdrVOKQ== X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr1947732wmg.21.1617177155168; Wed, 31 Mar 2021 00:52:35 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id b17sm2793386wrt.17.2021.03.31.00.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 00:52:33 -0700 (PDT) To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras Cc: James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-11-seanjc@google.com> From: Paolo Bonzini Subject: Re: [PATCH 10/18] KVM: Move x86's MMU notifier memslot walkers to generic code Message-ID: Date: Wed, 31 Mar 2021 09:52:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210326021957.1424875-11-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/03/21 03:19, Sean Christopherson wrote: > +#ifdef KVM_ARCH_WANT_NEW_MMU_NOTIFIER_APIS > + kvm_handle_hva_range(mn, address, address + 1, pte, kvm_set_spte_gfn); > +#else > struct kvm *kvm = mmu_notifier_to_kvm(mn); > int idx; > trace_kvm_set_spte_hva(address); > > idx = srcu_read_lock(&kvm->srcu); > > KVM_MMU_LOCK(kvm); > > kvm->mmu_notifier_seq++; > > if (kvm_set_spte_hva(kvm, address, pte)) > kvm_flush_remote_tlbs(kvm); > > KVM_MMU_UNLOCK(kvm); > srcu_read_unlock(&kvm->srcu, idx); > +#endif The kvm->mmu_notifier_seq is missing in the new API side. I guess you can add an argument to __kvm_handle_hva_range and handle it also in patch 15 ("KVM: Take mmu_lock when handling MMU notifier iff the hva hits a memslot"). Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC26C433DB for ; Wed, 31 Mar 2021 07:52:44 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C37D2619B1 for ; Wed, 31 Mar 2021 07:52:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C37D2619B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4FE5B4B3E1; Wed, 31 Mar 2021 03:52:43 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b6qG-7hkQYzz; Wed, 31 Mar 2021 03:52:42 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5B7074B3DF; Wed, 31 Mar 2021 03:52:42 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2FD734B3DE for ; Wed, 31 Mar 2021 03:52:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GnXreI1wVLkq for ; Wed, 31 Mar 2021 03:52:40 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7217C4B3A3 for ; Wed, 31 Mar 2021 03:52:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617177160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQ5Qm7wzrETleGdIZygb6hZggBdQLM72Jyc7tGd4rCA=; b=WeAfK3/0BPmYKVJzOBZc1MirCbQgkSZlqG/MGGdMuuWg/jjyZeDZ2h1gbkvYkbatFoceHb YgrP2GAkhCgJEoF0jsDjPcUQWyGGlCFAfc14rW+g50jPS3ysy/IO2Ok+eBkRLZHV7W9diA WQniSByBaj9c2sMaeSZWlczHqtF//A4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-HgbG0u_XNKmWuiL0oszxGw-1; Wed, 31 Mar 2021 03:52:36 -0400 X-MC-Unique: HgbG0u_XNKmWuiL0oszxGw-1 Received: by mail-wr1-f70.google.com with SMTP id m23so563150wrh.7 for ; Wed, 31 Mar 2021 00:52:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pQ5Qm7wzrETleGdIZygb6hZggBdQLM72Jyc7tGd4rCA=; b=XhgAkeKRA2YzI0QX8pbcvzEedbZZGD3lmrXPQMDuBO2ZFpPYPlbcnSrYGNCVNlfQet GBIE46ypVloGES1T2JvFXY8NIj9jUlktkLsPuBSZawPIPD4S+eD1dvYbJtoaG9+tSLSQ so2Bx00fbns2Ps+tlQhY+AqOd6deFcL+NDEPWUXrJLKyqlBwZYfhzwegz1FzlhmWY4n8 8nliAUqBgkPulDklw6FlUPJz+Susua87vlj00rf0eGuRJGyBIWYS+Ud+4A+XJxZe5UEi NB4O+JGhHrSSaJk7dRXoY/xYvT/lKTOfha3dy8yVqq/ZNFqFttVsACwjKT4XokfLl3fy y26g== X-Gm-Message-State: AOAM531bkayYqnVVpWdmTOniY96M9yV3LMokczNKLPC2/YJreuGWISRK Q9/r7MKnoqHTG74kT7Bi+G/cz7z3buq9vjaQ3Oz6S2ai6RDhd3d8Jizwr4gP5l/1DtFZTfAL5MS 5uDpAlq8Z28LjwwPCquXX6nhr X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr1947762wmg.21.1617177155372; Wed, 31 Mar 2021 00:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrEJ16pEEpfSd4UOjbnqA+7pbiSAPPFNpTAPEwcpv0H2fU5p4zyKOS02szcKvl3Y4jdrVOKQ== X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr1947732wmg.21.1617177155168; Wed, 31 Mar 2021 00:52:35 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id b17sm2793386wrt.17.2021.03.31.00.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 00:52:33 -0700 (PDT) To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-11-seanjc@google.com> From: Paolo Bonzini Subject: Re: [PATCH 10/18] KVM: Move x86's MMU notifier memslot walkers to generic code Message-ID: Date: Wed, 31 Mar 2021 09:52:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210326021957.1424875-11-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, Joerg Roedel , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ben Gardon , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 26/03/21 03:19, Sean Christopherson wrote: > +#ifdef KVM_ARCH_WANT_NEW_MMU_NOTIFIER_APIS > + kvm_handle_hva_range(mn, address, address + 1, pte, kvm_set_spte_gfn); > +#else > struct kvm *kvm = mmu_notifier_to_kvm(mn); > int idx; > trace_kvm_set_spte_hva(address); > > idx = srcu_read_lock(&kvm->srcu); > > KVM_MMU_LOCK(kvm); > > kvm->mmu_notifier_seq++; > > if (kvm_set_spte_hva(kvm, address, pte)) > kvm_flush_remote_tlbs(kvm); > > KVM_MMU_UNLOCK(kvm); > srcu_read_unlock(&kvm->srcu, idx); > +#endif The kvm->mmu_notifier_seq is missing in the new API side. I guess you can add an argument to __kvm_handle_hva_range and handle it also in patch 15 ("KVM: Take mmu_lock when handling MMU notifier iff the hva hits a memslot"). Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB5AEC433DB for ; Wed, 31 Mar 2021 07:54:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36EEB61582 for ; Wed, 31 Mar 2021 07:54:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36EEB61582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:Cc:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E6F/JAVlWV3TIlnxX1Y6/DfxVmP+8P+PLxWtf7flIl8=; b=G0NN0ZkuK5AZLqYMdApWNdbih a/Q0MyY1SOE+82kgNdl+qVtxuAecuE2oVZsud+NHkpulBFMGP/6aZyItfE4jdTbWBZmrHYAKpPLQx fda1b5ltM2OUSaPdcSeiq5Nm1eNHGeAcwKKcER4x2epJaLzUbCQterRbXjdFSKzDOBbnUf9XipcI1 XShuxy7qhkzyMmPaaUj//goRYbv5ewg63dsTh7OTHgVrN3sK0LZAwS0htxlhdmIgzkHrVDz/ov6/+ L5SgBPdsVrDYt4DgrorjkCOaFyYqJkRJBUmkj5tINhoPqzt2nxBJ9q+6+hGfXyflJcnhLLUPjnhiC 7qwJ/Jn8g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRVej-005rQb-Pi; Wed, 31 Mar 2021 07:52:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRVeZ-005rP0-Lp for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 07:52:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617177158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQ5Qm7wzrETleGdIZygb6hZggBdQLM72Jyc7tGd4rCA=; b=Pb3MkZ12nIe29/GyrQ+y0lVTcOrMgo2tE3vlLkV3c/ihfKSnePv8774ZAXxRdPr+7GnsGf XXadNkkv7SvdOV27vfK5ejdf/j7kaA8JH+L3uvlDRhCIbMxUVrsifa3/b/U8i6x4G0WdGe YbljWw7v2BsVSyCfU5+LH/r2sHrkPs8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-4syMDsoZNOCOH70d5J9T2w-1; Wed, 31 Mar 2021 03:52:36 -0400 X-MC-Unique: 4syMDsoZNOCOH70d5J9T2w-1 Received: by mail-wr1-f69.google.com with SMTP id m13so558681wri.16 for ; Wed, 31 Mar 2021 00:52:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pQ5Qm7wzrETleGdIZygb6hZggBdQLM72Jyc7tGd4rCA=; b=IHGrLQnQnrNI13PtoFVl6wmoCtym25Q0O6d1A1VuvbnnkmwM08Fd/A90BHCjFhgbbS PSs6F9wAZXKDwrijtk7OKCBRVmu1led+OKKdgymHQ2zWwVsynmVnTG8BdJhZW1RBvTwJ 6+nnQL0FBvXjJ3XA0Kw0c1tUx96MdkltbXI0Ylj5DW6TeM2+9LPdSNe3uYz4mVkT8tMS rKQIRDnIllyTMsXDysTUjKWQ46GDx308m+koDRWZ/Z9EYKpwYXFM42t0kkbRPXBK4cGx IiSyYKhdMC4qeUC6LhiJXVQFOkc2RBE/u8MN3AmK1GR0AdxoqGu+/KRLb7Jhqvq47e+8 9EuA== X-Gm-Message-State: AOAM5320beTXn+BDJiGVP/gHgN1RRk69qyDsSk+EjZyNhH78pjBr6U8J wHPD9UTuHax6JMWwMzUC5g9oxqmZrqsVrYdjSE847H5eJO+5duSBx7v5IXRAD76COaAm7Cpfd1r eT1xZGP3J45ElnJkGxjcdvcJBMrq4a2LGtb8= X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr1947747wmg.21.1617177155318; Wed, 31 Mar 2021 00:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrEJ16pEEpfSd4UOjbnqA+7pbiSAPPFNpTAPEwcpv0H2fU5p4zyKOS02szcKvl3Y4jdrVOKQ== X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr1947732wmg.21.1617177155168; Wed, 31 Mar 2021 00:52:35 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id b17sm2793386wrt.17.2021.03.31.00.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 00:52:33 -0700 (PDT) To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras Cc: James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-11-seanjc@google.com> From: Paolo Bonzini Subject: Re: [PATCH 10/18] KVM: Move x86's MMU notifier memslot walkers to generic code Message-ID: Date: Wed, 31 Mar 2021 09:52:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210326021957.1424875-11-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_085241_388127_4A74352D X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/03/21 03:19, Sean Christopherson wrote: > +#ifdef KVM_ARCH_WANT_NEW_MMU_NOTIFIER_APIS > + kvm_handle_hva_range(mn, address, address + 1, pte, kvm_set_spte_gfn); > +#else > struct kvm *kvm = mmu_notifier_to_kvm(mn); > int idx; > trace_kvm_set_spte_hva(address); > > idx = srcu_read_lock(&kvm->srcu); > > KVM_MMU_LOCK(kvm); > > kvm->mmu_notifier_seq++; > > if (kvm_set_spte_hva(kvm, address, pte)) > kvm_flush_remote_tlbs(kvm); > > KVM_MMU_UNLOCK(kvm); > srcu_read_unlock(&kvm->srcu, idx); > +#endif The kvm->mmu_notifier_seq is missing in the new API side. I guess you can add an argument to __kvm_handle_hva_range and handle it also in patch 15 ("KVM: Take mmu_lock when handling MMU notifier iff the hva hits a memslot"). Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Wed, 31 Mar 2021 07:52:30 +0000 Subject: Re: [PATCH 10/18] KVM: Move x86's MMU notifier memslot walkers to generic code Message-Id: List-Id: References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-11-seanjc@google.com> In-Reply-To: <20210326021957.1424875-11-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras Cc: James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon On 26/03/21 03:19, Sean Christopherson wrote: > +#ifdef KVM_ARCH_WANT_NEW_MMU_NOTIFIER_APIS > + kvm_handle_hva_range(mn, address, address + 1, pte, kvm_set_spte_gfn); > +#else > struct kvm *kvm = mmu_notifier_to_kvm(mn); > int idx; > trace_kvm_set_spte_hva(address); > > idx = srcu_read_lock(&kvm->srcu); > > KVM_MMU_LOCK(kvm); > > kvm->mmu_notifier_seq++; > > if (kvm_set_spte_hva(kvm, address, pte)) > kvm_flush_remote_tlbs(kvm); > > KVM_MMU_UNLOCK(kvm); > srcu_read_unlock(&kvm->srcu, idx); > +#endif The kvm->mmu_notifier_seq is missing in the new API side. I guess you can add an argument to __kvm_handle_hva_range and handle it also in patch 15 ("KVM: Take mmu_lock when handling MMU notifier iff the hva hits a memslot"). Paolo