From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA226C6FA82 for ; Wed, 21 Sep 2022 16:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232226AbiIUQBK (ORCPT ); Wed, 21 Sep 2022 12:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232250AbiIUP6u (ORCPT ); Wed, 21 Sep 2022 11:58:50 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10EF1A0616 for ; Wed, 21 Sep 2022 08:52:33 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id h3so7576136lja.1 for ; Wed, 21 Sep 2022 08:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=5OG5SisV8+7i2AMwo/Sd4BMGPY2tVr/jGlwWZADlTZw=; b=WxcWk76UCtI4moz+JlBbxvyDthZlRKJfHZICdSLfKoRbEnWODyIrJmNReWY/ekETj5 9Y5sxyo4j7/FuchDzZQ+JSgCTleMmfip2kury4TROdHIbQ4tF6kdJ3g9QYOYv7I+XoBU W3LnjqR58xXJtXng2rQXzYX99EoFskQKaqC4vGmXjTreX9wFhY9J3ZYnuOLUQH7klHm7 jNSFDJpDpS4OQDSjYlwhBWtuqn1k0Y8LE6lbE1ywlJtushBY2Y6v2/KNSdpoT5UEMWjL VqsBkm+bupHhHMlHdZkQifb3B2iMi3xTTQQd6k276xQap8PzSQl8IJjoPP7ToOqQqOYr bHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=5OG5SisV8+7i2AMwo/Sd4BMGPY2tVr/jGlwWZADlTZw=; b=x3fWH4sAAAsLZXwE531E+XdcHj27hgYthwaj1rfmpjQKIbD4sckf8EDHcRhtu+UsGs jJYF1E3SOY0xJZVLQsrO4jXGgj7DlsjDRY2Dl1loMld/yk5iP4wkSxo8bbJ+2QuCRy/E VH4QXLe3oO0OqV2TbVNxjLLsNZ/B+02QmnsY0bQKU44f4HnNEQkWyfPkV6F/WdEZ66Ez RHQ8nC0NypOm2ZPOJTGyBaHw2lIcbVgqguKR2D9q3AHyC6/jBbhMIH0Bb3htCDrD+2dR HQ5gqLg/kD+pmfMY1JiVH23klKiAV10EnAMZKmcAhce4BLRxwNSzZMYABDm2XQzJ/cgq 2ZJw== X-Gm-Message-State: ACrzQf3qX+6RoHO4NOoVzi+dVsm/IX0X2/HwwQyuzhnLu6TG/nhtOp0u LbJ7SYZ67M1/b081tUfxg0cXBw== X-Google-Smtp-Source: AMsMyM7DOE0+aiBvnN7Btb1HXRYL1PZdW1uo8lmQH74Kpe8qQiE0hinGQyDTL65vVZvYXcN09FeVPg== X-Received: by 2002:a2e:2f03:0:b0:261:cb0e:c329 with SMTP id v3-20020a2e2f03000000b00261cb0ec329mr8602752ljv.106.1663775490874; Wed, 21 Sep 2022 08:51:30 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o4-20020a198c04000000b0049f54a976efsm492085lfd.29.2022.09.21.08.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 08:51:30 -0700 (PDT) Message-ID: Date: Wed, 21 Sep 2022 17:51:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/4] media: dt-bindings: Document Renesas RZ/G2L CRU block Content-Language: en-US To: Laurent Pinchart Cc: Lad Prabhakar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Jacopo Mondi , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Sakari Ailus , Hans Verkuil , Geert Uytterhoeven , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das References: <20220905230406.30801-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220905230406.30801-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <29d456ed-620c-8dc9-01f0-54f96b670b94@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2022 14:43, Laurent Pinchart wrote: > On Thu, Sep 08, 2022 at 01:40:39PM +0200, Krzysztof Kozlowski wrote: >> On 06/09/2022 01:04, Lad Prabhakar wrote: >>> Document the CRU block found on Renesas RZ/G2L (and alike) SoCs. >>> >>> Signed-off-by: Lad Prabhakar >>> Reviewed-by: Laurent Pinchart >> >> Thank you for your patch. There is something to discuss/improve. >> >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - renesas,r9a07g044-cru # RZ/G2{L,LC} >>> + - renesas,r9a07g054-cru # RZ/V2L >>> + - const: renesas,rzg2l-cru >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 3 >>> + >>> + interrupt-names: >>> + items: >>> + - const: image_conv >>> + - const: image_conv_err >>> + - const: axi_mst_err >>> + >>> + clocks: >>> + items: >>> + - description: CRU Main clock >>> + - description: CPU Register access clock >>> + - description: CRU image transfer clock >>> + >>> + clock-names: >>> + items: >>> + - const: vclk >>> + - const: pclk >>> + - const: aclk >> >> Drop the "clk" suffixes. Remaining names could be made a bit more readable. > > These names come from the documentation, isn't it better to match the > datasheet ? If datasheet calls it "vclk_really_clk_it_is_clk_clk", it's not the reason to use it. :) The "clk" is redundant even if the hardware engineer thought different. The same for IRQs ("tx" not "txirq"), for dmas ("tx" not "txdma"). Best regards, Krzysztof