From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C0DC05027 for ; Mon, 20 Feb 2023 15:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbjBTPWk (ORCPT ); Mon, 20 Feb 2023 10:22:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjBTPWk (ORCPT ); Mon, 20 Feb 2023 10:22:40 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B09CDF; Mon, 20 Feb 2023 07:22:38 -0800 (PST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31KBp51G007275; Mon, 20 Feb 2023 15:22:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=uOENAIxz3dv64fn0074xIalZSxlWY7KUxw26Na4aTcQ=; b=XWeeSxcEdqCrbgwJs6jO+qW+ewkSv0/gU2Waw0DoGzGhqJnjPWYnwYggyhz5MVo4n5CN AIpjscucvyZ4xIJzI9jlBdNacWaNKVemOgeik5l4HTUy220Lf/vj/c4PTE53gkclCdIr DAjNUoJYrtLFmWrVh4/ix+fUKIbieXjjdgljrvqY3W0hi39pseuiIUiIAwQVxZBy7TDH N+N7hemPWmCjwnRSTrL7iz0sbUkqx21VwMWID+CAXKJmBsKIB8KkKlTuUr0hrujVqvMU Jx9DRKSMwMY5uejBRza2slwe0gqwAFXXgeCv1At8qdJr44s8AEMWvk8syYjASVC2VPmD +w== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ntmcm5ddt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 15:22:34 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31KFMX4o026698 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 15:22:33 GMT Received: from [10.216.11.20] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Feb 2023 07:22:27 -0800 Message-ID: Date: Mon, 20 Feb 2023 20:52:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V2 5/6] arm64: dts: qcom: ipq9574: Add RPM related nodes Content-Language: en-US To: Konrad Dybcio , , , , , , , , , CC: , , , , , , References: <20230217142030.16012-1-quic_devipriy@quicinc.com> <20230217142030.16012-6-quic_devipriy@quicinc.com> <12d23d88-6f42-09ea-3f26-e1b7a0878767@linaro.org> <07342311-33e3-cf7e-38ed-5d54d83b43a3@linaro.org> From: Devi Priya In-Reply-To: <07342311-33e3-cf7e-38ed-5d54d83b43a3@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: -WpnjPLkYLpBnh6pDg6h6arN1RpFrsnN X-Proofpoint-GUID: -WpnjPLkYLpBnh6pDg6h6arN1RpFrsnN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_12,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=943 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302200140 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2/20/2023 8:06 PM, Konrad Dybcio wrote: > > > On 20.02.2023 14:53, Devi Priya wrote: >> Hi Konrad, >> >> Thanks for taking time to review the patch! > I appreciate your gratitude, but please don't toppost (a.k.a > don't reply in the first lines of the email), that's rather > frowned upon on LKML. > Sure, understood! >> >> On 2/17/2023 8:20 PM, Konrad Dybcio wrote: >>> >>> >>> On 17.02.2023 15:20, Devi Priya wrote: >>>> Add RPM Glink, RPM message RAM and SMPA1 regulator >>>> nodes to support frequency scaling on IPQ9574 >>>> >>>> Signed-off-by: Devi Priya >>>> --- >>>>   Changes in V2: >>>>     - Splitted the RPM and CPU Freq changes to individual patches >>>>     - Moved the regulators node to Board DT >>>>     - Dropped the regulator-always-on property >>>>     - Updated the compatible in regulators node with the existing >>>>       mp5496 compatible >>>> >>>>   arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts | 11 +++++++++++ >>>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi        | 17 +++++++++++++++++ >>>>   2 files changed, 28 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts >>>> index 21b53f34ce84..8a6caaeb0c4b 100644 >>>> --- a/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts >>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts >>>> @@ -57,6 +57,17 @@ >>>>       status = "okay"; >>>>   }; >>>>   +&rpm_requests { >>>> +    regulators { >>>> +        compatible = "qcom,rpm-mp5496-regulators"; >>>> + >>>> +        ipq9574_s1: s1 { >>>> +            regulator-min-microvolt = <587500>; >>>> +            regulator-max-microvolt = <1075000>; >>>> +        }; >>>> +    }; >>>> +}; >>> This belongs in a separate patch. >>> >> Do you recommend to move this change to the below patch in the next spin? >> [PATCH V2 6/6]arm64: dts: qcom: ipq9574: Add cpufreq support > Sounds good > > Also, I think you missed a newline before &rpm_requests now that > I look at it. Sure, will take care of that in V3 > > Konrad >>>> + >>>>   &sdhc_1 { >>>>       pinctrl-0 = <&sdc_default_state>; >>>>       pinctrl-names = "default"; >>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi >>>> index d20f3c7383f5..2f300cbab93e 100644 >>>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi >>>> @@ -133,6 +133,11 @@ >>>>           #size-cells = <2>; >>>>           ranges; >>>>   +        rpm_msg_ram: rpm@60000 { >>> Since this is a part of the MMIO region and not a part of DRAM, >>> we generally put this node under /soc with the compatible of >>> qcom,rpm-msg-ram and without no-map. >>> >>> And the node name then should be sram@. >> Sure, okay. Will update this in V3 >>> >>>> +            reg = <0x0 0x00060000 0x0 0x6000>; >>>> +            no-map; >>>> +        }; >>>> + >>>>           tz_region: tz@4a600000 { >>>>               reg = <0x0 0x4a600000 0x0 0x400000>; >>>>               no-map; >>>> @@ -768,6 +773,18 @@ >>>>           }; >>>>       }; >>>>   +    rpm-glink { >>> Alphabetically this should come before /soc. >> Okay >>> >>> Konrad >>>> +        compatible = "qcom,glink-rpm"; >>>> +        interrupts = ; >>>> +        qcom,rpm-msg-ram = <&rpm_msg_ram>; >>>> +        mboxes = <&apcs_glb 0>; >>>> + >>>> +        rpm_requests: glink-channel { >>>> +            compatible = "qcom,rpm-ipq9574"; >>>> +            qcom,glink-channels = "rpm_requests"; >>>> +        }; >>>> +    }; >>>> + >>>>       timer { >>>>           compatible = "arm,armv8-timer"; >>>>           interrupts = , >> Best Regards, >> Devi Priya