From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14446C433F5 for ; Tue, 12 Apr 2022 17:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356586AbiDLRMz (ORCPT ); Tue, 12 Apr 2022 13:12:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241381AbiDLRMz (ORCPT ); Tue, 12 Apr 2022 13:12:55 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B434AE3A for ; Tue, 12 Apr 2022 10:10:37 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id u15so19969884ejf.11 for ; Tue, 12 Apr 2022 10:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tMeG91UsHNrr1jeURVpZbmaohRl615AR2PfwG+NbeOY=; b=W15pYa9ziqyAmV1HDCWHwRBRTqSvEu/iOCz92WY5pNesraZw1EIXwkODapHvkpfWQF bN3aiY1CcNT/hQwQbxjwitUYoYN43PMoVPbVEKQxZ6YXG9ozUXVPamy5pkaWawwPmGyv oSolzNetAiUpnYTeqgPtRZnqXzaOWyjChvqAEde5vCprALDckGhhBt3eGbBJfxGiktxY k62OI5TowS0z/igbMvQF5ObocGgMiJ1JJrZX7fYKHLZzF7cm3Zr797FMLMumza6PjI6t 6tqsai9+0MDoGfPZRQOY1vDhhpzTT5giiyM+bV4eQOW4eZukRlXtTWc+pBIAJMS+t1MW D9Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tMeG91UsHNrr1jeURVpZbmaohRl615AR2PfwG+NbeOY=; b=2VC7KwP7f2AT+2FrD46/zG1QwtMlbEr6EfwYiu0Yp9aa415ktgBslZkniR1BGpPW+u Aw5YpFdYHDtKcGcjaAgqkkmplA38eURViOVasJyVmdaDl/6bJXnraPPIh2R3ErtF00TO BkddtO9ykYxHXGuhQhPaC2Him+i45glcpOjanLwZctAFUG50u7BuVBPiaWnJrAc1aO1d ePorp199IgI2awpc6cCEUtNZOK+hQEVAdaFgVc9pNEpAl+e/oQUufvoVp9BYpTtro8Eu JJpkUA9A8N/UNmcpanQTum5kkY2Tm0WxK23RmKrBSNg/S7kC5BP9/P1N3hkpPMX3jUI/ UIdg== X-Gm-Message-State: AOAM532dT+IVaeURBLY5+qlZ/op/wiU0wQyMvj2TtxwKh7GCGGMuu2r6 hkzMmvZaCYU7AZ0Uh/VF7ETIqg== X-Google-Smtp-Source: ABdhPJyW6jA3Sb1IAzTFPzNcXRxHllkbhigW34XX0ozquIGx3DHlGVvuMIBsx2RWUYdKx7U5B6SZJQ== X-Received: by 2002:a17:907:960f:b0:6e8:8df9:ce3a with SMTP id gb15-20020a170907960f00b006e88df9ce3amr10579415ejc.211.1649783435680; Tue, 12 Apr 2022 10:10:35 -0700 (PDT) Received: from [192.168.0.198] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id lb4-20020a170907784400b006e0d13f65e5sm13334706ejc.167.2022.04.12.10.10.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 10:10:35 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 19:10:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 5/9] dt-bindings: clk: mpfs: add defines for two new clocks Content-Language: en-US To: Conor.Dooley@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, palmer@rivosinc.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzk+dt@kernel.org Cc: Daire.McNamara@microchip.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220411085916.941433-1-conor.dooley@microchip.com> <20220411085916.941433-6-conor.dooley@microchip.com> <2e1b0207-dfb3-4cc5-d306-d2b0c6ed8cfd@microchip.com> <25feb189-4d97-f9b1-518e-69aae9a274e0@linaro.org> <74695e55-0b59-9236-be19-b02060ad4177@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <74695e55-0b59-9236-be19-b02060ad4177@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 12/04/2022 14:26, Conor.Dooley@microchip.com wrote: >>> Additionally MSSPLL is the source for CLK_{CPI,AXI,AHB} so I put it at >>> the top. I have no particular preference, so if you want them reordered >>> so that MSSPLL is under RTCREF just say the word :) >> >> Hm, are these in the same clock controller (device, not driver)? If yes, >> then please order them numerically. Pretty often one binding header have >> IDs for several clock controllers, so then it's a different case. > > Not *quite* sure what you mean by device. There is only one SoC that > this header applies to, but in the actual design the MSSPLL is in one > block, the RTC divider in another and CLK_CPU -> CLK_CFM in a third. By device I meant here part of Soc responsible for clocks which could be called a self-containing block. Pretty often such block maps to a Linux "struct device" or some wrapper around it (e.g. clock-controller device). For example such "self-containing block" has device node in DTS. Judging by your description, these will be different blocks / device nodes in DTS? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D477C433EF for ; Tue, 12 Apr 2022 17:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5JGeRjfYe8XdC+7W0HchpiijmtGQPbfF089oQqTPQm4=; b=sgeWX1N/g4+U8Z bsx1E6L+G6A0ZDoDjxozMzvtlKHzxC2kvaAeXfeIzgsrpMC+mKrs++ruJRU2wzi9MTDlhE2BJNYwS f3dTafXKBO7sUIgkC1MjThz4Jg8gvW/zc6Kf4jUB6kBhS0SkqaiLpgGgMfRTbaiLCudeKqgksPv2M HoLVQ5BddYwcdlLjHF29K7K+Tfu5jiuPYn8BwlcHNXQaZU6AZT6H18K1H0VH1vDwK1PBpuT8JG1jt sZHPYHKAwIvWyzCDVlnpmWvLKrQfMweH5GanMh3dd2aVkyZffgrUCA6hILi47/q9eudQNna3HdYXO C/aejeT8YGMtu1TZBaPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neK2L-00FBKz-EX; Tue, 12 Apr 2022 17:10:41 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neK2I-00FBJN-7h for linux-riscv@lists.infradead.org; Tue, 12 Apr 2022 17:10:39 +0000 Received: by mail-ej1-x634.google.com with SMTP id s18so16159492ejr.0 for ; Tue, 12 Apr 2022 10:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tMeG91UsHNrr1jeURVpZbmaohRl615AR2PfwG+NbeOY=; b=W15pYa9ziqyAmV1HDCWHwRBRTqSvEu/iOCz92WY5pNesraZw1EIXwkODapHvkpfWQF bN3aiY1CcNT/hQwQbxjwitUYoYN43PMoVPbVEKQxZ6YXG9ozUXVPamy5pkaWawwPmGyv oSolzNetAiUpnYTeqgPtRZnqXzaOWyjChvqAEde5vCprALDckGhhBt3eGbBJfxGiktxY k62OI5TowS0z/igbMvQF5ObocGgMiJ1JJrZX7fYKHLZzF7cm3Zr797FMLMumza6PjI6t 6tqsai9+0MDoGfPZRQOY1vDhhpzTT5giiyM+bV4eQOW4eZukRlXtTWc+pBIAJMS+t1MW D9Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tMeG91UsHNrr1jeURVpZbmaohRl615AR2PfwG+NbeOY=; b=qyeqS8Vg6xdSJFsJr9FJYHMPU6K8AikZ0Ftb9Pu5FX8SuSq68OzTN2yZ22/uLpE2sH kC2/2PtUgYmQc84mNDvhLQMIJ/luocXzGkpTHLoXpninwO43F1SG6gfvRnzhh6GmzLIu WfZBwXLlUGn60aVNoEFEFfB08AeyjBiHlCgKYS/RB59gL7RCv4ZR5jJCJSMHb1dASMsu Olv0KFxiahVPaRywW1RrA9pAv66tyQIusRWUgdq66CjusGLXvs6UqGEdJJmzrIE6Rck6 M7RtgtmrYZ0vUPYLm0j6NyRC2HtzMTjoCT3IbzYZ6UYxXPt6FhLkxRGY37o27TNeW4LS bLvw== X-Gm-Message-State: AOAM532SfHDLWMYhL5SJ5Gwuqk0XMFEs0TMwAQAqW46+33Wbiy+49/U6 aqwEB7+P0NeHaPG15eilRp/iOQ== X-Google-Smtp-Source: ABdhPJyW6jA3Sb1IAzTFPzNcXRxHllkbhigW34XX0ozquIGx3DHlGVvuMIBsx2RWUYdKx7U5B6SZJQ== X-Received: by 2002:a17:907:960f:b0:6e8:8df9:ce3a with SMTP id gb15-20020a170907960f00b006e88df9ce3amr10579415ejc.211.1649783435680; Tue, 12 Apr 2022 10:10:35 -0700 (PDT) Received: from [192.168.0.198] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id lb4-20020a170907784400b006e0d13f65e5sm13334706ejc.167.2022.04.12.10.10.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 10:10:35 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 19:10:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 5/9] dt-bindings: clk: mpfs: add defines for two new clocks Content-Language: en-US To: Conor.Dooley@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, palmer@rivosinc.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzk+dt@kernel.org Cc: Daire.McNamara@microchip.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220411085916.941433-1-conor.dooley@microchip.com> <20220411085916.941433-6-conor.dooley@microchip.com> <2e1b0207-dfb3-4cc5-d306-d2b0c6ed8cfd@microchip.com> <25feb189-4d97-f9b1-518e-69aae9a274e0@linaro.org> <74695e55-0b59-9236-be19-b02060ad4177@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <74695e55-0b59-9236-be19-b02060ad4177@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_101038_323189_8289794D X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 12/04/2022 14:26, Conor.Dooley@microchip.com wrote: >>> Additionally MSSPLL is the source for CLK_{CPI,AXI,AHB} so I put it at >>> the top. I have no particular preference, so if you want them reordered >>> so that MSSPLL is under RTCREF just say the word :) >> >> Hm, are these in the same clock controller (device, not driver)? If yes, >> then please order them numerically. Pretty often one binding header have >> IDs for several clock controllers, so then it's a different case. > > Not *quite* sure what you mean by device. There is only one SoC that > this header applies to, but in the actual design the MSSPLL is in one > block, the RTC divider in another and CLK_CPU -> CLK_CFM in a third. By device I meant here part of Soc responsible for clocks which could be called a self-containing block. Pretty often such block maps to a Linux "struct device" or some wrapper around it (e.g. clock-controller device). For example such "self-containing block" has device node in DTS. Judging by your description, these will be different blocks / device nodes in DTS? Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv