From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F445C07E96 for ; Thu, 15 Jul 2021 13:34:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABF5161167 for ; Thu, 15 Jul 2021 13:34:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABF5161167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m41Vb-0003ET-Qj for qemu-devel@archiver.kernel.org; Thu, 15 Jul 2021 09:34:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m41Ua-0001pt-2S for qemu-devel@nongnu.org; Thu, 15 Jul 2021 09:33:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m41UY-0000Qc-Ih for qemu-devel@nongnu.org; Thu, 15 Jul 2021 09:33:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626356010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gGJ5/859Mtl5rltK6d0hWjXVzwm95TpHpcV2ssGPGRY=; b=QMWU4bsXWYaVI9D8Rpp79fnWTtJyb/ev6X3JwBBjL+ti0sadQT6NbxHjb0o5FD79adUasj W8aUwf5/YJELWpStAoyaMzM+D3RmVsIVlFTIWCa4abSlKOYD7GFD11Ca0lpAAmZsfva5yr oC38+yzxBOVgR8U4PK/unjuUrwVRXzw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-jAoYZGZxOHC5mGEFL-Hesw-1; Thu, 15 Jul 2021 09:33:28 -0400 X-MC-Unique: jAoYZGZxOHC5mGEFL-Hesw-1 Received: by mail-wr1-f72.google.com with SMTP id 32-20020adf82a30000b029013b21c75294so3354585wrc.14 for ; Thu, 15 Jul 2021 06:33:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=gGJ5/859Mtl5rltK6d0hWjXVzwm95TpHpcV2ssGPGRY=; b=gxMEtUiE+zJBZI10bqn3e5Nq6qT0665Rl4Bz21JVkcCYzv0OS/w8AiCi4pwqWgGq5U MXsn5d4fxPOj2pohj+CvYXfhW/i230axP17xEirvccWwarB3cPRc6XXPbtKUrru1A8cy /NkQnUk0nJaBqA0Mkb2z4943jgF8FbJ5YaFK3DWsWVJOiovOKVVbKJrQ0v+aXLLzrgz+ Y3LEX2UfwiJE6wy5aKw7Xt4zAHUJcUVJK/qqm0vbKaCYv9qAB45BKxUX7qWdlyOF0MBF kYfN9AF65MmaTwxCQqFxx/+42StI8VCXrKPfSggS28vfPERCiwD7SpIdfKOpBkQuR1OM 4jCw== X-Gm-Message-State: AOAM533TMGHAvJi2p1H2PBADKG6/JCP/E915htXfgaAhe28iA6mMJMFS pNOKztElpKY3WqX95uFEMCPCMfMqyq/K2k0NcXwbTUcbSuv8CzmV5+G4gnednVoPcrEXY5OlUK7 vMFxOpW5DwEm4onagyojM/A9bSRbJDTIWXELS6+306Z5j1y40Hz0jEQw45neVMI3E X-Received: by 2002:a5d:48c6:: with SMTP id p6mr5679525wrs.45.1626356007762; Thu, 15 Jul 2021 06:33:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUw1yLnjqRkeAvT08RFdhcgwZm/IPZEJLtNsMEz4BbtlNceTiOkRxTW4xY6PefgYH1Hg14YQ== X-Received: by 2002:a5d:48c6:: with SMTP id p6mr5679492wrs.45.1626356007554; Thu, 15 Jul 2021 06:33:27 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id d18sm6687984wrw.7.2021.07.15.06.33.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 06:33:27 -0700 (PDT) Subject: Re: [PATCH v8 00/16] qemu_iotests: improve debugging options To: Emanuele Giuseppe Esposito , qemu-block@nongnu.org References: <20210705065711.127119-1-eesposit@redhat.com> From: Max Reitz Message-ID: Date: Thu, 15 Jul 2021 15:33:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210705065711.127119-1-eesposit@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-devel@nongnu.org, Cleber Rosa , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05.07.21 08:56, Emanuele Giuseppe Esposito wrote: > This series adds the option to attach gdbserver and valgrind > to the QEMU binary running in qemu_iotests. > It also allows to redirect QEMU binaries output of the python tests > to the stdout, instead of a log file. > > Patches 1-9 introduce the -gdb option to both python and bash tests, > 10-14 extend the already existing -valgrind flag to work also on > python tests, and patch 15-16 introduces -p to enable logging to stdout. > > In particular, patches 1,6,8,11 focus on extending the QMP socket timers > when using gdb/valgrind, otherwise the python tests will fail due to > delays in the QMP responses. > > Signed-off-by: Emanuele Giuseppe Esposito > --- > v7: > * Adjust documentation and error message when -gdb and -valgrind are set > at the same time [Eric] > * Add missing Acked-by [John] All patches I didn’t comment on: Reviewed-by: Max Reitz Which really only leaves the quotes around $GDB_OPTIONS in patch 8. Max