From: David Hildenbrand <david@redhat.com>
To: Muchun Song <songmuchun@bytedance.com>,
mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com
Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*
Date: Wed, 1 Jun 2022 11:32:37 +0200 [thread overview]
Message-ID: <ba64cd1b-c8ee-a4eb-f0cd-e16c26777d46@redhat.com> (raw)
In-Reply-To: <20220404074652.68024-4-songmuchun@bytedance.com>
On 04.04.22 09:46, Muchun Song wrote:
> The word of "free" is not expressive enough to express the feature of optimizing
> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
> In this patch , cheanup configs to make code more expressive.
Nit: why not simply CONFIG_HUGETLB_OPTIMIZE_VMEMMAP if we're touching
this already? At least I don't see value in the additional "PAGE" :)
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 4 ++--
> Documentation/admin-guide/mm/hugetlbpage.rst | 2 +-
> arch/arm64/Kconfig | 2 +-
> arch/arm64/mm/flush.c | 2 +-
> arch/x86/Kconfig | 2 +-
> arch/x86/mm/init_64.c | 2 +-
> fs/Kconfig | 16 ++++++++--------
> include/linux/hugetlb.h | 2 +-
> include/linux/mm.h | 2 +-
> include/linux/page-flags.h | 6 +++---
> mm/Makefile | 2 +-
> mm/hugetlb_vmemmap.c | 4 ++--
> mm/hugetlb_vmemmap.h | 4 ++--
> mm/sparse-vmemmap.c | 4 ++--
> 14 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 56edbe3f458f..89a58ac49d5f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1660,7 +1660,7 @@
> Format: size[KMG]
>
> hugetlb_free_vmemmap=
We didn't change the parameter name in #2, correct?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-06-01 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 7:46 [PATCH 0/3] cleanup hugetlb_vmemmap Muchun Song
2022-04-04 7:46 ` [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions Muchun Song
2022-05-31 23:47 ` Mike Kravetz
2022-05-31 23:58 ` Mike Kravetz
2022-06-01 9:28 ` David Hildenbrand
2022-06-01 10:48 ` Muchun Song
2022-06-01 10:49 ` David Hildenbrand
2022-04-04 7:46 ` [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap_enabled* Muchun Song
2022-06-01 0:01 ` Mike Kravetz
2022-06-01 9:29 ` David Hildenbrand
2022-04-04 7:46 ` [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* Muchun Song
2022-05-27 7:39 ` Vlastimil Babka
2022-05-27 7:47 ` Muchun Song
2022-06-01 0:20 ` Mike Kravetz
2022-06-01 9:32 ` David Hildenbrand [this message]
2022-06-01 9:54 ` Muchun Song
2022-06-01 10:10 ` David Hildenbrand
2022-06-01 11:56 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba64cd1b-c8ee-a4eb-f0cd-e16c26777d46@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=smuchun@bytedance.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.