From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CAD3C43334 for ; Wed, 15 Jun 2022 18:16:22 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.350270.576556 (Exim 4.92) (envelope-from ) id 1o1XYR-0007Sp-Ql; Wed, 15 Jun 2022 18:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 350270.576556; Wed, 15 Jun 2022 18:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o1XYR-0007Si-Nq; Wed, 15 Jun 2022 18:15:47 +0000 Received: by outflank-mailman (input) for mailman id 350270; Wed, 15 Jun 2022 18:15:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o1XYQ-0007Sc-LQ for xen-devel@lists.xenproject.org; Wed, 15 Jun 2022 18:15:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o1XYP-00087C-Ug; Wed, 15 Jun 2022 18:15:45 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.25.191]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o1XYP-0000p0-B9; Wed, 15 Jun 2022 18:15:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=74zxn/BFNywwaJ4ztXIs/6H/aTG9Vlub6f9bjuR1SMM=; b=XdaaulWWPv24up747cpikI5BNn edoMb6iA6Acpv/oKxjsY+Fyt4kz7s9+H4zwHHNVWJtcIbc/xd/ZZcUyHyYnX52noqC7goUXkG1LVf sKkTOzGTcsA1ofw3pR2zR5WNVdVyQYpIJq8g4BYP/ADOhXdE8k0IefnnPxdTNMFmZyt4=; Message-ID: Date: Wed, 15 Jun 2022 19:15:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 2/2] xen/arm: add FF-A mediator To: Volodymyr Babchuk , Jens Wiklander Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini References: <20220609061812.422130-1-jens.wiklander@linaro.org> <20220609061812.422130-3-jens.wiklander@linaro.org> <874k0nhvsq.fsf@epam.com> From: Julien Grall In-Reply-To: <874k0nhvsq.fsf@epam.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 14/06/2022 20:47, Volodymyr Babchuk wrote: >> menu "ARM errata workaround via the alternative framework" >> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >> index 1d862351d111..dbf5e593a069 100644 >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -20,6 +20,7 @@ obj-y += domain.o >> obj-y += domain_build.init.o >> obj-y += domctl.o >> obj-$(CONFIG_EARLY_PRINTK) += early_printk.o >> +obj-$(CONFIG_FFA) += ffa.o >> obj-y += gic.o >> obj-y += gic-v2.o >> obj-$(CONFIG_GICV3) += gic-v3.o >> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >> index 8110c1df8638..a93e6a9c4aef 100644 >> --- a/xen/arch/arm/domain.c >> +++ b/xen/arch/arm/domain.c >> @@ -27,6 +27,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, >> if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) >> goto fail; >> >> + if ( (rc = ffa_domain_init(d)) != 0 ) > > So, FFA support will be enabled for each domain? I think that this is > fine for experimental feature, but I want to hear maintainer's opinion. I would prefer if we add a flag to allow per-domain support. This would allow someone to use FFA with a trusted domain (e.g dom0) but not on non-trusted VMs (I don't yet know how secure it will be to expose it to everyone). Cheers, -- Julien Grall