All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Michal Simek <michal.simek@xilinx.com>, linux-kernel@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] microblaze: Fix simpleImage format generation
Date: Mon, 23 Apr 2018 10:53:14 +0200	[thread overview]
Message-ID: <ba7563d1-bf96-1660-15f4-faad07f52148@monstr.eu> (raw)
In-Reply-To: <b1738933cc6be175d4f97f11c00a05c0f3f81cad.1523368843.git.michal.simek@xilinx.com>


[-- Attachment #1.1: Type: text/plain, Size: 1830 bytes --]

On 10.4.2018 16:00, Michal Simek wrote:
> simpleImage generation was broken for some time. This patch is fixing
> steps how simpleImage.*.ub file is generated. Steps are objdump of
> vmlinux and create .ub.
> Also make sure that there is striped elf version with .strip suffix.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/microblaze/boot/Makefile | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
> index fd46385a4c97..600e5a198bd2 100644
> --- a/arch/microblaze/boot/Makefile
> +++ b/arch/microblaze/boot/Makefile
> @@ -22,17 +22,19 @@ $(obj)/linux.bin.gz: $(obj)/linux.bin FORCE
>  quiet_cmd_cp = CP      $< $@$2
>  	cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
>  
> -quiet_cmd_strip = STRIP   $@
> +quiet_cmd_strip = STRIP   $< $@$2
>  	cmd_strip = $(STRIP) -K microblaze_start -K _end -K __log_buf \
> -				-K _fdt_start vmlinux -o $@
> +				-K _fdt_start $< -o $@$2
>  
>  UIMAGE_LOADADDR = $(CONFIG_KERNEL_BASE_ADDR)
> +UIMAGE_IN = $@
> +UIMAGE_OUT = $@.ub
>  
>  $(obj)/simpleImage.%: vmlinux FORCE
>  	$(call if_changed,cp,.unstrip)
>  	$(call if_changed,objcopy)
>  	$(call if_changed,uimage)
> -	$(call if_changed,strip)
> -	@echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
> +	$(call if_changed,strip,.strip)
> +	@echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')'
>  
>  clean-files += simpleImage.*.unstrip linux.bin.ub
> 

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      reply	other threads:[~2018-04-23  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 14:00 [PATCH] microblaze: Fix simpleImage format generation Michal Simek
2018-04-23  8:53 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba7563d1-bf96-1660-15f4-faad07f52148@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=pombredanne@nexb.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.