All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karsten Graul <kgraul@linux.ibm.com>
To: Guangguan Wang <guangguan.wang@linux.alibaba.com>,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	tonylu@linux.alibaba.com
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net/smc: align the connect behaviour with TCP
Date: Thu, 12 May 2022 14:08:23 +0200	[thread overview]
Message-ID: <ba81cf0c-08c5-76e9-bfc8-369887454e52@linux.ibm.com> (raw)
In-Reply-To: <20220512031156.74054-3-guangguan.wang@linux.alibaba.com>

On 12/05/2022 05:11, Guangguan Wang wrote:
> Connect with O_NONBLOCK will not be completed immediately
> and returns -EINPROGRESS. It is possible to use selector/poll
> for completion by selecting the socket for writing. After select
> indicates writability, a second connect function call will return
> 0 to indicate connected successfully as TCP does, but smc returns
> -EISCONN. Use socket state for smc to indicate connect state, which
> can help smc aligning the connect behaviour with TCP.
> 
> Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
> ---

Acked-by: Karsten Graul <kgraul@linux.ibm.com>

Thank you.

      reply	other threads:[~2022-05-12 12:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  3:11 [PATCH net-next v2 0/2] net/smc: two fixes for using smc with io_uring Guangguan Wang
2022-05-12  3:11 ` [PATCH net-next v2 1/2] net/smc: non blocking recvmsg() return -EAGAIN when no data and signal_pending Guangguan Wang
2022-05-12  3:43   ` Tony Lu
2022-05-12  3:51     ` Guangguan Wang
2022-05-12 16:06       ` Jakub Kicinski
2022-05-12  3:11 ` [PATCH net-next v2 2/2] net/smc: align the connect behaviour with TCP Guangguan Wang
2022-05-12 12:08   ` Karsten Graul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba81cf0c-08c5-76e9-bfc8-369887454e52@linux.ibm.com \
    --to=kgraul@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=guangguan.wang@linux.alibaba.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tonylu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.