From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51473C2BA1A for ; Fri, 24 Apr 2020 09:22:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FFD020724 for ; Fri, 24 Apr 2020 09:22:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="Y5GSGtK4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FFD020724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRuX5-0001mK-46; Fri, 24 Apr 2020 09:22:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRuX4-0001mE-Gk for xen-devel@lists.xenproject.org; Fri, 24 Apr 2020 09:22:02 +0000 X-Inumbo-ID: 0e4a04e2-860d-11ea-9476-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0e4a04e2-860d-11ea-9476-12813bfff9fa; Fri, 24 Apr 2020 09:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Mime-Version:Content-Type: References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6LoKLiurglRXcB09V3LQifdnPvFZ0Y08tYsoZQRr1ow=; b=Y5GSGtK4WBubrOdODyO8a9v2KN M1Zwz1vbYi0guIaoFttUn1KqEiAd4BxHLp+G8Ij1NXXJPO+jqk0BLRZK/oVZm2GQ1kCGNmeQj3RQ+ DiROrXuIxpMllIX3IEPPVZ30m7PomT6FgPCn8rIoES4b5vouQ26F6rGVaEWWotrH3sjI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRuX3-0003uk-TO; Fri, 24 Apr 2020 09:22:01 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=u1bbd043a57dd5a.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jRuX3-0005Tb-JE; Fri, 24 Apr 2020 09:22:01 +0000 Message-ID: Subject: Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table From: Hongyan Xia To: Julien Grall , xen-devel@lists.xenproject.org Date: Fri, 24 Apr 2020 10:21:59 +0100 In-Reply-To: References: <12c4fe0c0c05b9f76377c085d8a6558beae64003.1587116799.git.hongyxia@amazon.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau =?ISO-8859-1?Q?Monn=E9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Julien, On Fri, 2020-04-24 at 09:59 +0100, Julien Grall wrote: > (resending) > > On 17/04/2020 10:52, Hongyan Xia wrote: > > From: Wei Liu > > > > Also fix a weird indentation. > > > > Signed-off-by: Wei Liu > > Signed-off-by: Hongyan Xia > > --- > > xen/arch/x86/x86_64/mm.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c > > index e85ef449f3..18210405f4 100644 > > --- a/xen/arch/x86/x86_64/mm.c > > +++ b/xen/arch/x86/x86_64/mm.c > > @@ -737,8 +737,8 @@ static void cleanup_frame_table(struct > > mem_hotadd_info *info) > > > > while (sva < eva) > > { > > - l3e = l4e_to_l3e(idle_pg_table[l4_table_offset(sva)])[ > > - l3_table_offset(sva)]; > > + l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(sva)], > > + l3_table_offset(sva)); > > This macro doesn't exist yet in the tree. It would be good to spell > out > the dependencies in the cover letter so this doesn't get merged > before > the dependency is merged. I believe the introduction of the new macros has been merged in staging as 6c8afe5aadb33761431b24157d99b25eac15fc7e. > Reviewed-by: Julien Grall Thanks! Hongyan