All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: rcar_iic: Scale delays
Date: Wed, 19 Sep 2018 16:52:25 +0200	[thread overview]
Message-ID: <ba8b463a-bbd5-4ad0-1981-8f413e898029@denx.de> (raw)
In-Reply-To: <90d3f923-9ce2-ac24-7986-abd349ebb5f1@gmail.com>

Hello Marek,

Am 19.09.2018 um 16:31 schrieb Marek Vasut:
> On 09/19/2018 02:42 PM, Marek Vasut wrote:
>> The delays in this driver used to depend on an incorrect timer frequency.
>> This was corrected in 7984ac8d1635, which caused this driver to function
>> incorrectly. Scale the delays accordingly to repair the malfunction.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> 
> This is wrong, ignore.

What is wrong ? This patch?

May a define for the delay value is better here ...

Hmm, thinking about it .. is this driver really only working with
correct delays ?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

  reply	other threads:[~2018-09-19 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 12:42 [U-Boot] [PATCH] i2c: rcar_iic: Scale delays Marek Vasut
2018-09-19 14:31 ` Marek Vasut
2018-09-19 14:52   ` Heiko Schocher [this message]
2018-09-19 15:46     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba8b463a-bbd5-4ad0-1981-8f413e898029@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.