All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org,
	ndesaulniers@google.com, catalin.marinas@arm.com,
	tglx@linutronix.de, luto@kernel.org
Subject: Re: [PATCH v5 0/6] arm64: vdso32: Address various issues
Date: Mon, 7 Oct 2019 15:37:35 +0100	[thread overview]
Message-ID: <ba8f3b9a-714f-08da-f93e-d832283697e2@arm.com> (raw)
In-Reply-To: <20191007141552.tbk3n6hgpq4cgane@willie-the-truck>

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

On 07/10/2019 15:15, Will Deacon wrote:
> On Mon, Oct 07, 2019 at 02:54:29PM +0100, Vincenzo Frascino wrote:
>> On 07/10/2019 14:31, Will Deacon wrote:
>>> On Thu, Oct 03, 2019 at 06:48:32PM +0100, Vincenzo Frascino wrote:
>>>> This patch series is meant to address the various compilation issues
>>>> reported recently for arm64 vdso32 [1].
>>>>
>>>> From v4, the series contains a cleanup of lib/vdso Kconfig as well since
>>>> CROSS_COMPILE_COMPAT_VDSO is not required anymore by any architecture.
>>>
>>> I've queued this up as fixes for 5.4, but I ended up making quite a few
>>> additional changes to address some other issues and minor inconsistencies
>>> I ran into. In particular, with my changes, you can now easily build the
>>> kernel with clang but the compat vDSO with gcc. The header files still need
>>> sorting out properly, but I think this is a decent starting point:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/fixes
>>>
>>> Please have a look.
>>>
>>
>> Thank you for letting me know, I will have a look.
> 
> Thanks.
> 
>> I see acked-by Catalin on the patches, did you post them in review somewhere? I
>> could not find them. Sorry
> 
> I pushed them out to a temporary vdso branch on Friday and Catalin looked at
> that. If you'd like me to post them as well, please let me know, although
> I'm keen to get this stuff sorted out by -rc3 without disabling the compat
> vDSO altogether (i.e. [1]). In other words, if you're ok with my changes on
> top of yours then let's go for that, otherwise let's punt this to 5.5 and
> try to fix the header mess at the same time.
> 

No need to repost them. I just got confused by the fact that they got acked and
I could not find them anywhere, hence my question.

I am keen to sort this thing as well, my personal preference is to not disable
compat vdso in 5.4.

I will download your tree, have a look at it and let you know my thoughts.

> Will
> 
> [1] https://lkml.kernel.org/r/20190925130926.50674-1-catalin.marinas@arm.com
> 

-- 
Regards,
Vincenzo

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Will Deacon <will@kernel.org>
Cc: ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
	ndesaulniers@google.com, linux-kernel@vger.kernel.org,
	luto@kernel.org, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/6] arm64: vdso32: Address various issues
Date: Mon, 7 Oct 2019 15:37:35 +0100	[thread overview]
Message-ID: <ba8f3b9a-714f-08da-f93e-d832283697e2@arm.com> (raw)
In-Reply-To: <20191007141552.tbk3n6hgpq4cgane@willie-the-truck>

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

On 07/10/2019 15:15, Will Deacon wrote:
> On Mon, Oct 07, 2019 at 02:54:29PM +0100, Vincenzo Frascino wrote:
>> On 07/10/2019 14:31, Will Deacon wrote:
>>> On Thu, Oct 03, 2019 at 06:48:32PM +0100, Vincenzo Frascino wrote:
>>>> This patch series is meant to address the various compilation issues
>>>> reported recently for arm64 vdso32 [1].
>>>>
>>>> From v4, the series contains a cleanup of lib/vdso Kconfig as well since
>>>> CROSS_COMPILE_COMPAT_VDSO is not required anymore by any architecture.
>>>
>>> I've queued this up as fixes for 5.4, but I ended up making quite a few
>>> additional changes to address some other issues and minor inconsistencies
>>> I ran into. In particular, with my changes, you can now easily build the
>>> kernel with clang but the compat vDSO with gcc. The header files still need
>>> sorting out properly, but I think this is a decent starting point:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/fixes
>>>
>>> Please have a look.
>>>
>>
>> Thank you for letting me know, I will have a look.
> 
> Thanks.
> 
>> I see acked-by Catalin on the patches, did you post them in review somewhere? I
>> could not find them. Sorry
> 
> I pushed them out to a temporary vdso branch on Friday and Catalin looked at
> that. If you'd like me to post them as well, please let me know, although
> I'm keen to get this stuff sorted out by -rc3 without disabling the compat
> vDSO altogether (i.e. [1]). In other words, if you're ok with my changes on
> top of yours then let's go for that, otherwise let's punt this to 5.5 and
> try to fix the header mess at the same time.
> 

No need to repost them. I just got confused by the fact that they got acked and
I could not find them anywhere, hence my question.

I am keen to sort this thing as well, my personal preference is to not disable
compat vdso in 5.4.

I will download your tree, have a look at it and let you know my thoughts.

> Will
> 
> [1] https://lkml.kernel.org/r/20190925130926.50674-1-catalin.marinas@arm.com
> 

-- 
Regards,
Vincenzo

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-07 14:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 17:48 [PATCH v5 0/6] arm64: vdso32: Address various issues Vincenzo Frascino
2019-10-03 17:48 ` Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 1/6] arm64: vdso32: Fix syncconfig errors Vincenzo Frascino
2019-10-03 17:48   ` Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 2/6] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-10-03 17:48   ` Vincenzo Frascino
2019-10-03 20:18   ` Nick Desaulniers
2019-10-03 20:18     ` Nick Desaulniers
2019-10-03 20:49     ` Will Deacon
2019-10-03 20:49       ` Will Deacon
2019-10-03 20:56       ` Nick Desaulniers
2019-10-03 20:56         ` Nick Desaulniers
2019-10-03 20:59         ` Will Deacon
2019-10-03 20:59           ` Will Deacon
2019-10-03 21:50           ` Nick Desaulniers
2019-10-03 21:50             ` Nick Desaulniers
2019-10-03 17:48 ` [PATCH v5 3/6] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-10-03 17:48   ` Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 4/6] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino
2019-10-03 17:48   ` Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 5/6] arm64: Remove vdso_datapage.h Vincenzo Frascino
2019-10-03 17:48   ` Vincenzo Frascino
2019-10-03 17:48 ` [PATCH v5 6/6] lib: vdso: Remove CROSS_COMPILE_COMPAT_VDSO Vincenzo Frascino
2019-10-03 17:48   ` Vincenzo Frascino
2019-10-07 13:31 ` [PATCH v5 0/6] arm64: vdso32: Address various issues Will Deacon
2019-10-07 13:31   ` Will Deacon
2019-10-07 13:54   ` Vincenzo Frascino
2019-10-07 13:54     ` Vincenzo Frascino
2019-10-07 14:15     ` Will Deacon
2019-10-07 14:15       ` Will Deacon
2019-10-07 14:37       ` Vincenzo Frascino [this message]
2019-10-07 14:37         ` Vincenzo Frascino
2019-10-07 17:48         ` Vincenzo Frascino
2019-10-07 17:48           ` Vincenzo Frascino
2019-10-08  9:07           ` Will Deacon
2019-10-08  9:07             ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba8f3b9a-714f-08da-f93e-d832283697e2@arm.com \
    --to=vincenzo.frascino@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.