From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B710C433EF for ; Tue, 21 Sep 2021 07:48:17 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 88E2061156 for ; Tue, 21 Sep 2021 07:48:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 88E2061156 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73F1140DF7; Tue, 21 Sep 2021 09:48:15 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id DC67B40683 for ; Tue, 21 Sep 2021 09:48:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="284318817" X-IronPort-AV: E=Sophos;i="5.85,310,1624345200"; d="scan'208";a="284318817" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 00:48:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,310,1624345200"; d="scan'208";a="518126587" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 21 Sep 2021 00:48:11 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 21 Sep 2021 00:48:11 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 21 Sep 2021 00:48:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 21 Sep 2021 00:48:11 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 21 Sep 2021 00:48:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1IaWNSe+2Anlq/eRW73uwgvWvHulrHf2Kg3z9scqtmNFgo181xmfXLpe8C2wLtjVMgi23jrtOu8GGWGofgzgDVAPwHTfEXMtKa1anBKYaFyQzBBIZp+ChzitHZGKc5r/c2B43Ubnx6Ku0v//P8XOgx0q+xrAqa0hNBJ6isjAdiQR3Sq04HZ/decTMEozNQa073CsZ8Nq0VdYXPsIDOfghA42BmOWwI+q9MxobQ1WnZdS8D8GJmlMfmAJgwU+0prXUGlQMQaULV74fOVHK3WWg1osT4uHkjyChsV5hbopGS1aOvMJCNsTClM6XIL6JmYcK9cuiwJGSjAyf1OvNSGpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q01XnaEczfjEuLv8V3L3ZF86ekUHGS9yupbiIyKA5Ms=; b=I40IhBle86bKiV/vsn0VlTJu2jiuRzrYE/MucHPFIZIm+y0Or3xvOPjyumzKcU2SLh8GQZtP1pkzs9mTK7ARiEyMCEwrFd/vFVj0fQMttJ1CPYnuaT8HMYKeNespW1zg1oqwXlsaMGEM8/xRpMNK4TjLVtIV+VdqVYmcqAo8DcQ5WTzr71L3jK7ZwtJkqP5kc+DKmn8Swzutmh+JQ6GQ1Mk8nk/5qmTbcL55JbdTMj0yCwMhaNRAVeKabhrLH1+TEVYQ0XZq5fF9w4HWiFxr/LJcvT4InEdL+UsiNyTpLn8YPXsgifB7SIF04iduIQtKuG9u2usoCMJfob02YPTD4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q01XnaEczfjEuLv8V3L3ZF86ekUHGS9yupbiIyKA5Ms=; b=YSDjejIx19321FahpoEJdVFOf7OQ+MPW+xKCxgzDm0qi0dnLLd+CFsq2tBaDgJhr6LmttQnzphmUiYblN0Fs/9zpyQeJu7l63NuhXmq/CzUoOZHjA6HilTnNmVEfh5bguob0LmzzFzSv5B0tQXFGQF+OmSEFcbJundPrc51rz9k= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5192.namprd11.prod.outlook.com (2603:10b6:510:3b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Tue, 21 Sep 2021 07:48:10 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021 07:48:10 +0000 To: "Min Hu (Connor)" , CC: References: <20210914060219.45890-1-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 21 Sep 2021 08:48:04 +0100 In-Reply-To: <20210914060219.45890-1-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB8PR06CA0064.eurprd06.prod.outlook.com (2603:10a6:10:120::38) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0064.eurprd06.prod.outlook.com (2603:10a6:10:120::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Tue, 21 Sep 2021 07:48:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d672c2f2-8396-4be5-35c0-08d97cd4286b X-MS-TrafficTypeDiagnostic: PH0PR11MB5192: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:580; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IExgafkjYoGd1BGSKeL95hCFsALB6+8G3Q+Ue9YJn77tD6w4RnIUnDtFQqMAcmlwP/UDXuUjTH8Vvx2xcI0ZBB0Dn6Yl+elW+6/DNg6PJRZHe8qCuonpuJXglrfVrLYlOLyV/Pb/qdrHJToNKRnjvHDSxs/gc9bfzVdSds98hezfjW8Y/4n0WrN5ULT4/VZ4oJJDrnHy+5xRL1DlBJ96OKmtMmBvrij/hlLYUWkabgsWSu9iC/Rw/9des1CggW0lK4XgxD5BdoMDQUfGfNpGviWGKe2z347ZUAdhdOG9JY8Isdo37132X90yeEvmpTZ4hMhzL6rWo3k4FdSXuN/1KMNLzU8exDktnRx+7VGN5V3v3oBqiqOisXn4uPTH6NeQBZIUWHjuYQk5wQvwRx07gLhHwMvNmFdoRNMDDCEybm2l7oBm+OXtC9hb8ux3/+dGmS5RxsD17LphJ8JrclHElpjdH2Y9i5bXNyJygxKsroSYOPThx5mIt5aQIPlx0VDmTOaCtJeWDu9fCNPREAgyFKxio2JU/piLifK2//8StguIRQTrC5MretD8kg02KJNx8YYUgsmyj7qBTHUF96LqYeyJKrfCo9bhEL3aKAGHbKEHqM4n4dXKY6XNMnVuw1PtTCDYPNI1E6XIWSxTq4iGLg0ILw/GMxu46l+yIaudI6abu2dD2RAIz3Ck2Zf+DuLNc565PCJZkcBMip40AO/0wg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(6486002)(4744005)(38100700002)(44832011)(8676002)(2616005)(508600001)(26005)(5660300002)(186003)(31686004)(86362001)(66946007)(4326008)(316002)(6666004)(53546011)(16576012)(66556008)(83380400001)(66476007)(36756003)(31696002)(8936002)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnF0UmNJYzNMMmZDcG1sa1FnNzkrOGdiYjNXS014OEJJYXIwSklWSDZzZjBx?= =?utf-8?B?TnA1MEd5dW51RE1Xb2F5aGwybmp6NHdubFRwZnE2bDBsVmJwcVVrYUpEZGVJ?= =?utf-8?B?aXozQVRzQXNnRkl1UU1YcFA4R053N2JWcjNSaCtLa0hXWk80aUpwV3diMHdX?= =?utf-8?B?TE9jaSsxTlg0c1plYkVBY0ZJZ20xQnFMMzE4dUlXcldSaFQrWkF2Z3ZTQ2la?= =?utf-8?B?UXZKNTFCY1pBWGVEK0l2OTZNYnRqdVRqVTBodjFZTG9pYmhMT1JMY1kyNU41?= =?utf-8?B?NndpZkdEZFI2dnBvWTN5NGRnR3hKUmx1K1ZjV0hWNWMvQUZVMFdPa1BCYmRM?= =?utf-8?B?RnR5WnVKVUY3ZGRab1dRMTMwN3hIYU00Yk1wS2w3UHpEMkQ0Q3FOaGJtbVBI?= =?utf-8?B?MnJ5eUtKOFlvVmxLRk5RME9ybUoxdVVoLzYxbkh1Szk2cmtUY2trZmtjSVdZ?= =?utf-8?B?U1llK0h2SXVJMEZTcHNTcTJhLzh4QitzQ1JEZU5Ed1A4RmpUMmxxd3F1dUxI?= =?utf-8?B?U0g1WDJGdk9CbEVYS3VGbmttYVBBMUVsR01hRjFHVmUwYVE3cUY3MWttZDhl?= =?utf-8?B?NWNXKzNHQkp0Tjh6eFVvQThIWXByUmNPZ0l6SXB3Q0lpWkJLUlZYakpQREZl?= =?utf-8?B?WDU5WlJkUkRUUVU4a3psK2hKc2FNQWZHeXBuaVBiN1lTdFJRRlpDNElqNkFP?= =?utf-8?B?WHFuOVZNRGdzTkMzc1o2V3N3YzJMS1gydUJTc2trT2t4RFlxcmdMTC9YV1p4?= =?utf-8?B?RjBEUytZWElpY0J0MXN2a3ltTDNZMTBpbXdDWmhpajNhZHBLWVM0TjZLb1l5?= =?utf-8?B?aXg0bEF5cFVDWnBJNVJWRmc2ZHFRWDM3ZzVsbjdybkZyMDFRT04wRjBSbkpM?= =?utf-8?B?TjMyU0RtNGN0Tzl4SjdRTHNyS2p2TVpLbmpHY2xlRlNXUW0xRytKbFBwV2Fi?= =?utf-8?B?dFo4Y2VnaVVVTTVmZ1U0eks0VllMcGZUMUdzVVNvamF0UitSTVkvenBMZkdz?= =?utf-8?B?SllJT3VLSlZoSzd1ZlloRWlqd3Z5ekh4cnRpQ2RNMDBueFpNYk9BOVR6K2ZH?= =?utf-8?B?M1Y1YzI4c1M1TU85Y25hSENTbkFzM3ZTZy82NnRsQi9xNHh5VHp1clNVNHNE?= =?utf-8?B?akpCcktkZk00OVlsZjBwWXl3OW1ZUDJBdUd0bGZDTjNhcmVMK2NRMkJ5V0Fs?= =?utf-8?B?N3oyRHNQWFFmSHlidzBVVzgwOGFXaTZueDQ3T2hsQWNVd2ZVNEJNdlRrb3lU?= =?utf-8?B?cm9TaXZPYkNNdWVxcUEzSDEzODZIZTBuYTduSEtSQkFGWklocVpHeXc2ckJa?= =?utf-8?B?WmFHOGdTRkh1djYzU0R0eDFlcytwV1htMHNxL3ozL0tEYVVsZ3pta2tYbVhS?= =?utf-8?B?ZFZuLzRiVzNrNE9GRC96WUJGZ1oyMDZkb2FGZmwzZUNiVlZzUTREN29WUDJ2?= =?utf-8?B?ODBMQUNvcC9RZjdvRCtjM25WZEdQVEZOT2cxV1Q5b2c1RDlkd0d6T3RVNHNI?= =?utf-8?B?KzRsRDhBOHJENFpNOHl2MHU5VWhBYzhST01oSVNoVVNYbngzOGJUa3pPdG8r?= =?utf-8?B?ZytQMXhpdjZnR0oyajJvdk1JVmxicGtDUndkVEg1R1k2SnYyU2EwRjBDYUNr?= =?utf-8?B?ZlZSaUthY3NkemF6MVp0bXhXOHRKRFA4UW1naXdFd2h3TTRFRjg1VW5ML1ZS?= =?utf-8?B?bHQxaG55ZFB6OXhmVHA1SWZYQkpUQk9mZVdPRW1LMWhMV09ObTBWTEZucElP?= =?utf-8?Q?oU3gi8SxM/oFojSvsdBNNaH+sdhIrOtAdlECYnl?= X-MS-Exchange-CrossTenant-Network-Message-Id: d672c2f2-8396-4be5-35c0-08d97cd4286b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 07:48:10.3935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QYAsWj2vcSAkWu1Grn0QYmc4l1QXyjzT8plY2v6pBink4PVW2/nAyh9E5aGazlHqKO1NuQ2/4iqrHcjwQ/mEEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5192 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] examples/kni: add dev close step when kni free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/2021 7:02 AM, Min Hu (Connor) wrote: > From: Huisong Li > > This patch adds dev_close() step to release network adapter resources > when kni free. > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > --- > examples/kni/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/examples/kni/main.c b/examples/kni/main.c > index beabb3c848..2a993a0ca4 100644 > --- a/examples/kni/main.c > +++ b/examples/kni/main.c > @@ -1031,6 +1031,7 @@ kni_free_kni(uint16_t port_id) > if (ret != 0) > RTE_LOG(ERR, APP, "Failed to stop port %d: %s\n", > port_id, rte_strerror(-ret)); > + rte_eth_dev_close(port_id); > > return 0; > } > Acked-by: Ferruh Yigit Closing the port not directly related to the 'kni free', just both done before exiting the app, so I would update the patch title to something like: examples/kni: close port before exit